mirror of
https://github.com/torvalds/linux.git
synced 2024-12-28 22:02:28 +00:00
3000ce3c52
Replace the CPU device PM QoS used for the management of min and max
frequency constraints in cpufreq (and its users) with per-policy
frequency QoS to avoid problems with cpufreq policies covering
more then one CPU.
Namely, a cpufreq driver is registered with the subsys interface
which calls cpufreq_add_dev() for each CPU, starting from CPU0, so
currently the PM QoS notifiers are added to the first CPU in the
policy (i.e. CPU0 in the majority of cases).
In turn, when the cpufreq driver is unregistered, the subsys interface
doing that calls cpufreq_remove_dev() for each CPU, starting from CPU0,
and the PM QoS notifiers are only removed when cpufreq_remove_dev() is
called for the last CPU in the policy, say CPUx, which as a rule is
not CPU0 if the policy covers more than one CPU. Then, the PM QoS
notifiers cannot be removed, because CPUx does not have them, and
they are still there in the device PM QoS notifiers list of CPU0,
which prevents new PM QoS notifiers from being registered for CPU0
on the next attempt to register the cpufreq driver.
The same issue occurs when the first CPU in the policy goes offline
before unregistering the driver.
After this change it does not matter which CPU is the policy CPU at
the driver registration time and whether or not it is online all the
time, because the frequency QoS is per policy and not per CPU.
Fixes: 67d874c3b2 ("cpufreq: Register notifiers with the PM QoS framework")
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Reported-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Diagnosed-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/linux-pm/5ad2624194baa2f53acc1f1e627eb7684c577a19.1562210705.git.viresh.kumar@linaro.org/T/#md2d89e95906b8c91c15f582146173dce2e86e99f
Link: https://lore.kernel.org/linux-pm/20191017094612.6tbkwoq4harsjcqv@vireshk-i7/T/#m30d48cc23b9a80467fbaa16e30f90b3828a5a29b
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
137 lines
2.6 KiB
C
137 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
#include <linux/types.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/pm_qos.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/init.h>
|
|
#include <linux/wait.h>
|
|
#include <linux/cpu.h>
|
|
#include <linux/cpufreq.h>
|
|
|
|
#include <asm/prom.h>
|
|
|
|
#include "windfarm.h"
|
|
|
|
#define VERSION "0.3"
|
|
|
|
static int clamped;
|
|
static struct wf_control *clamp_control;
|
|
static struct freq_qos_request qos_req;
|
|
static unsigned int min_freq, max_freq;
|
|
|
|
static int clamp_set(struct wf_control *ct, s32 value)
|
|
{
|
|
unsigned int freq;
|
|
|
|
if (value) {
|
|
freq = min_freq;
|
|
printk(KERN_INFO "windfarm: Clamping CPU frequency to "
|
|
"minimum !\n");
|
|
} else {
|
|
freq = max_freq;
|
|
printk(KERN_INFO "windfarm: CPU frequency unclamped !\n");
|
|
}
|
|
clamped = value;
|
|
|
|
return freq_qos_update_request(&qos_req, freq);
|
|
}
|
|
|
|
static int clamp_get(struct wf_control *ct, s32 *value)
|
|
{
|
|
*value = clamped;
|
|
return 0;
|
|
}
|
|
|
|
static s32 clamp_min(struct wf_control *ct)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static s32 clamp_max(struct wf_control *ct)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
static const struct wf_control_ops clamp_ops = {
|
|
.set_value = clamp_set,
|
|
.get_value = clamp_get,
|
|
.get_min = clamp_min,
|
|
.get_max = clamp_max,
|
|
.owner = THIS_MODULE,
|
|
};
|
|
|
|
static int __init wf_cpufreq_clamp_init(void)
|
|
{
|
|
struct cpufreq_policy *policy;
|
|
struct wf_control *clamp;
|
|
struct device *dev;
|
|
int ret;
|
|
|
|
policy = cpufreq_cpu_get(0);
|
|
if (!policy) {
|
|
pr_warn("%s: cpufreq policy not found cpu0\n", __func__);
|
|
return -EPROBE_DEFER;
|
|
}
|
|
|
|
min_freq = policy->cpuinfo.min_freq;
|
|
max_freq = policy->cpuinfo.max_freq;
|
|
|
|
ret = freq_qos_add_request(&policy->constraints, &qos_req, FREQ_QOS_MAX,
|
|
max_freq);
|
|
|
|
cpufreq_cpu_put(policy);
|
|
|
|
if (ret < 0) {
|
|
pr_err("%s: Failed to add freq constraint (%d)\n", __func__,
|
|
ret);
|
|
return ret;
|
|
}
|
|
|
|
dev = get_cpu_device(0);
|
|
if (unlikely(!dev)) {
|
|
pr_warn("%s: No cpu device for cpu0\n", __func__);
|
|
ret = -ENODEV;
|
|
goto fail;
|
|
}
|
|
|
|
clamp = kmalloc(sizeof(struct wf_control), GFP_KERNEL);
|
|
if (clamp == NULL) {
|
|
ret = -ENOMEM;
|
|
goto fail;
|
|
}
|
|
|
|
clamp->ops = &clamp_ops;
|
|
clamp->name = "cpufreq-clamp";
|
|
ret = wf_register_control(clamp);
|
|
if (ret)
|
|
goto free;
|
|
|
|
clamp_control = clamp;
|
|
return 0;
|
|
|
|
free:
|
|
kfree(clamp);
|
|
fail:
|
|
freq_qos_remove_request(&qos_req);
|
|
return ret;
|
|
}
|
|
|
|
static void __exit wf_cpufreq_clamp_exit(void)
|
|
{
|
|
if (clamp_control) {
|
|
wf_unregister_control(clamp_control);
|
|
freq_qos_remove_request(&qos_req);
|
|
}
|
|
}
|
|
|
|
|
|
module_init(wf_cpufreq_clamp_init);
|
|
module_exit(wf_cpufreq_clamp_exit);
|
|
|
|
MODULE_AUTHOR("Benjamin Herrenschmidt <benh@kernel.crashing.org>");
|
|
MODULE_DESCRIPTION("CPU frequency clamp for PowerMacs thermal control");
|
|
MODULE_LICENSE("GPL");
|
|
|