mirror of
https://github.com/torvalds/linux.git
synced 2024-09-23 08:23:44 +00:00
57d0355451
We have #defines for all the individual sensor registers and value/mask pairs #defined at the top of the file and used at exactly one spot. This is usually good if the #defines give a meaning to the opaque magic numbers. However in this case, the semantic meaning is inherent in the name of the C99-addressable fields, and that means duplication of information, and only makes the code hard to maintain since you every time have to add a new #define AND update the site where it is to be used. Get rid of the #defines and just open code the values into the appropriate struct elements. Make sure to explicitly address the .hz and .value fields in the st_sensor_odr_avl struct so that the meaning of all values is clear. This patch is purely syntactic should have no semantic effect. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org> |
||
|---|---|---|
| .. | ||
| ak8974.c | ||
| ak8975.c | ||
| bmc150_magn_i2c.c | ||
| bmc150_magn_spi.c | ||
| bmc150_magn.c | ||
| bmc150_magn.h | ||
| hid-sensor-magn-3d.c | ||
| hmc5843_core.c | ||
| hmc5843_i2c.c | ||
| hmc5843_spi.c | ||
| hmc5843.h | ||
| Kconfig | ||
| mag3110.c | ||
| Makefile | ||
| mmc35240.c | ||
| st_magn_buffer.c | ||
| st_magn_core.c | ||
| st_magn_i2c.c | ||
| st_magn_spi.c | ||
| st_magn.h | ||