mirror of
https://github.com/torvalds/linux.git
synced 2024-11-18 01:51:53 +00:00
7c279229f9
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
104 lines
2.5 KiB
C
104 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* AD7606 Parallel Interface ADC driver
|
|
*
|
|
* Copyright 2011 Analog Devices Inc.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/types.h>
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
|
|
#include <linux/iio/iio.h>
|
|
#include "ad7606.h"
|
|
|
|
static int ad7606_par16_read_block(struct device *dev,
|
|
int count, void *buf)
|
|
{
|
|
struct iio_dev *indio_dev = dev_get_drvdata(dev);
|
|
struct ad7606_state *st = iio_priv(indio_dev);
|
|
|
|
insw((unsigned long)st->base_address, buf, count);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct ad7606_bus_ops ad7606_par16_bops = {
|
|
.read_block = ad7606_par16_read_block,
|
|
};
|
|
|
|
static int ad7606_par8_read_block(struct device *dev,
|
|
int count, void *buf)
|
|
{
|
|
struct iio_dev *indio_dev = dev_get_drvdata(dev);
|
|
struct ad7606_state *st = iio_priv(indio_dev);
|
|
|
|
insb((unsigned long)st->base_address, buf, count * 2);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct ad7606_bus_ops ad7606_par8_bops = {
|
|
.read_block = ad7606_par8_read_block,
|
|
};
|
|
|
|
static int ad7606_par_probe(struct platform_device *pdev)
|
|
{
|
|
const struct platform_device_id *id = platform_get_device_id(pdev);
|
|
struct resource *res;
|
|
void __iomem *addr;
|
|
resource_size_t remap_size;
|
|
int irq;
|
|
|
|
irq = platform_get_irq(pdev, 0);
|
|
if (irq < 0)
|
|
return irq;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
addr = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(addr))
|
|
return PTR_ERR(addr);
|
|
|
|
remap_size = resource_size(res);
|
|
|
|
return ad7606_probe(&pdev->dev, irq, addr,
|
|
id->name, id->driver_data,
|
|
remap_size > 1 ? &ad7606_par16_bops :
|
|
&ad7606_par8_bops);
|
|
}
|
|
|
|
static const struct platform_device_id ad7606_driver_ids[] = {
|
|
{ .name = "ad7605-4", .driver_data = ID_AD7605_4, },
|
|
{ .name = "ad7606-4", .driver_data = ID_AD7606_4, },
|
|
{ .name = "ad7606-6", .driver_data = ID_AD7606_6, },
|
|
{ .name = "ad7606-8", .driver_data = ID_AD7606_8, },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(platform, ad7606_driver_ids);
|
|
|
|
static const struct of_device_id ad7606_of_match[] = {
|
|
{ .compatible = "adi,ad7605-4" },
|
|
{ .compatible = "adi,ad7606-4" },
|
|
{ .compatible = "adi,ad7606-6" },
|
|
{ .compatible = "adi,ad7606-8" },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ad7606_of_match);
|
|
|
|
static struct platform_driver ad7606_driver = {
|
|
.probe = ad7606_par_probe,
|
|
.id_table = ad7606_driver_ids,
|
|
.driver = {
|
|
.name = "ad7606",
|
|
.pm = AD7606_PM_OPS,
|
|
.of_match_table = ad7606_of_match,
|
|
},
|
|
};
|
|
module_platform_driver(ad7606_driver);
|
|
|
|
MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
|
|
MODULE_DESCRIPTION("Analog Devices AD7606 ADC");
|
|
MODULE_LICENSE("GPL v2");
|