mirror of
https://github.com/torvalds/linux.git
synced 2024-11-14 16:12:02 +00:00
9a95c5bfbf
A panic happens in ima_match_policy: BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 PGD 42f873067 P4D 0 Oops: 0000 [#1] SMP NOPTI CPU: 5 PID:1286325
Comm: kubeletmonit.sh Kdump: loaded Tainted: P Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 RIP: 0010:ima_match_policy+0x84/0x450 Code: 49 89 fc 41 89 cf 31 ed 89 44 24 14 eb 1c 44 39 7b 18 74 26 41 83 ff 05 74 20 48 8b 1b 48 3b 1d f2 b9 f4 00 0f 84 9c 01 00 00 <44> 85 73 10 74 ea 44 8b 6b 14 41 f6 c5 01 75 d4 41 f6 c5 02 74 0f RSP: 0018:ff71570009e07a80 EFLAGS: 00010207 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000200 RDX: ffffffffad8dc7c0 RSI: 0000000024924925 RDI: ff3e27850dea2000 RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffffabfce739 R10: ff3e27810cc42400 R11: 0000000000000000 R12: ff3e2781825ef970 R13: 00000000ff3e2785 R14: 000000000000000c R15: 0000000000000001 FS: 00007f5195b51740(0000) GS:ff3e278b12d40000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000010 CR3: 0000000626d24002 CR4: 0000000000361ee0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: ima_get_action+0x22/0x30 process_measurement+0xb0/0x830 ? page_add_file_rmap+0x15/0x170 ? alloc_set_pte+0x269/0x4c0 ? prep_new_page+0x81/0x140 ? simple_xattr_get+0x75/0xa0 ? selinux_file_open+0x9d/0xf0 ima_file_check+0x64/0x90 path_openat+0x571/0x1720 do_filp_open+0x9b/0x110 ? page_counter_try_charge+0x57/0xc0 ? files_cgroup_alloc_fd+0x38/0x60 ? __alloc_fd+0xd4/0x250 ? do_sys_open+0x1bd/0x250 do_sys_open+0x1bd/0x250 do_syscall_64+0x5d/0x1d0 entry_SYSCALL_64_after_hwframe+0x65/0xca Commitc7423dbdbc
("ima: Handle -ESTALE returned by ima_filter_rule_match()") introduced call to ima_lsm_copy_rule within a RCU read-side critical section which contains kmalloc with GFP_KERNEL. This implies a possible sleep and violates limitations of RCU read-side critical sections on non-PREEMPT systems. Sleeping within RCU read-side critical section might cause synchronize_rcu() returning early and break RCU protection, allowing a UAF to happen. The root cause of this issue could be described as follows: | Thread A | Thread B | | |ima_match_policy | | | rcu_read_lock | |ima_lsm_update_rule | | | synchronize_rcu | | | | kmalloc(GFP_KERNEL)| | | sleep | ==> synchronize_rcu returns early | kfree(entry) | | | | entry = entry->next| ==> UAF happens and entry now becomes NULL (or could be anything). | | entry->action | ==> Accessing entry might cause panic. To fix this issue, we are converting all kmalloc that is called within RCU read-side critical section to use GFP_ATOMIC. Fixes:c7423dbdbc
("ima: Handle -ESTALE returned by ima_filter_rule_match()") Cc: stable@vger.kernel.org Signed-off-by: GUO Zihua <guozihua@huawei.com> Acked-by: John Johansen <john.johansen@canonical.com> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com> [PM: fixed missing comment, long lines, !CONFIG_IMA_LSM_RULES case] Signed-off-by: Paul Moore <paul@paul-moore.com>
292 lines
5.8 KiB
C
292 lines
5.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* AppArmor security module
|
|
*
|
|
* This file contains AppArmor auditing functions
|
|
*
|
|
* Copyright (C) 1998-2008 Novell/SUSE
|
|
* Copyright 2009-2010 Canonical Ltd.
|
|
*/
|
|
|
|
#include <linux/audit.h>
|
|
#include <linux/socket.h>
|
|
|
|
#include "include/apparmor.h"
|
|
#include "include/audit.h"
|
|
#include "include/policy.h"
|
|
#include "include/policy_ns.h"
|
|
#include "include/secid.h"
|
|
|
|
const char *const audit_mode_names[] = {
|
|
"normal",
|
|
"quiet_denied",
|
|
"quiet",
|
|
"noquiet",
|
|
"all"
|
|
};
|
|
|
|
static const char *const aa_audit_type[] = {
|
|
"AUDIT",
|
|
"ALLOWED",
|
|
"DENIED",
|
|
"HINT",
|
|
"STATUS",
|
|
"ERROR",
|
|
"KILLED",
|
|
"AUTO"
|
|
};
|
|
|
|
static const char *const aa_class_names[] = {
|
|
"none",
|
|
"unknown",
|
|
"file",
|
|
"cap",
|
|
"net",
|
|
"rlimits",
|
|
"domain",
|
|
"mount",
|
|
"unknown",
|
|
"ptrace",
|
|
"signal",
|
|
"xmatch",
|
|
"unknown",
|
|
"unknown",
|
|
"net",
|
|
"unknown",
|
|
"label",
|
|
"posix_mqueue",
|
|
"io_uring",
|
|
"module",
|
|
"lsm",
|
|
"namespace",
|
|
"io_uring",
|
|
"unknown",
|
|
"unknown",
|
|
"unknown",
|
|
"unknown",
|
|
"unknown",
|
|
"unknown",
|
|
"unknown",
|
|
"unknown",
|
|
"X",
|
|
"dbus",
|
|
};
|
|
|
|
|
|
/*
|
|
* Currently AppArmor auditing is fed straight into the audit framework.
|
|
*
|
|
* TODO:
|
|
* netlink interface for complain mode
|
|
* user auditing, - send user auditing to netlink interface
|
|
* system control of whether user audit messages go to system log
|
|
*/
|
|
|
|
/**
|
|
* audit_pre() - core AppArmor function.
|
|
* @ab: audit buffer to fill (NOT NULL)
|
|
* @va: audit structure containing data to audit (NOT NULL)
|
|
*
|
|
* Record common AppArmor audit data from @va
|
|
*/
|
|
static void audit_pre(struct audit_buffer *ab, void *va)
|
|
{
|
|
struct apparmor_audit_data *ad = aad_of_va(va);
|
|
|
|
if (aa_g_audit_header) {
|
|
audit_log_format(ab, "apparmor=\"%s\"",
|
|
aa_audit_type[ad->type]);
|
|
}
|
|
|
|
if (ad->op)
|
|
audit_log_format(ab, " operation=\"%s\"", ad->op);
|
|
|
|
if (ad->class)
|
|
audit_log_format(ab, " class=\"%s\"",
|
|
ad->class <= AA_CLASS_LAST ?
|
|
aa_class_names[ad->class] :
|
|
"unknown");
|
|
|
|
if (ad->info) {
|
|
audit_log_format(ab, " info=\"%s\"", ad->info);
|
|
if (ad->error)
|
|
audit_log_format(ab, " error=%d", ad->error);
|
|
}
|
|
|
|
if (ad->subj_label) {
|
|
struct aa_label *label = ad->subj_label;
|
|
|
|
if (label_isprofile(label)) {
|
|
struct aa_profile *profile = labels_profile(label);
|
|
|
|
if (profile->ns != root_ns) {
|
|
audit_log_format(ab, " namespace=");
|
|
audit_log_untrustedstring(ab,
|
|
profile->ns->base.hname);
|
|
}
|
|
audit_log_format(ab, " profile=");
|
|
audit_log_untrustedstring(ab, profile->base.hname);
|
|
} else {
|
|
audit_log_format(ab, " label=");
|
|
aa_label_xaudit(ab, root_ns, label, FLAG_VIEW_SUBNS,
|
|
GFP_ATOMIC);
|
|
}
|
|
}
|
|
|
|
if (ad->name) {
|
|
audit_log_format(ab, " name=");
|
|
audit_log_untrustedstring(ab, ad->name);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* aa_audit_msg - Log a message to the audit subsystem
|
|
* @type: audit type for the message
|
|
* @ad: audit event structure (NOT NULL)
|
|
* @cb: optional callback fn for type specific fields (MAYBE NULL)
|
|
*/
|
|
void aa_audit_msg(int type, struct apparmor_audit_data *ad,
|
|
void (*cb) (struct audit_buffer *, void *))
|
|
{
|
|
ad->type = type;
|
|
common_lsm_audit(&ad->common, audit_pre, cb);
|
|
}
|
|
|
|
/**
|
|
* aa_audit - Log a profile based audit event to the audit subsystem
|
|
* @type: audit type for the message
|
|
* @profile: profile to check against (NOT NULL)
|
|
* @ad: audit event (NOT NULL)
|
|
* @cb: optional callback fn for type specific fields (MAYBE NULL)
|
|
*
|
|
* Handle default message switching based off of audit mode flags
|
|
*
|
|
* Returns: error on failure
|
|
*/
|
|
int aa_audit(int type, struct aa_profile *profile,
|
|
struct apparmor_audit_data *ad,
|
|
void (*cb) (struct audit_buffer *, void *))
|
|
{
|
|
AA_BUG(!profile);
|
|
|
|
if (type == AUDIT_APPARMOR_AUTO) {
|
|
if (likely(!ad->error)) {
|
|
if (AUDIT_MODE(profile) != AUDIT_ALL)
|
|
return 0;
|
|
type = AUDIT_APPARMOR_AUDIT;
|
|
} else if (COMPLAIN_MODE(profile))
|
|
type = AUDIT_APPARMOR_ALLOWED;
|
|
else
|
|
type = AUDIT_APPARMOR_DENIED;
|
|
}
|
|
if (AUDIT_MODE(profile) == AUDIT_QUIET ||
|
|
(type == AUDIT_APPARMOR_DENIED &&
|
|
AUDIT_MODE(profile) == AUDIT_QUIET_DENIED))
|
|
return ad->error;
|
|
|
|
if (KILL_MODE(profile) && type == AUDIT_APPARMOR_DENIED)
|
|
type = AUDIT_APPARMOR_KILL;
|
|
|
|
ad->subj_label = &profile->label;
|
|
|
|
aa_audit_msg(type, ad, cb);
|
|
|
|
if (ad->type == AUDIT_APPARMOR_KILL)
|
|
(void)send_sig_info(SIGKILL, NULL,
|
|
ad->common.type == LSM_AUDIT_DATA_TASK &&
|
|
ad->common.u.tsk ? ad->common.u.tsk : current);
|
|
|
|
if (ad->type == AUDIT_APPARMOR_ALLOWED)
|
|
return complain_error(ad->error);
|
|
|
|
return ad->error;
|
|
}
|
|
|
|
struct aa_audit_rule {
|
|
struct aa_label *label;
|
|
};
|
|
|
|
void aa_audit_rule_free(void *vrule)
|
|
{
|
|
struct aa_audit_rule *rule = vrule;
|
|
|
|
if (rule) {
|
|
if (!IS_ERR(rule->label))
|
|
aa_put_label(rule->label);
|
|
kfree(rule);
|
|
}
|
|
}
|
|
|
|
int aa_audit_rule_init(u32 field, u32 op, char *rulestr, void **vrule, gfp_t gfp)
|
|
{
|
|
struct aa_audit_rule *rule;
|
|
|
|
switch (field) {
|
|
case AUDIT_SUBJ_ROLE:
|
|
if (op != Audit_equal && op != Audit_not_equal)
|
|
return -EINVAL;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
|
|
rule = kzalloc(sizeof(struct aa_audit_rule), gfp);
|
|
|
|
if (!rule)
|
|
return -ENOMEM;
|
|
|
|
/* Currently rules are treated as coming from the root ns */
|
|
rule->label = aa_label_parse(&root_ns->unconfined->label, rulestr,
|
|
gfp, true, false);
|
|
if (IS_ERR(rule->label)) {
|
|
int err = PTR_ERR(rule->label);
|
|
aa_audit_rule_free(rule);
|
|
return err;
|
|
}
|
|
|
|
*vrule = rule;
|
|
return 0;
|
|
}
|
|
|
|
int aa_audit_rule_known(struct audit_krule *rule)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < rule->field_count; i++) {
|
|
struct audit_field *f = &rule->fields[i];
|
|
|
|
switch (f->type) {
|
|
case AUDIT_SUBJ_ROLE:
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int aa_audit_rule_match(u32 sid, u32 field, u32 op, void *vrule)
|
|
{
|
|
struct aa_audit_rule *rule = vrule;
|
|
struct aa_label *label;
|
|
int found = 0;
|
|
|
|
label = aa_secid_to_label(sid);
|
|
|
|
if (!label)
|
|
return -ENOENT;
|
|
|
|
if (aa_label_is_subset(label, rule->label))
|
|
found = 1;
|
|
|
|
switch (field) {
|
|
case AUDIT_SUBJ_ROLE:
|
|
switch (op) {
|
|
case Audit_equal:
|
|
return found;
|
|
case Audit_not_equal:
|
|
return !found;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|