Dmytro Linkin 7be8ef2cdb net: sched: use temporary variable for actions indexes ... Currently init call of all actions (except ipt) init their 'parm' structure as a direct pointer to nla data in skb. This leads to race condition when some of the filter actions were initialized successfully (and were assigned with idr action index that was written directly into nla data), but then were deleted and retried (due to following action module missing or classifier-initiated retry), in which case action init code tries to insert action to idr with index that was assigned on previous iteration. During retry the index can be reused by another action that was inserted concurrently, which causes unintended action sharing between filters. To fix described race condition, save action idr index to temporary stack-allocated variable instead on nla data. Fixes: 0190c1d452 ("net: sched: atomically check-allocate action") Signed-off-by: Dmytro Linkin <dmitrolin@mellanox.com> Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-08-05 10:59:14 -07:00
..
act_api.c	idr: fix overflow case for idr_for_each_entry_ul()	2019-07-01 19:15:46 -07:00
act_bpf.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_connmark.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_csum.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_ct.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_ctinfo.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_gact.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_ife.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_ipt.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_mark.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_mirred.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_mpls.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_nat.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_pedit.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_police.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_sample.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_simple.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_skbedit.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_skbmod.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_tunnel_key.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
act_vlan.c	net: sched: use temporary variable for actions indexes	2019-08-05 10:59:14 -07:00
cls_api.c	net: sched: verify that q!=NULL before setting q->flags	2019-07-21 11:49:53 -07:00
cls_basic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_bpf.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
cls_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flow.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flower.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
cls_fw.c	net: sched: remove NET_CLS_IND config option	2019-06-15 14:06:13 -07:00
cls_matchall.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
cls_route.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_tcindex.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
cls_u32.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
em_canid.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 11	2019-05-21 11:28:45 +02:00
em_cmp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_ipset.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
em_ipt.c	net: sched: em_ipt: add support for addrtype matching	2019-06-29 11:15:12 -07:00
em_meta.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_nbyte.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_text.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_u32.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ematch.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Kconfig	net/sched: Make NET_ACT_CT depends on NF_NAT	2019-07-17 12:02:43 -07:00
Makefile	net/sched: Introduce action ct	2019-07-09 12:11:59 -07:00
sch_api.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_atm.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_blackhole.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_cake.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_cbq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_cbs.c	net/sched: cbs: Fix error path of cbs_module_init	2019-06-23 11:32:48 -07:00
sch_choke.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_codel.c	net: sched: Fix a possible null-pointer dereference in dequeue_func()	2019-07-29 09:46:58 -07:00
sch_drr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_dsmark.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_etf.c	etf: Add skip_sock_check	2019-06-28 14:45:33 -07:00
sch_fifo.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_fq_codel.c	net_sched: unset TCQ_F_CAN_BYPASS when adding filters	2019-07-17 13:34:09 -07:00
sch_fq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_generic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_gred.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_hfsc.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_hhf.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_htb.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_ingress.c	net: flow_offload: rename TCF_BLOCK_BINDER_TYPE_* to FLOW_BLOCK_BINDER_TYPE_*	2019-07-09 14:38:50 -07:00
sch_mq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_mqprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_multiq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
sch_netem.c	net: netem: fix use after free and double free with packet corruption	2019-06-18 21:30:38 -04:00
sch_pie.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235	2019-06-19 17:09:07 +02:00
sch_plug.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_prio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_qfq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_red.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_sfb.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_sfq.c	net_sched: unset TCQ_F_CAN_BYPASS when adding filters	2019-07-17 13:34:09 -07:00
sch_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_taprio.c	fix: taprio: Change type of txtime-delay parameter to u32	2019-07-16 14:19:19 -07:00
sch_tbf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_teql.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00