mirror of
https://github.com/torvalds/linux.git
synced 2024-12-30 14:52:05 +00:00
7b6982ce4b
There's a bug in LLVM that it can generate unneeded relocation information. See [1] and [2]. Libbpf should check the target section of a relocation symbol. This patch adds a testcase which references a global variable (BPF doesn't support global variables). Before fixing libbpf, the new test case can be loaded into kernel, the global variable acts like the first map. It is incorrect. Result: # ~/perf test BPF 37: Test BPF filter : 37.1: Test basic BPF filtering : Ok 37.2: Test BPF prologue generation : Ok 37.3: Test BPF relocation checker : FAILED! # ~/perf test -v BPF ... libbpf: loading object '[bpf_relocation_test]' from buffer libbpf: section .strtab, size 126, link 0, flags 0, type=3 libbpf: section .text, size 0, link 0, flags 6, type=1 libbpf: section .data, size 0, link 0, flags 3, type=1 libbpf: section .bss, size 0, link 0, flags 3, type=8 libbpf: section func=sys_write, size 104, link 0, flags 6, type=1 libbpf: found program func=sys_write libbpf: section .relfunc=sys_write, size 16, link 10, flags 0, type=9 libbpf: section maps, size 16, link 0, flags 3, type=1 libbpf: maps in [bpf_relocation_test]: 16 bytes libbpf: section license, size 4, link 0, flags 3, type=1 libbpf: license of [bpf_relocation_test] is GPL libbpf: section version, size 4, link 0, flags 3, type=1 libbpf: kernel version of [bpf_relocation_test] is 40400 libbpf: section .symtab, size 144, link 1, flags 0, type=2 libbpf: map 0 is "my_table" libbpf: collecting relocating info for: 'func=sys_write' libbpf: relocation: insn_idx=7 Success unexpectedly: libbpf error when dealing with relocation test child finished with -1 ---- end ---- Test BPF filter subtest 2: FAILED! [1] https://llvm.org/bugs/show_bug.cgi?id=26243 [2] https://patchwork.ozlabs.org/patch/571385/ Signed-off-by: Wang Nan <wangnan0@huawei.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Brendan Gregg <brendan.d.gregg@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: He Kuang <hekuang@huawei.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Li Zefan <lizefan@huawei.com> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Will Deacon <will.deacon@arm.com> Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1453715801-7732-2-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
279 lines
5.7 KiB
C
279 lines
5.7 KiB
C
#include <stdio.h>
|
|
#include <sys/epoll.h>
|
|
#include <util/bpf-loader.h>
|
|
#include <util/evlist.h>
|
|
#include "tests.h"
|
|
#include "llvm.h"
|
|
#include "debug.h"
|
|
#define NR_ITERS 111
|
|
|
|
#ifdef HAVE_LIBBPF_SUPPORT
|
|
|
|
static int epoll_pwait_loop(void)
|
|
{
|
|
int i;
|
|
|
|
/* Should fail NR_ITERS times */
|
|
for (i = 0; i < NR_ITERS; i++)
|
|
epoll_pwait(-(i + 1), NULL, 0, 0, NULL);
|
|
return 0;
|
|
}
|
|
|
|
#ifdef HAVE_BPF_PROLOGUE
|
|
|
|
static int llseek_loop(void)
|
|
{
|
|
int fds[2], i;
|
|
|
|
fds[0] = open("/dev/null", O_RDONLY);
|
|
fds[1] = open("/dev/null", O_RDWR);
|
|
|
|
if (fds[0] < 0 || fds[1] < 0)
|
|
return -1;
|
|
|
|
for (i = 0; i < NR_ITERS; i++) {
|
|
lseek(fds[i % 2], i, (i / 2) % 2 ? SEEK_CUR : SEEK_SET);
|
|
lseek(fds[(i + 1) % 2], i, (i / 2) % 2 ? SEEK_CUR : SEEK_SET);
|
|
}
|
|
close(fds[0]);
|
|
close(fds[1]);
|
|
return 0;
|
|
}
|
|
|
|
#endif
|
|
|
|
static struct {
|
|
enum test_llvm__testcase prog_id;
|
|
const char *desc;
|
|
const char *name;
|
|
const char *msg_compile_fail;
|
|
const char *msg_load_fail;
|
|
int (*target_func)(void);
|
|
int expect_result;
|
|
} bpf_testcase_table[] = {
|
|
{
|
|
LLVM_TESTCASE_BASE,
|
|
"Test basic BPF filtering",
|
|
"[basic_bpf_test]",
|
|
"fix 'perf test LLVM' first",
|
|
"load bpf object failed",
|
|
&epoll_pwait_loop,
|
|
(NR_ITERS + 1) / 2,
|
|
},
|
|
#ifdef HAVE_BPF_PROLOGUE
|
|
{
|
|
LLVM_TESTCASE_BPF_PROLOGUE,
|
|
"Test BPF prologue generation",
|
|
"[bpf_prologue_test]",
|
|
"fix kbuild first",
|
|
"check your vmlinux setting?",
|
|
&llseek_loop,
|
|
(NR_ITERS + 1) / 4,
|
|
},
|
|
#endif
|
|
{
|
|
LLVM_TESTCASE_BPF_RELOCATION,
|
|
"Test BPF relocation checker",
|
|
"[bpf_relocation_test]",
|
|
"fix 'perf test LLVM' first",
|
|
"libbpf error when dealing with relocation",
|
|
NULL,
|
|
0,
|
|
},
|
|
};
|
|
|
|
static int do_test(struct bpf_object *obj, int (*func)(void),
|
|
int expect)
|
|
{
|
|
struct record_opts opts = {
|
|
.target = {
|
|
.uid = UINT_MAX,
|
|
.uses_mmap = true,
|
|
},
|
|
.freq = 0,
|
|
.mmap_pages = 256,
|
|
.default_interval = 1,
|
|
};
|
|
|
|
char pid[16];
|
|
char sbuf[STRERR_BUFSIZE];
|
|
struct perf_evlist *evlist;
|
|
int i, ret = TEST_FAIL, err = 0, count = 0;
|
|
|
|
struct parse_events_evlist parse_evlist;
|
|
struct parse_events_error parse_error;
|
|
|
|
bzero(&parse_error, sizeof(parse_error));
|
|
bzero(&parse_evlist, sizeof(parse_evlist));
|
|
parse_evlist.error = &parse_error;
|
|
INIT_LIST_HEAD(&parse_evlist.list);
|
|
|
|
err = parse_events_load_bpf_obj(&parse_evlist, &parse_evlist.list, obj);
|
|
if (err || list_empty(&parse_evlist.list)) {
|
|
pr_debug("Failed to add events selected by BPF\n");
|
|
return TEST_FAIL;
|
|
}
|
|
|
|
snprintf(pid, sizeof(pid), "%d", getpid());
|
|
pid[sizeof(pid) - 1] = '\0';
|
|
opts.target.tid = opts.target.pid = pid;
|
|
|
|
/* Instead of perf_evlist__new_default, don't add default events */
|
|
evlist = perf_evlist__new();
|
|
if (!evlist) {
|
|
pr_debug("No ehough memory to create evlist\n");
|
|
return TEST_FAIL;
|
|
}
|
|
|
|
err = perf_evlist__create_maps(evlist, &opts.target);
|
|
if (err < 0) {
|
|
pr_debug("Not enough memory to create thread/cpu maps\n");
|
|
goto out_delete_evlist;
|
|
}
|
|
|
|
perf_evlist__splice_list_tail(evlist, &parse_evlist.list);
|
|
evlist->nr_groups = parse_evlist.nr_groups;
|
|
|
|
perf_evlist__config(evlist, &opts);
|
|
|
|
err = perf_evlist__open(evlist);
|
|
if (err < 0) {
|
|
pr_debug("perf_evlist__open: %s\n",
|
|
strerror_r(errno, sbuf, sizeof(sbuf)));
|
|
goto out_delete_evlist;
|
|
}
|
|
|
|
err = perf_evlist__mmap(evlist, opts.mmap_pages, false);
|
|
if (err < 0) {
|
|
pr_debug("perf_evlist__mmap: %s\n",
|
|
strerror_r(errno, sbuf, sizeof(sbuf)));
|
|
goto out_delete_evlist;
|
|
}
|
|
|
|
perf_evlist__enable(evlist);
|
|
(*func)();
|
|
perf_evlist__disable(evlist);
|
|
|
|
for (i = 0; i < evlist->nr_mmaps; i++) {
|
|
union perf_event *event;
|
|
|
|
while ((event = perf_evlist__mmap_read(evlist, i)) != NULL) {
|
|
const u32 type = event->header.type;
|
|
|
|
if (type == PERF_RECORD_SAMPLE)
|
|
count ++;
|
|
}
|
|
}
|
|
|
|
if (count != expect) {
|
|
pr_debug("BPF filter result incorrect\n");
|
|
goto out_delete_evlist;
|
|
}
|
|
|
|
ret = TEST_OK;
|
|
|
|
out_delete_evlist:
|
|
perf_evlist__delete(evlist);
|
|
return ret;
|
|
}
|
|
|
|
static struct bpf_object *
|
|
prepare_bpf(void *obj_buf, size_t obj_buf_sz, const char *name)
|
|
{
|
|
struct bpf_object *obj;
|
|
|
|
obj = bpf__prepare_load_buffer(obj_buf, obj_buf_sz, name);
|
|
if (IS_ERR(obj)) {
|
|
pr_debug("Compile BPF program failed.\n");
|
|
return NULL;
|
|
}
|
|
return obj;
|
|
}
|
|
|
|
static int __test__bpf(int idx)
|
|
{
|
|
int ret;
|
|
void *obj_buf;
|
|
size_t obj_buf_sz;
|
|
struct bpf_object *obj;
|
|
|
|
ret = test_llvm__fetch_bpf_obj(&obj_buf, &obj_buf_sz,
|
|
bpf_testcase_table[idx].prog_id,
|
|
true, NULL);
|
|
if (ret != TEST_OK || !obj_buf || !obj_buf_sz) {
|
|
pr_debug("Unable to get BPF object, %s\n",
|
|
bpf_testcase_table[idx].msg_compile_fail);
|
|
if (idx == 0)
|
|
return TEST_SKIP;
|
|
else
|
|
return TEST_FAIL;
|
|
}
|
|
|
|
obj = prepare_bpf(obj_buf, obj_buf_sz,
|
|
bpf_testcase_table[idx].name);
|
|
if ((!!bpf_testcase_table[idx].target_func) != (!!obj)) {
|
|
if (!obj)
|
|
pr_debug("Fail to load BPF object: %s\n",
|
|
bpf_testcase_table[idx].msg_load_fail);
|
|
else
|
|
pr_debug("Success unexpectedly: %s\n",
|
|
bpf_testcase_table[idx].msg_load_fail);
|
|
ret = TEST_FAIL;
|
|
goto out;
|
|
}
|
|
|
|
if (obj)
|
|
ret = do_test(obj,
|
|
bpf_testcase_table[idx].target_func,
|
|
bpf_testcase_table[idx].expect_result);
|
|
out:
|
|
bpf__clear();
|
|
return ret;
|
|
}
|
|
|
|
int test__bpf_subtest_get_nr(void)
|
|
{
|
|
return (int)ARRAY_SIZE(bpf_testcase_table);
|
|
}
|
|
|
|
const char *test__bpf_subtest_get_desc(int i)
|
|
{
|
|
if (i < 0 || i >= (int)ARRAY_SIZE(bpf_testcase_table))
|
|
return NULL;
|
|
return bpf_testcase_table[i].desc;
|
|
}
|
|
|
|
int test__bpf(int i)
|
|
{
|
|
int err;
|
|
|
|
if (i < 0 || i >= (int)ARRAY_SIZE(bpf_testcase_table))
|
|
return TEST_FAIL;
|
|
|
|
if (geteuid() != 0) {
|
|
pr_debug("Only root can run BPF test\n");
|
|
return TEST_SKIP;
|
|
}
|
|
|
|
err = __test__bpf(i);
|
|
return err;
|
|
}
|
|
|
|
#else
|
|
int test__bpf_subtest_get_nr(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
const char *test__bpf_subtest_get_desc(int i __maybe_unused)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
int test__bpf(int i __maybe_unused)
|
|
{
|
|
pr_debug("Skip BPF test because BPF support is not compiled\n");
|
|
return TEST_SKIP;
|
|
}
|
|
#endif
|