Takashi Iwai b1757fa30e ALSA: usb-audio: Fix potential memory leaks at error path for UMP open ... The allocation and initialization errors at alloc_midi_urbs() that is called at MIDI 2.0 / UMP device are supposed to be handled at the caller side by invoking free_midi_urbs(). However, free_midi_urbs() loops only for ep->num_urbs entries, and since ep->num_entries wasn't updated yet at the allocation / init error in alloc_midi_urbs(), this entry won't be released. The intention of free_midi_urbs() is to release the whole elements, so change the loop size to NUM_URBS to scan over all elements for fixing the missed releases. Also, the call of free_midi_urbs() is missing at snd_usb_midi_v2_open(). Although it'll be released later at reopen/close or disconnection, it's better to release immediately at the error path. Fixes: ff49d1df79 ("ALSA: usb-audio: USB MIDI 2.0 UMP support") Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Closes: https://lore.kernel.org/r/fc275ed315b9157952dcf2744ee7bdb78defdb5f.1693746347.git.christophe.jaillet@wanadoo.fr Link: https://lore.kernel.org/r/20230905054511.20502-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>		2023-09-05 10:10:48 +02:00
..
6fire	ALSA: usb/6fire: fix repeated words in comments	2022-07-25 08:28:17 +02:00
bcd2000	ALSA: bcd2000: refactor deprecated strncpy	2023-07-29 13:53:56 +02:00
caiaq	ALSA: caiaq: input: Add error handling for unsupported input methods in snd_usb_caiaq_input_init	2023-05-04 09:50:11 +02:00
hiface	ALSA: hiface: fix repeated words in comments	2022-07-25 08:28:37 +02:00
line6	ALSA: line6: fix stack overflow in line6_midi_transmit	2022-12-26 09:07:49 +01:00
misc	ALSA: ua101: fix division by zero at probe	2021-10-27 08:23:30 +02:00
usx2y	mm: replace vma->vm_flags direct modifications with modifier calls	2023-02-09 16:51:39 -08:00
card.c	ALSA: usb-audio: USB MIDI 2.0 UMP support	2023-05-23 12:11:02 +02:00
card.h	ALSA: usb-audio: Add new quirk FIXED_RATE for JBL Quantum810 Wireless	2022-12-22 09:13:54 +01:00
clock.c	ALSA: usb-audio: Optimize TEAC clock quirk	2022-05-31 15:09:05 +02:00
clock.h	ALSA: usb-audio: Constify audioformat pointer references	2020-11-23 15:15:36 +01:00
endpoint.c	ALSA: usb-audio: Don't try to submit URBs after disconnection	2023-08-28 15:03:35 +02:00
endpoint.h	ALSA: usb-audio: Remove unused function declaration	2023-08-01 16:56:57 +02:00
format.c	ALSA: usb-audio: Add a sample rate workaround for Line6 Pod Go	2023-05-12 10:19:55 +02:00
format.h
helper.c	ALSA: usb-audio: remove Wireless USB dead code	2023-03-14 17:00:57 +01:00
helper.h	ALSA: usb-audio: Add snd_usb_get_host_interface() helper	2020-11-23 15:13:47 +01:00
implicit.c	ALSA: usb-audio: Always initialize fixed_rate in snd_usb_find_implicit_fb_sync_format()	2023-01-09 16:05:21 +01:00
implicit.h	ALSA: usb-audio: Add new quirk FIXED_RATE for JBL Quantum810 Wireless	2022-12-22 09:13:54 +01:00
Kconfig	ALSA: usb-audio: USB MIDI 2.0 UMP support	2023-05-23 12:11:02 +02:00
Makefile	ALSA: usb-audio: USB MIDI 2.0 UMP support	2023-05-23 12:11:02 +02:00
media.c	ALSA: pcm: Don't embed device	2023-08-17 09:23:45 +02:00
media.h
midi2.c	ALSA: usb-audio: Fix potential memory leaks at error path for UMP open	2023-09-05 10:10:48 +02:00
midi2.h	ALSA: usb-audio: USB MIDI 2.0 UMP support	2023-05-23 12:11:02 +02:00
midi.c	ALSA: usb-audio: Manage number of rawmidis globally	2023-05-23 12:11:00 +02:00
midi.h	ALSA: usb-audio: Manage number of rawmidis globally	2023-05-23 12:11:00 +02:00
mixer_maps.c	ALSA: usb-audio: Add quirk for Microsoft Modern Wireless Headset	2023-07-25 14:21:11 +02:00
mixer_quirks.c	ALSA: scarlett2: Add Focusrite Clarett+ 8Pre support	2022-08-09 09:24:38 +02:00
mixer_quirks.h	ALSA: usb-audio: Drop CONFIG_PM ifdefs	2021-12-06 10:19:40 +01:00
mixer_s1810c.c	ALSA: usb-audio: remove redundant assignment to variable c	2022-02-08 08:21:32 +01:00
mixer_s1810c.h	ALSA: usb-audio: Add support for Presonus Studio 1810c	2020-02-15 09:46:16 +01:00
mixer_scarlett_gen2.c	ALSA: scarlett2: Add Focusrite Clarett+ 8Pre support	2022-08-09 09:24:38 +02:00
mixer_scarlett_gen2.h	ALSA: usb-audio: scarlett2: Improve driver startup messages	2021-05-21 16:22:52 +02:00
mixer_scarlett.c	ALSA: usb-audio: fix spelling mistakes	2021-07-05 19:33:54 +02:00
mixer_scarlett.h
mixer_us16x08.c	ALSA: usb-audio: US16x08: Move overflow check before array access	2022-06-13 07:40:08 +02:00
mixer_us16x08.h	ALSA: usb: Constify snd_kcontrol_new items	2020-01-03 09:24:34 +01:00
mixer.c	ALSA: usb-audio: Use snd_ctl_rename() to rename a control	2022-10-21 08:17:08 +02:00
mixer.h	ALSA: usb-audio: Drop CONFIG_PM ifdefs	2021-12-06 10:19:40 +01:00
pcm.c	ALSA: usb-audio: Fix broken resume due to UAC3 power state	2023-06-16 09:28:08 +02:00
pcm.h	ALSA: usb-audio: Add new quirk FIXED_RATE for JBL Quantum810 Wireless	2022-12-22 09:13:54 +01:00
power.c
power.h	ALSA: usb-audio: Drop CONFIG_PM ifdefs	2021-12-06 10:19:40 +01:00
proc.c	ALSA: usb-audio: Show sync endpoint information in proc outputs	2020-11-23 15:16:45 +01:00
proc.h
quirks-table.h	ALSA: usb-audio: Add support for Mythware XA001AU capture and playback interfaces.	2023-08-04 12:47:30 +02:00
quirks.c	ALSA: usb-audio: Update for native DSD support quirks	2023-07-26 20:04:34 +02:00
quirks.h	ALSA: usb-audio: Register card at the last interface	2022-09-06 11:04:56 +02:00
stream.c	ALSA: usb-audio: Fix init call orders for UAC1	2023-08-21 16:20:25 +02:00
stream.h
usbaudio.h	ALSA: usb-audio: USB MIDI 2.0 UMP support	2023-05-23 12:11:02 +02:00
validate.c	ALSA: usb-audio: Fix endianess in descriptor validation	2020-02-01 09:06:11 +01:00