Vladimir Oltean 6565243c06 net: mscc: ocelot: add locking for the port TX timestamp ID ... The ocelot_port->ts_id is used to: (a) populate skb->cb[0] for matching the TX timestamp in the PTP IRQ with an skb. (b) populate the REW_OP from the injection header of the ongoing skb. Only then is ocelot_port->ts_id incremented. This is a problem because, at least theoretically, another timestampable skb might use the same ocelot_port->ts_id before that is incremented. Normally all transmit calls are serialized by the netdev transmit spinlock, but in this case, ocelot_port_add_txtstamp_skb() is also called by DSA, which has started declaring the NETIF_F_LLTX feature since commit 2b86cb8299 ("net: dsa: declare lockless TX feature for slave ports"). So the logic of using and incrementing the timestamp id should be atomic per port. The solution is to use the global ocelot_port->ts_id only while protected by the associated ocelot_port->ts_id_lock. That's where we populate skb->cb[0]. Note that for ocelot, ocelot_port_add_txtstamp_skb is called for the actual skb, but for felix, it is called for the skb's clone. That is something which will also be changed in the future. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Tested-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-09-18 13:52:33 -07:00
..
arc	include/: replace HTTP links with HTTPS ones	2020-08-12 10:57:59 -07:00
at91	ARM: at91: add atmel tcb capabilities	2020-07-11 18:57:03 +02:00
bcm2835	firmware: raspberrypi: Introduce vl805 init routine	2020-05-13 10:53:23 +01:00
brcmstb	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
fsl	soc: fsl: qe: Replace one-element array and use struct_size() helper	2020-05-22 16:23:02 -05:00
imx	ARM: imx: move cpu definitions into a header	2020-05-20 23:03:47 +08:00
mediatek	iommu/mediatek: Clean up struct mtk_smi_iommu	2019-08-30 15:57:27 +02:00
mscc	net: mscc: ocelot: add locking for the port TX timestamp ID	2020-09-18 13:52:33 -07:00
nps	soc: Support for NPS HW scheduling	2016-11-30 11:54:25 -08:00
qcom	It looks like a smaller batch of clk updates this time around. In the core	2020-08-07 13:35:51 -07:00
rockchip	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288	2019-06-05 17:36:37 +02:00
sa1100	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sifive	riscv: move sifive_l2_cache.h to include/soc	2020-01-12 10:12:44 -08:00
tegra	soc/tegra: Changes for v5.9-rc1	2020-07-17 21:17:20 +02:00