Vladimir Oltean 6565243c06 net: mscc: ocelot: add locking for the port TX timestamp ID ... The ocelot_port->ts_id is used to: (a) populate skb->cb[0] for matching the TX timestamp in the PTP IRQ with an skb. (b) populate the REW_OP from the injection header of the ongoing skb. Only then is ocelot_port->ts_id incremented. This is a problem because, at least theoretically, another timestampable skb might use the same ocelot_port->ts_id before that is incremented. Normally all transmit calls are serialized by the netdev transmit spinlock, but in this case, ocelot_port_add_txtstamp_skb() is also called by DSA, which has started declaring the NETIF_F_LLTX feature since commit 2b86cb8299 ("net: dsa: declare lockless TX feature for slave ports"). So the logic of using and incrementing the timestamp id should be atomic per port. The solution is to use the global ocelot_port->ts_id only while protected by the associated ocelot_port->ts_id_lock. That's where we populate skb->cb[0]. Note that for ocelot, ocelot_port_add_txtstamp_skb is called for the actual skb, but for felix, it is called for the skb's clone. That is something which will also be changed in the future. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Tested-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-09-18 13:52:33 -07:00
..
acpi	ACPI updates for 5.9-rc1	2020-08-03 20:37:22 -07:00
asm-generic	iomap: constify ioreadX() iomem argument (as in generic implementation)	2020-08-14 19:56:57 -07:00
clocksource	include/: replace HTTP links with HTTPS ones	2020-08-12 10:57:59 -07:00
crypto	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
drm	drm/i915: Fix sha_text population code	2020-09-02 10:48:11 +03:00
dt-bindings	Here's some more updates that missed the last pull request because I	2020-08-12 12:19:49 -07:00
keys	It's been a busy cycle for documentation - hopefully the busiest for a	2020-08-04 22:47:54 -07:00
kunit
kvm
linux	net: Fix broken NETIF_F_CSUM_MASK spell in netdev_features.h	2020-09-10 13:30:22 -07:00
math-emu	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
media	media updates for v5.9-rc1	2020-08-07 13:00:53 -07:00
memory
misc
net	net: sched: only keep the available bits when setting vxlan md->gbp	2020-09-14 16:49:39 -07:00
pcmcia
ras
rdma	RDMA 5.9 merge window pull request	2020-08-06 16:43:36 -07:00
scsi
soc	net: mscc: ocelot: add locking for the port TX timestamp ID	2020-09-18 13:52:33 -07:00
sound	ALSA: hda: Add dma stop delay variable	2020-08-05 12:27:47 +02:00
target	scsi: target: Make iscsit_register_transport() return void	2020-08-04 20:56:56 -04:00
trace	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-09-03 18:50:48 -07:00
uapi	ethtool: add and use message type for tunnel info reply	2020-09-17 16:43:20 -07:00
vdso	lib/vdso: Allow to add architecture-specific vdso data	2020-08-06 10:57:30 +02:00
video
xen	xen: branch for v5.9-rc3	2020-08-29 12:44:30 -07:00