Jakub Kicinski 8c79b35693 tools: bpftool: fix crash with un-owned prog arrays ... Prog arrays don't have 'owner_prog_type' and 'owner_jited' fields in their fdinfo when they are created. Those fields are set and reported when first program is checked for compatibility by bpf_prog_array_compatible(). This means that bpftool cannot expect the fields to always be there. Currently trying to show maps on a system with an un-owned prog array leads to a crash: $ bpftool map show 389: prog_array name tail_call_map flags 0x0 Error: key 'owner_prog_type' not found in fdinfo Error: key 'owner_jited' not found in fdinfo key 4B value 4B max_entries 4 memlock 4096B Segmentation fault (core dumped) We pass a NULL pointer to atoi(). Remove the assumption that fdinfo keys are always present. Add missing validations and remove the p_err() calls which may lead to broken JSON output as caller will not propagate the failure. Fixes: 99a44bef58 ("tools: bpftool: add owner_prog_type and owner_jited to bpftool output") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> Acked-by: Song Liu <songliubraving@fb.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>		2019-01-28 23:59:46 +01:00
..
bpftool	tools: bpftool: fix crash with un-owned prog arrays	2019-01-28 23:59:46 +01:00
.gitignore	tools/bpftool: ignore build products	2018-07-26 02:50:26 +02:00
bpf_asm.c
bpf_dbg.c	bpf: fix uninitialized variable in bpf tools	2018-04-26 22:23:02 +02:00
bpf_exp.l	bpf: fix cbpf parser bug for octal numbers	2018-06-03 07:46:55 -07:00
bpf_exp.y
bpf_jit_disasm.c	tools/bpf_jit_disasm: silence a static checker warning	2018-01-18 22:15:37 +01:00
Makefile	bpf: fix for lex/yacc build error with gcc-5	2018-04-25 23:27:46 +02:00
Makefile.helpers	tools: bpf: build and install man page for eBPF helpers from bpftool/	2018-07-12 18:55:53 +02:00