mirror of
https://github.com/torvalds/linux.git
synced 2024-11-15 08:31:55 +00:00
e7d2860b69
Makes use of skip_spaces() defined in lib/string.c for removing leading spaces from strings all over the tree. It decreases lib.a code size by 47 bytes and reuses the function tree-wide: text data bss dec hex filename 64688 584 592 65864 10148 (TOTALS-BEFORE) 64641 584 592 65817 10119 (TOTALS-AFTER) Also, while at it, if we see (*str && isspace(*str)), we can be sure to remove the first condition (*str) as the second one (isspace(*str)) also evaluates to 0 whenever *str == 0, making it redundant. In other words, "a char equals zero is never a space". Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below, and found occurrences of this pattern on 3 more files: drivers/leds/led-class.c drivers/leds/ledtrig-timer.c drivers/video/output.c @@ expression str; @@ ( // ignore skip_spaces cases while (*str && isspace(*str)) { \(str++;\|++str;\) } | - *str && isspace(*str) ) Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com> Cc: Julia Lawall <julia@diku.dk> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Jeff Dike <jdike@addtoit.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Neil Brown <neilb@suse.de> Cc: Kyle McMartin <kyle@mcmartin.ca> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: David Howells <dhowells@redhat.com> Cc: <linux-ext4@vger.kernel.org> Cc: Samuel Ortiz <samuel@sortiz.org> Cc: Patrick McHardy <kaber@trash.net> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| asp.c | ||
| ccio-dma.c | ||
| ccio-rm-dma.c | ||
| dino.c | ||
| eisa_eeprom.c | ||
| eisa_enumerator.c | ||
| eisa.c | ||
| gsc.c | ||
| gsc.h | ||
| hppb.c | ||
| iommu-helpers.h | ||
| iosapic_private.h | ||
| iosapic.c | ||
| Kconfig | ||
| lasi.c | ||
| lba_pci.c | ||
| led.c | ||
| Makefile | ||
| pdc_stable.c | ||
| power.c | ||
| README.dino | ||
| sba_iommu.c | ||
| superio.c | ||
| wax.c | ||
/* ** HP VISUALIZE Workstation PCI Bus Defect ** ** "HP has discovered a potential system defect that can affect ** the behavior of five models of HP VISUALIZE workstations when ** equipped with third-party or customer-installed PCI I/O expansion ** cards. The defect is limited to the HP C180, C160, C160L, B160L, ** and B132L VISUALIZE workstations, and will only be encountered ** when data is transmitted through PCI I/O expansion cards on the ** PCI bus. HP-supplied graphics cards that utilize the PCI bus are ** not affected." ** ** REVISIT: "go/pci_defect" link below is stale. ** HP Internal can use <http://hpfcdma.fc.hp.com:80/Dino/> ** ** Product First Good Serial Number ** C200/C240 (US) US67350000 **B132L+/B180 (US) US67390000 ** C200 (Europe) 3713G01000 ** B180L (Europe) 3720G01000 ** ** Note that many boards were fixed/replaced under a free replacement ** program. Assume a machine is only "suspect" until proven otherwise. ** ** "The pci_check program will also be available as application ** patch PHSS_12295" */