Filipe Manana 4f69cb987e Btrfs: fix crash caused by block group removal ... If we remove a block group (because it became empty), we might have left a caching_ctl structure in fs_info->caching_block_groups that points to the block group and is accessed at transaction commit time. This results in accessing an invalid or incorrect block group. This issue became visible after Josef's patch "Btrfs: remove empty block groups automatically". So if the block group is removed make sure we don't leave a dangling caching_ctl in caching_block_groups. Sample crash trace: [58380.439449] BUG: unable to handle kernel paging request at ffff8801446eaeb8 [58380.439707] IP: [<ffffffffa03f6d05>] block_group_cache_done.isra.21+0xc/0x1c [btrfs] [58380.440879] PGD 1acb067 PUD 23f5ff067 PMD 23f5db067 PTE 80000001446ea060 [58380.441220] Oops: 0000 [#1] SMP DEBUG_PAGEALLOC [58380.441486] Modules linked in: btrfs crc32c_generic xor raid6_pq nfsd auth_rpcgss oid_registry nfs_acl nfs lockd fscache sunrpc loop psmouse processor i2c_piix4 parport_pc parport pcspkr serio_raw evdev i2ccore thermal_sys microcode button ext4 crc16 jbd2 mbcache sr_mod cdrom ata_generic sg sd_mod crc_t10dif crct10dif_generic crct10dif_common virtio_scsi floppy ata_piix e1000 libata virtio_pci scsi_mod virtio_ring virtio [last unloaded: btrfs] [58380.443238] CPU: 3 PID: 25728 Comm: btrfs-transacti Tainted: G W 3.17.0-rc5-btrfs-next-1+ #1 [58380.443238] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.7.5-0-ge51488c-20140602_164612-nilsson.home.kraxel.org 04/01/2014 [58380.443238] task: ffff88013ac82090 ti: ffff88013896c000 task.ti: ffff88013896c000 [58380.443238] RIP: 0010:[<ffffffffa03f6d05>] [<ffffffffa03f6d05>] block_group_cache_done.isra.21+0xc/0x1c [btrfs] [58380.443238] RSP: 0018:ffff88013896fdd8 EFLAGS: 00010283 [58380.443238] RAX: ffff880222cae850 RBX: ffff880119ba74c0 RCX: 0000000000000000 [58380.443238] RDX: 0000000000000000 RSI: ffff880185e16800 RDI: ffff8801446eaeb8 [58380.443238] RBP: ffff88013896fdd8 R08: ffff8801a9ca9fa8 R09: ffff88013896fc60 [58380.443238] R10: ffff88013896fd28 R11: 0000000000000000 R12: ffff880222cae000 [58380.443238] R13: ffff880222cae850 R14: ffff880222cae6b0 R15: ffff8801446eae00 [58380.443238] FS: 0000000000000000(0000) GS:ffff88023ed80000(0000) knlGS:0000000000000000 [58380.443238] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [58380.443238] CR2: ffff8801446eaeb8 CR3: 0000000001811000 CR4: 00000000000006e0 [58380.443238] Stack: [58380.443238] ffff88013896fe18 ffffffffa03fe2d5 ffff880222cae850 ffff880185e16800 [58380.443238] ffff88000dc41c20 0000000000000000 ffff8801a9ca9f00 0000000000000000 [58380.443238] ffff88013896fe80 ffffffffa040fbcf ffff88018b0dcdb0 ffff88013ac82090 [58380.443238] Call Trace: [58380.443238] [<ffffffffa03fe2d5>] btrfs_prepare_extent_commit+0x5a/0xd7 [btrfs] [58380.443238] [<ffffffffa040fbcf>] btrfs_commit_transaction+0x45c/0x882 [btrfs] [58380.443238] [<ffffffffa040c058>] transaction_kthread+0xf2/0x1a4 [btrfs] [58380.443238] [<ffffffffa040bf66>] ? btrfs_cleanup_transaction+0x3d8/0x3d8 [btrfs] [58380.443238] [<ffffffff8105966b>] kthread+0xb7/0xbf [58380.443238] [<ffffffff810595b4>] ? __kthread_parkme+0x67/0x67 [58380.443238] [<ffffffff813ebeac>] ret_from_fork+0x7c/0xb0 [58380.443238] [<ffffffff810595b4>] ? __kthread_parkme+0x67/0x67 Signed-off-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Chris Mason <clm@fb.com>		2014-12-02 18:19:17 -08:00
..
tests	Btrfs: remove empty block groups automatically	2014-09-22 17:13:21 -07:00
acl.c	btrfs: remove useless ACL check	2014-06-09 17:20:42 -07:00
async-thread.c	btrfs: remove unlikely from NULL checks	2014-10-02 16:06:19 +02:00
async-thread.h	Btrfs: implement repair function when direct read fails	2014-09-17 13:39:01 -07:00
backref.c	btrfs: remove parameter blocksize from read_tree_block	2014-10-02 17:14:50 +02:00
backref.h	Btrfs: make fiemap not blow when you have lots of snapshots	2014-09-17 13:38:24 -07:00
btrfs_inode.h	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2014-10-11 08:03:52 -04:00
check-integrity.c	Btrfs: include vmalloc.h in check-integrity.c	2014-11-25 06:01:11 -08:00
check-integrity.h	block: submit_bio_wait() conversions	2013-11-24 16:33:41 -07:00
compression.c	Btrfs: don't ignore compressed bio write errors	2014-11-20 17:14:26 -08:00
compression.h	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
ctree.c	Btrfs: make xattr replace operations atomic	2014-11-20 17:20:07 -08:00
ctree.h	Btrfs: fix crash caused by block group removal	2014-12-02 18:19:17 -08:00
delayed-inode.c	btrfs: kill the key type accessor helpers	2014-09-17 13:37:12 -07:00
delayed-inode.h	Btrfs: introduce the delayed inode ref deletion for the single link inode	2014-01-28 13:20:09 -08:00
delayed-ref.c	Btrfs: rework qgroup accounting	2014-06-09 17:20:48 -07:00
delayed-ref.h	Btrfs: rework qgroup accounting	2014-06-09 17:20:48 -07:00
dev-replace.c	btrfs: Fix a lockdep warning when running xfstest.	2014-11-25 05:55:38 -08:00
dev-replace.h
dir-item.c	Btrfs: make xattr replace operations atomic	2014-11-20 17:20:07 -08:00
disk-io.c	Merge branch 'dev/pending-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus	2014-11-25 05:45:30 -08:00
disk-io.h	Merge branch 'cleanup/blocksize-diet-part1' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus	2014-10-04 09:57:14 -07:00
export.c	btrfs: kill the key type accessor helpers	2014-09-17 13:37:12 -07:00
export.h
extent_io.c	Btrfs: avoid premature -ENOMEM in clear_extent_bit()	2014-11-20 17:20:06 -08:00
extent_io.h	Btrfs: set page and mapping error on compressed write failure	2014-11-20 17:14:25 -08:00
extent_map.c	Btrfs: do not move em to modified list when unpinning	2014-11-21 11:59:54 -08:00
extent_map.h	Btrfs: fix NULL pointer crash when running balance and scrub concurrently	2014-06-19 14:20:55 -07:00
extent-tree.c	Btrfs: fix crash caused by block group removal	2014-12-02 18:19:17 -08:00
file-item.c	Btrfs: fix kfree on list_head in btrfs_lookup_csums_range error cleanup	2014-11-04 06:59:04 -08:00
file.c	Btrfs: fix snapshot inconsistency after a file write followed by truncate	2014-11-25 07:41:23 -08:00
free-space-cache.c	Btrfs: improve free space cache management and space allocation	2014-09-17 13:38:13 -07:00
free-space-cache.h	Btrfs: remove path arg from btrfs_truncate_free_space_cache	2013-11-11 21:51:33 -05:00
hash.c	btrfs: LLVMLinux: Remove VLAIS	2014-10-14 10:51:22 +02:00
hash.h	Btrfs: fix btrfs boot when compiled as built-in	2014-01-28 13:20:31 -08:00
inode-item.c	btrfs: kill the key type accessor helpers	2014-09-17 13:37:12 -07:00
inode-map.c	btrfs: switch inode_cache option handling to pending changes	2014-11-12 16:53:13 +01:00
inode-map.h
inode.c	Btrfs: fix snapshot inconsistency after a file write followed by truncate	2014-11-25 07:41:23 -08:00
ioctl.c	Btrfs: fix snapshot inconsistency after a file write followed by truncate	2014-11-25 07:41:23 -08:00
Kconfig	Btrfs: fix btrfs boot when compiled as built-in	2014-01-28 13:20:31 -08:00
locking.c	Btrfs: fix deadlocks with trylock on tree nodes	2014-06-19 14:19:55 -07:00
locking.h	Btrfs: remove btrfs_try_spin_lock	2013-03-14 14:57:10 -04:00
lzo.c	btrfs: use DIV_ROUND_UP instead of open-coded variants	2014-09-17 13:37:17 -07:00
Makefile	Btrfs: add sanity tests for new qgroup accounting code	2014-06-09 17:20:49 -07:00
math.h
ordered-data.c	Btrfs: collect only the necessary ordered extents on ranged fsync	2014-11-21 11:59:56 -08:00
ordered-data.h	Btrfs: collect only the necessary ordered extents on ranged fsync	2014-11-21 11:59:56 -08:00
orphan.c	btrfs: kill the key type accessor helpers	2014-09-17 13:37:12 -07:00
print-tree.c	btrfs: remove parameter blocksize from read_tree_block	2014-10-02 17:14:50 +02:00
print-tree.h	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
props.c	Btrfs: add support for inode properties	2014-01-28 13:20:24 -08:00
props.h	Btrfs: add support for inode properties	2014-01-28 13:20:24 -08:00
qgroup.c	btrfs: move checks for DUMMY_ROOT into a helper	2014-10-02 17:30:33 +02:00
qgroup.h	btrfs: qgroup: account shared subtrees during snapshot delete	2014-08-15 07:43:14 -07:00
raid56.c	btrfs: use DIV_ROUND_UP instead of open-coded variants	2014-09-17 13:37:17 -07:00
raid56.h	Btrfs: RAID5 and RAID6	2013-02-01 14:24:23 -05:00
rcu-string.h
reada.c	btrfs: use nodesize everywhere, kill leafsize	2014-09-17 13:37:14 -07:00
relocation.c	Merge branch 'cleanup/blocksize-diet-part1' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus	2014-10-04 09:57:14 -07:00
root-tree.c	Btrfs: use bitfield instead of integer data type for the some variants in btrfs_root	2014-06-09 17:20:40 -07:00
scrub.c	btrfs: fix dead lock while running replace and defrag concurrently	2014-11-20 17:20:08 -08:00
send.c	Btrfs: ensure send always works on roots without orphans	2014-11-25 07:41:23 -08:00
send.h	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
struct-funcs.c
super.c	Merge branch 'dev/pending-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus	2014-11-25 05:45:30 -08:00
sysfs.c	btrfs: move commit out of sysfs when changing label	2014-11-12 16:53:15 +01:00
sysfs.h	btrfs: code optimize: BTRFS_ATTR_RW could set the mode	2014-09-17 13:37:59 -07:00
transaction.c	Merge branch 'dev/pending-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus	2014-11-25 05:45:30 -08:00
transaction.h	Merge branch 'dev/pending-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus	2014-11-25 05:45:30 -08:00
tree-defrag.c	Btrfs: use bitfield instead of integer data type for the some variants in btrfs_root	2014-06-09 17:20:40 -07:00
tree-log.c	Btrfs: ensure ordered extent errors aren't missed on fsync	2014-11-21 11:59:57 -08:00
tree-log.h	Btrfs: fix data corruption after fast fsync and writeback error	2014-09-19 06:57:51 -07:00
ulist.c	Btrfs: do not export ulist functions	2014-01-29 07:06:27 -08:00
ulist.h	Btrfs: Fix memory corruption by ulist_add_merge() on 32bit arch	2014-08-15 07:43:19 -07:00
uuid-tree.c	Btrfs: make btrfs_search_forward return with nodes unlocked	2014-09-17 13:38:02 -07:00
volumes.c	btrfs: Fix a lockdep warning when running xfstest.	2014-11-25 05:55:38 -08:00
volumes.h	btrfs: Fix a lockdep warning when running xfstest.	2014-11-25 05:55:38 -08:00
xattr.c	Btrfs: make xattr replace operations atomic	2014-11-20 17:20:07 -08:00
xattr.h	btrfs: use generic posix ACL infrastructure	2014-01-25 23:58:18 -05:00
zlib.c	btrfs compression: merge inflate and deflate z_streams	2014-09-17 13:37:33 -07:00