Filipe Manana 4f69cb987e Btrfs: fix crash caused by block group removal ... If we remove a block group (because it became empty), we might have left a caching_ctl structure in fs_info->caching_block_groups that points to the block group and is accessed at transaction commit time. This results in accessing an invalid or incorrect block group. This issue became visible after Josef's patch "Btrfs: remove empty block groups automatically". So if the block group is removed make sure we don't leave a dangling caching_ctl in caching_block_groups. Sample crash trace: [58380.439449] BUG: unable to handle kernel paging request at ffff8801446eaeb8 [58380.439707] IP: [<ffffffffa03f6d05>] block_group_cache_done.isra.21+0xc/0x1c [btrfs] [58380.440879] PGD 1acb067 PUD 23f5ff067 PMD 23f5db067 PTE 80000001446ea060 [58380.441220] Oops: 0000 [#1] SMP DEBUG_PAGEALLOC [58380.441486] Modules linked in: btrfs crc32c_generic xor raid6_pq nfsd auth_rpcgss oid_registry nfs_acl nfs lockd fscache sunrpc loop psmouse processor i2c_piix4 parport_pc parport pcspkr serio_raw evdev i2ccore thermal_sys microcode button ext4 crc16 jbd2 mbcache sr_mod cdrom ata_generic sg sd_mod crc_t10dif crct10dif_generic crct10dif_common virtio_scsi floppy ata_piix e1000 libata virtio_pci scsi_mod virtio_ring virtio [last unloaded: btrfs] [58380.443238] CPU: 3 PID: 25728 Comm: btrfs-transacti Tainted: G W 3.17.0-rc5-btrfs-next-1+ #1 [58380.443238] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.7.5-0-ge51488c-20140602_164612-nilsson.home.kraxel.org 04/01/2014 [58380.443238] task: ffff88013ac82090 ti: ffff88013896c000 task.ti: ffff88013896c000 [58380.443238] RIP: 0010:[<ffffffffa03f6d05>] [<ffffffffa03f6d05>] block_group_cache_done.isra.21+0xc/0x1c [btrfs] [58380.443238] RSP: 0018:ffff88013896fdd8 EFLAGS: 00010283 [58380.443238] RAX: ffff880222cae850 RBX: ffff880119ba74c0 RCX: 0000000000000000 [58380.443238] RDX: 0000000000000000 RSI: ffff880185e16800 RDI: ffff8801446eaeb8 [58380.443238] RBP: ffff88013896fdd8 R08: ffff8801a9ca9fa8 R09: ffff88013896fc60 [58380.443238] R10: ffff88013896fd28 R11: 0000000000000000 R12: ffff880222cae000 [58380.443238] R13: ffff880222cae850 R14: ffff880222cae6b0 R15: ffff8801446eae00 [58380.443238] FS: 0000000000000000(0000) GS:ffff88023ed80000(0000) knlGS:0000000000000000 [58380.443238] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [58380.443238] CR2: ffff8801446eaeb8 CR3: 0000000001811000 CR4: 00000000000006e0 [58380.443238] Stack: [58380.443238] ffff88013896fe18 ffffffffa03fe2d5 ffff880222cae850 ffff880185e16800 [58380.443238] ffff88000dc41c20 0000000000000000 ffff8801a9ca9f00 0000000000000000 [58380.443238] ffff88013896fe80 ffffffffa040fbcf ffff88018b0dcdb0 ffff88013ac82090 [58380.443238] Call Trace: [58380.443238] [<ffffffffa03fe2d5>] btrfs_prepare_extent_commit+0x5a/0xd7 [btrfs] [58380.443238] [<ffffffffa040fbcf>] btrfs_commit_transaction+0x45c/0x882 [btrfs] [58380.443238] [<ffffffffa040c058>] transaction_kthread+0xf2/0x1a4 [btrfs] [58380.443238] [<ffffffffa040bf66>] ? btrfs_cleanup_transaction+0x3d8/0x3d8 [btrfs] [58380.443238] [<ffffffff8105966b>] kthread+0xb7/0xbf [58380.443238] [<ffffffff810595b4>] ? __kthread_parkme+0x67/0x67 [58380.443238] [<ffffffff813ebeac>] ret_from_fork+0x7c/0xb0 [58380.443238] [<ffffffff810595b4>] ? __kthread_parkme+0x67/0x67 Signed-off-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Chris Mason <clm@fb.com>		2014-12-02 18:19:17 -08:00
..
9p	9p: switch to %p[dD]	2014-10-09 02:39:04 -04:00
adfs	adfs: add __printf verification, fix format/argument mismatches	2014-08-08 15:57:24 -07:00
affs	fs/affs: remove redundant sys_tz declarations	2014-10-14 02:18:22 +02:00
afs	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-10-13 16:23:15 +02:00
autofs4	autofs4: d_manage() should return -EISDIR when appropriate in rcu-walk mode.	2014-10-14 02:18:16 +02:00
befs	fs/befs/btree.c: remove typedef befs_btree_node	2014-10-14 02:18:20 +02:00
bfs	fs/bfs: use bfs prefix for dump_imap	2014-08-08 15:57:24 -07:00
btrfs	Btrfs: fix crash caused by block group removal	2014-12-02 18:19:17 -08:00
cachefiles	FS-Cache fixes	2014-10-14 08:40:15 +02:00
ceph	ceph: fix flush tid comparision	2014-11-13 22:19:05 +03:00
cifs	[CIFS] Remove obsolete comment	2014-10-17 17:17:12 -05:00
coda	fs/coda: use linux/uaccess.h	2014-08-08 15:57:20 -07:00
configfs
cramfs	fs/cramfs/inode.c: use linux/uaccess.h	2014-08-08 15:57:25 -07:00
debugfs	fs: debugfs: remove trailing whitespace	2014-07-09 16:58:21 -07:00
devpts
dlm	dlm: fix missing endian conversion of rcom_status flags	2014-10-14 15:11:48 -05:00
ecryptfs	fs: limit filesystem stacking depth	2014-10-24 00:14:39 +02:00
efivarfs
efs	fs/efs/namei.c: return is not a function	2014-08-08 15:57:18 -07:00
exofs	Boaz Harrosh - Fix broken email address	2014-10-19 20:22:32 +03:00
exportfs
ext2	percpu_counter: add @gfp to percpu_counter_init()	2014-09-08 09:51:29 +09:00
ext3	ext3: Don't check quota format when there are no quota files	2014-10-22 09:02:48 +02:00
ext4	ext4: make ext4_ext_convert_to_initialized() return proper number of blocks	2014-10-30 10:53:17 -04:00
f2fs	f2fs: support volatile operations for transient data	2014-10-07 11:54:41 -07:00
fat	fat: remove redundant sys_tz declaration	2014-10-14 02:18:20 +02:00
freevxfs
fscache	fs/fscache/object-list.c: use __seq_open_private()	2014-10-13 17:52:21 +01:00
fuse	vfs: Make d_invalidate return void	2014-10-09 02:38:57 -04:00
gfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-10-13 11:28:42 +02:00
hfs	fs/hfs/hfs_fs.h: remove redundant sys_tz declaration	2014-10-14 02:18:20 +02:00
hfsplus	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
hostfs	hostfs: support rename flags	2014-08-07 14:40:09 -04:00
hpfs	fs/hpfs/dnode.c: fix suspect code indent	2014-08-08 15:57:22 -07:00
hppfs
hugetlbfs
isofs	isofs: don't bother with ->d_op for normal case	2014-10-31 06:33:17 -04:00
jbd	fs, jbd: use a more generic hash function	2014-10-22 10:02:04 +02:00
jbd2	jbd2: use a better hash function for the revoke table	2014-10-30 10:53:17 -04:00
jffs2	[jffs2] kill wbuf_queued/wbuf_dwork_lock	2014-10-09 02:39:01 -04:00
jfs	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-10-13 16:23:15 +02:00
kernfs	vfs: Remove unnecessary calls of check_submounts_and_drop	2014-10-09 02:38:56 -04:00
lockd	File locking related changes for v3.18 (pile #1)	2014-10-11 13:21:34 -04:00
logfs	fs/logfs/readwrite.c: kernel-doc warning fixes	2014-08-06 18:01:12 -07:00
minix	minix zmap block counts calculation fix	2014-08-08 15:57:20 -07:00
ncpfs	fs/ncpfs/dir.c: remove redundant sys_tz declaration	2014-10-14 02:18:16 +02:00
nfs	NFS: Don't try to reclaim delegation open state if recovery failed	2014-11-12 17:19:04 -05:00
nfs_common	lockd: move lockd's grace period handling into its own module	2014-09-17 16:33:11 -04:00
nfsd	nfsd4: fix crash on unknown operation number	2014-10-23 13:39:51 -04:00
nilfs2	nilfs2: improve the performance of fdatasync()	2014-10-14 02:18:20 +02:00
nls
notify	fanotify: fix notification of groups with inode & mount marks	2014-11-13 16:17:06 -08:00
ntfs	NTFS: Bump version to 2.1.31.	2014-10-16 12:53:35 +01:00
ocfs2	fix breakage in o2net_send_tcp_msg()	2014-11-05 15:21:18 -05:00
omfs	FS/OMFS: block number sanity check during fill_super operation	2014-10-14 02:18:22 +02:00
openpromfs
overlayfs	ovl: don't poison cursor	2014-11-05 08:49:38 -05:00
proc	mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared	2014-10-14 02:18:28 +02:00
pstore	pstore: Fix duplicate {console,ftrace}-efi entries	2014-10-15 13:51:33 -07:00
qnx4
qnx6	fs/qnx6: update debugging to current functions	2014-08-08 15:57:26 -07:00
quota	quota: Properly return errors from dquot_writeback_dquots()	2014-10-22 09:08:03 +02:00
ramfs	fs/ramfs/file-nommu.c: replace count*size kzalloc by kcalloc	2014-08-08 15:57:18 -07:00
reiserfs	fs/reiserfs/journal.c: fix sparse context imbalance warning	2014-10-14 02:18:20 +02:00
romfs	fs/romfs/super.c: add blank line after declarations	2014-08-08 15:57:25 -07:00
squashfs	fs/squashfs/super.c: logging cleanup	2014-08-06 18:01:13 -07:00
sysfs
sysv
ubifs	UBIFS: Fix trivial typo in power_cut_emulated()	2014-09-30 09:29:44 +03:00
udf	udf: Fix loading of special inodes	2014-10-09 13:06:14 +02:00
ufs	fs/ufs/balloc.c: remove unused variable	2014-10-14 02:18:20 +02:00
xfs	xfs: track bulkstat progress by agino	2014-11-07 08:33:52 +11:00
aio.c	percpu_ref: add PERCPU_REF_INIT_* flags	2014-09-24 13:31:50 -04:00
anon_inodes.c
attr.c	fs,userns: Change inode_capable to capable_wrt_inode_uidgid	2014-06-10 13:57:22 -07:00
bad_inode.c	bad_inode: add ->rename2()	2014-08-07 14:40:09 -04:00
binfmt_aout.c	handle suicide on late failure exits in execve() in search_binary_handler()	2014-10-09 02:39:00 -04:00
binfmt_elf_fdpic.c	handle suicide on late failure exits in execve() in search_binary_handler()	2014-10-09 02:39:00 -04:00
binfmt_elf.c	handle suicide on late failure exits in execve() in search_binary_handler()	2014-10-09 02:39:00 -04:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	binfmt_misc: work around gcc-4.9 warning	2014-10-14 02:18:16 +02:00
binfmt_script.c
binfmt_som.c
block_dev.c	Return short read or 0 at end of a raw device, not EIO	2014-10-31 06:33:26 -04:00
buffer.c	fs: clarify rate limit suppressed buffer I/O errors	2014-10-21 13:55:11 -06:00
char_dev.c
compat_binfmt_elf.c
compat_ioctl.c	Bluetooth: Move HCI socket definitions into its own header file	2014-07-11 13:53:04 +03:00
compat.c	vfs: move getname() from callers to do_mount()	2014-10-09 02:39:16 -04:00
coredump.c	coredump: add %i/%I in core_pattern to report the tid of the crashed thread	2014-10-14 02:18:21 +02:00
dcache.c	fix inode leaks on d_splice_alias() failure exits	2014-10-23 22:30:18 -04:00
dcookies.c
direct-io.c	fuse: honour max_read and max_write in direct_io mode	2014-09-26 21:16:51 -04:00
drop_caches.c
eventfd.c
eventpoll.c	eventpoll: fix uninitialized variable in epoll_ctl	2014-09-10 15:42:12 -07:00
exec.c	handle suicide on late failure exits in execve() in search_binary_handler()	2014-10-09 02:39:00 -04:00
fcntl.c	security: make security_file_set_fowner, f_setown and __f_setown void return	2014-09-09 16:01:36 -04:00
fhandle.c
file_table.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-10-13 11:28:42 +02:00
file.c	Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-10-13 15:44:12 +02:00
filesystems.c
fs_pin.c	make fs/{namespace,super}.c forget about acct.h	2014-08-07 14:40:09 -04:00
fs_struct.c
fs-writeback.c	sched: Remove proliferation of wait_on_bit() action functions	2014-07-16 15:10:39 +02:00
inode.c	mm: allow drivers to prevent new writable mappings	2014-08-08 15:57:31 -07:00
internal.h	vfs: export __inode_permission() to modules	2014-10-24 00:14:35 +02:00
ioctl.c
Kconfig	overlay filesystem	2014-10-24 00:14:38 +02:00
Kconfig.binfmt
libfs.c	locks: plumb a "priv" pointer into the setlease routines	2014-10-07 14:06:12 -04:00
locks.c	locks: flock_make_lock should return a struct file_lock (or PTR_ERR)	2014-10-07 14:06:13 -04:00
Makefile	overlay filesystem	2014-10-24 00:14:38 +02:00
mbcache.c	fs/mbcache: replace __builtin_log2() with ilog2()	2014-06-25 22:08:29 -04:00
mount.h	vfs: Add a function to lazily unmount all mounts from any dentry.	2014-10-09 02:38:55 -04:00
mpage.c	vfs: guard end of device for mpage interface	2014-10-09 22:25:53 -04:00
namei.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-11-02 10:28:43 -08:00
namespace.c	vfs: introduce clone_private_mount()	2014-10-24 00:14:36 +02:00
no-block.c
open.c	vfs: add i_op->dentry_open()	2014-10-24 00:14:35 +02:00
pipe.c
pnode.c	get rid of propagate_umount() mistakenly treating slaves as busy.	2014-08-30 18:31:41 -04:00
pnode.h
posix_acl.c
proc_namespace.c	namespaces: Use task_lock and not rcu to protect nsproxy	2014-07-29 18:08:50 -07:00
read_write.c	cachefiles_write_page(): switch to __kernel_write()	2014-10-09 02:39:05 -04:00
readdir.c
select.c
seq_file.c	fs/seq_file: fallback to vmalloc allocation	2014-07-03 09:21:54 -07:00
signalfd.c
splice.c	vfs: export do_splice_direct() to modules	2014-10-24 00:14:35 +02:00
stack.c	fs: fix comment for 'CONFIG_LBADF'	2014-08-26 09:35:56 +02:00
stat.c
statfs.c
super.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-10-13 11:28:42 +02:00
sync.c	Export sync_filesystem() for modular ->remount_fs() use	2014-09-05 08:16:21 -07:00
timerfd.c	timerfd: Remove an always true check	2014-08-27 11:17:48 +02:00
utimes.c
xattr.c	vfs: Deduplicate code shared by xattr system calls operating on paths	2014-10-12 17:09:10 -04:00