DingXiang 4df2bf466a dm snapshot: disallow the COW and origin devices from being identical ... Otherwise loading a "snapshot" table using the same device for the origin and COW devices, e.g.: echo "0 20971520 snapshot 253:3 253:3 P 8" | dmsetup create snap will trigger: BUG: unable to handle kernel NULL pointer dereference at 0000000000000098 [ 1958.979934] IP: [<ffffffffa040efba>] dm_exception_store_set_chunk_size+0x7a/0x110 [dm_snapshot] [ 1958.989655] PGD 0 [ 1958.991903] Oops: 0000 [#1] SMP ... [ 1959.059647] CPU: 9 PID: 3556 Comm: dmsetup Tainted: G IO 4.5.0-rc5.snitm+ #150 ... [ 1959.083517] task: ffff8800b9660c80 ti: ffff88032a954000 task.ti: ffff88032a954000 [ 1959.091865] RIP: 0010:[<ffffffffa040efba>] [<ffffffffa040efba>] dm_exception_store_set_chunk_size+0x7a/0x110 [dm_snapshot] [ 1959.104295] RSP: 0018:ffff88032a957b30 EFLAGS: 00010246 [ 1959.110219] RAX: 0000000000000000 RBX: 0000000000000008 RCX: 0000000000000001 [ 1959.118180] RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffff880329334a00 [ 1959.126141] RBP: ffff88032a957b50 R08: 0000000000000000 R09: 0000000000000001 [ 1959.134102] R10: 000000000000000a R11: f000000000000000 R12: ffff880330884d80 [ 1959.142061] R13: 0000000000000008 R14: ffffc90001c13088 R15: ffff880330884d80 [ 1959.150021] FS: 00007f8926ba3840(0000) GS:ffff880333440000(0000) knlGS:0000000000000000 [ 1959.159047] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1959.165456] CR2: 0000000000000098 CR3: 000000032f48b000 CR4: 00000000000006e0 [ 1959.173415] Stack: [ 1959.175656] ffffc90001c13040 ffff880329334a00 ffff880330884ed0 ffff88032a957bdc [ 1959.183946] ffff88032a957bb8 ffffffffa040f225 ffff880329334a30 ffff880300000000 [ 1959.192233] ffffffffa04133e0 ffff880329334b30 0000000830884d58 00000000569c58cf [ 1959.200521] Call Trace: [ 1959.203248] [<ffffffffa040f225>] dm_exception_store_create+0x1d5/0x240 [dm_snapshot] [ 1959.211986] [<ffffffffa040d310>] snapshot_ctr+0x140/0x630 [dm_snapshot] [ 1959.219469] [<ffffffffa0005c44>] ? dm_split_args+0x64/0x150 [dm_mod] [ 1959.226656] [<ffffffffa0005ea7>] dm_table_add_target+0x177/0x440 [dm_mod] [ 1959.234328] [<ffffffffa0009203>] table_load+0x143/0x370 [dm_mod] [ 1959.241129] [<ffffffffa00090c0>] ? retrieve_status+0x1b0/0x1b0 [dm_mod] [ 1959.248607] [<ffffffffa0009e35>] ctl_ioctl+0x255/0x4d0 [dm_mod] [ 1959.255307] [<ffffffff813304e2>] ? memzero_explicit+0x12/0x20 [ 1959.261816] [<ffffffffa000a0c3>] dm_ctl_ioctl+0x13/0x20 [dm_mod] [ 1959.268615] [<ffffffff81215eb6>] do_vfs_ioctl+0xa6/0x5c0 [ 1959.274637] [<ffffffff81120d2f>] ? __audit_syscall_entry+0xaf/0x100 [ 1959.281726] [<ffffffff81003176>] ? do_audit_syscall_entry+0x66/0x70 [ 1959.288814] [<ffffffff81216449>] SyS_ioctl+0x79/0x90 [ 1959.294450] [<ffffffff8167e4ae>] entry_SYSCALL_64_fastpath+0x12/0x71 ... [ 1959.323277] RIP [<ffffffffa040efba>] dm_exception_store_set_chunk_size+0x7a/0x110 [dm_snapshot] [ 1959.333090] RSP <ffff88032a957b30> [ 1959.336978] CR2: 0000000000000098 [ 1959.344121] ---[ end trace b049991ccad1169e ]--- Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1195899 Cc: stable@vger.kernel.org Signed-off-by: Ding Xiang <dingxiang@huawei.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>		2016-03-10 17:12:09 -05:00
..
bcache	Merge branch 'for-4.5/drivers' of git://git.kernel.dk/linux-block	2016-01-21 18:19:38 -08:00
persistent-data	dm space map metadata: remove unused variable in brb_pop()	2015-12-14 09:26:01 -05:00
bitmap.c	md-cluster: delete useless code	2016-01-24 18:13:37 -08:00
bitmap.h	md-cluster: Use a small window for resync	2015-10-12 01:32:05 -05:00
dm-bio-prison.c	block: add a bi_error field to struct bio	2015-07-29 08:55:15 -06:00
dm-bio-prison.h	dm bio prison: add dm_cell_promote_or_release()	2015-05-29 14:19:06 -04:00
dm-bio-record.h
dm-bufio.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-01-12 17:11:47 -08:00
dm-bufio.h
dm-builtin.c
dm-cache-block-types.h	dm cache: revert "remove remainder of distinct discard block size"	2014-11-10 15:25:30 -05:00
dm-cache-metadata.c	- Revert a dm-multipath change that caused a regression for unprivledged	2015-11-04 21:19:53 -08:00
dm-cache-metadata.h	dm cache: add fail io mode and needs_check flag	2015-06-11 17:13:00 -04:00
dm-cache-policy-cleaner.c	- Revert a dm-multipath change that caused a regression for unprivledged	2015-11-04 21:19:53 -08:00
dm-cache-policy-internal.h	dm cache: age and write back cache entries even without active IO	2015-06-11 17:13:01 -04:00
dm-cache-policy-smq.c	dm cache: make the 'mq' policy an alias for 'smq'	2016-03-10 17:12:08 -05:00
dm-cache-policy.c
dm-cache-policy.h	dm cache: age and write back cache entries even without active IO	2015-06-11 17:13:01 -04:00
dm-cache-target.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-crypt.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-delay.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-era-target.c	dm persistent data: eliminate unnecessary return values	2015-10-31 19:06:02 -04:00
dm-exception-store.c	- Revert a dm-multipath change that caused a regression for unprivledged	2015-11-04 21:19:53 -08:00
dm-exception-store.h	dm snapshot: fix hung bios when copy error occurs	2016-01-08 20:03:05 -05:00
dm-flakey.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-io.c	md: more open-coded offset_in_page()	2016-01-04 10:29:12 -05:00
dm-ioctl.c	dm: allow immutable request-based targets to use blk-mq pdu	2016-02-22 22:34:37 -05:00
dm-kcopyd.c	mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd	2015-11-06 17:50:42 -08:00
dm-linear.c	dm linear: remove redundant target name from error messages	2015-10-31 19:06:03 -04:00
dm-log-userspace-base.c	dm: drop NULL test before kmem_cache_destroy() and mempool_destroy()	2015-10-31 19:06:00 -04:00
dm-log-userspace-transfer.c	dm log userspace transfer: match wait_for_completion_timeout return type	2015-04-15 12:10:20 -04:00
dm-log-userspace-transfer.h
dm-log-writes.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-log.c
dm-mpath.c	dm mpath: cleanup reinstate_path() et al based on code review	2016-03-10 17:12:04 -05:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h	dm path selector: remove 'repeat_count' return from .select_path hook	2016-02-22 22:34:42 -05:00
dm-queue-length.c	dm path selector: remove 'repeat_count' return from .select_path hook	2016-02-22 22:34:42 -05:00
dm-raid1.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-raid.c	dm raid: fix round up of default region size	2015-10-02 12:02:31 -04:00
dm-region-hash.c	dm: convert ffs to __ffs	2015-10-31 19:06:01 -04:00
dm-round-robin.c	dm round robin: use percpu 'repeat_count' and 'current_path'	2016-02-22 22:34:42 -05:00
dm-service-time.c	dm path selector: remove 'repeat_count' return from .select_path hook	2016-02-22 22:34:42 -05:00
dm-snap-persistent.c	dm snapshot: fix hung bios when copy error occurs	2016-01-08 20:03:05 -05:00
dm-snap-transient.c	dm snapshot: fix hung bios when copy error occurs	2016-01-08 20:03:05 -05:00
dm-snap.c	dm snapshot: disallow the COW and origin devices from being identical	2016-03-10 17:12:09 -05:00
dm-stats.c	dm stats: report precise_timestamps and histogram in @stats_list output	2015-08-18 17:20:03 -04:00
dm-stats.h	dm stats: support precise timestamps	2015-06-17 12:40:40 -04:00
dm-stripe.c	Merge tag 'dm-4.3-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm	2015-09-02 16:35:26 -07:00
dm-switch.c	dm switch: simplify conditional in alloc_region_table()	2015-10-31 19:06:06 -04:00
dm-sysfs.c	dm: add 'use_blk_mq' module param and expose in per-device ro sysfs attr	2015-04-15 12:10:17 -04:00
dm-table.c	dm snapshot: disallow the COW and origin devices from being identical	2016-03-10 17:12:09 -05:00
dm-target.c	dm: set DM_TARGET_WILDCARD feature on "error" target	2016-02-22 11:06:21 -05:00
dm-thin-metadata.c	dm thin metadata: remove needless newline from subtree_dec() DMERR message	2016-03-10 17:12:05 -05:00
dm-thin-metadata.h	dm thin metadata: add dm_thin_remove_range()	2015-06-11 17:13:04 -04:00
dm-thin.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-uevent.c
dm-uevent.h
dm-verity-fec.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-verity-fec.h	dm verity: add support for forward error correction	2015-12-10 10:39:03 -05:00
dm-verity-target.c	dm: rename target's per_bio_data_size to per_io_data_size	2016-02-22 22:34:37 -05:00
dm-verity.h	dm verity: add ignore_zero_blocks feature	2015-12-10 10:39:03 -05:00
dm-zero.c	block: add a bi_error field to struct bio	2015-07-29 08:55:15 -06:00
dm.c	dm: drop unnecessary assignment of md->queue	2016-03-10 17:12:07 -05:00
dm.h	dm: allow immutable request-based targets to use blk-mq pdu	2016-02-22 22:34:37 -05:00
faulty.c	MD: rename some functions	2016-01-20 13:52:20 -08:00
Kconfig	dm cache: make the 'mq' policy an alias for 'smq'	2016-03-10 17:12:08 -05:00
linear.c	block: kill merge_bvec_fn() completely	2015-08-13 12:31:57 -06:00
linear.h
Makefile	dm cache: make the 'mq' policy an alias for 'smq'	2016-03-10 17:12:08 -05:00
md-cluster.c	md-cluster: fix missing memory free	2016-01-24 18:13:18 -08:00
md-cluster.h	md-cluster: append some actions when change bitmap from clustered to none	2016-01-06 11:38:57 +11:00
md.c	md updates for 4.5	2016-01-15 12:28:00 -08:00
md.h	md updates for 4.5	2016-01-15 12:28:00 -08:00
multipath.c	md/raid: only permit hot-add of compatible integrity profiles	2016-01-14 11:49:57 +11:00
multipath.h
raid0.c	treewide: Fix typos in printk	2015-12-08 14:59:19 +01:00
raid0.h	block: kill merge_bvec_fn() completely	2015-08-13 12:31:57 -06:00
raid1.c	MD: rename some functions	2016-01-20 13:52:20 -08:00
raid1.h	md-cluster: Use a small window for resync	2015-10-12 01:32:05 -05:00
raid5-cache.c	raid5-cache: handle journal hotadd in quiesce	2016-01-14 11:49:43 +11:00
raid5.c	MD: rename some functions	2016-01-20 13:52:20 -08:00
raid5.h	raid5-cache: IO error handling	2015-11-01 13:48:29 +11:00
raid10.c	MD: rename some functions	2016-01-20 13:52:20 -08:00
raid10.h	md/raid10: ensure device failure recorded before write request returns.	2015-08-31 19:43:45 +02:00