Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-15 00:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
4ddd51ccff
linux/sound/soc/mediatek
History
Chen-Yu Tsai 282a4482e1
ASoC: mediatek: mt8195: Add platform entry for ETDM1_OUT_BE dai link 
Commit e70b8dd267 ("ASoC: mediatek: mt8195: Remove afe-dai component
and rework codec link") removed the codec entry for the ETDM1_OUT_BE
dai link entirely instead of replacing it with COMP_EMPTY(). This worked
by accident as the remaining COMP_EMPTY() platform entry became the codec
entry, and the platform entry became completely empty, effectively the
same as COMP_DUMMY() since snd_soc_fill_dummy_dai() doesn't do anything
for platform entries.

This causes a KASAN out-of-bounds warning in mtk_soundcard_common_probe()
in sound/soc/mediatek/common/mtk-soundcard-driver.c:

	for_each_card_prelinks(card, i, dai_link) {
		if (adsp_node && !strncmp(dai_link->name, "AFE_SOF", strlen("AFE_SOF")))
			dai_link->platforms->of_node = adsp_node;
		else if (!dai_link->platforms->name && !dai_link->platforms->of_node)
			dai_link->platforms->of_node = platform_node;
	}

where the code expects the platforms array to have space for at least one entry.

Add an COMP_EMPTY() entry so that dai_link->platforms has space.

Fixes: e70b8dd267 ("ASoC: mediatek: mt8195: Remove afe-dai component and rework codec link")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20240624061257.3115467-1-wenst@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
2024-06-24 13:38:10 +01:00
..
common ASoC: mediatek: Use *-y instead of *-objs in Makefile 2024-05-08 11:39:23 +09:00
mt2701 ASoC: mediatek: Use *-y instead of *-objs in Makefile 2024-05-08 11:39:23 +09:00
mt6797 ASoC: mediatek: Use *-y instead of *-objs in Makefile 2024-05-08 11:39:23 +09:00
mt7986 ASoC: mediatek: Use *-y instead of *-objs in Makefile 2024-05-08 11:39:23 +09:00
mt8173 ASoC: mt8173-rt5650: Drop unused includes 2023-10-09 14:27:48 +01:00
mt8183 ASoC: mediatek: mt8183-da7219-max98357: Fix kcontrol name collision 2024-06-05 13:03:12 +01:00
mt8186 ASoC: mediatek: Use *-y instead of *-objs in Makefile 2024-05-08 11:39:23 +09:00
mt8188 ASoC: mediatek: Use *-y instead of *-objs in Makefile 2024-05-08 11:39:23 +09:00
mt8192 ASoC: Updates for v6.10 2024-05-13 11:39:49 +02:00
mt8195 ASoC: mediatek: mt8195: Add platform entry for ETDM1_OUT_BE dai link 2024-06-24 13:38:10 +01:00
Kconfig ASoC: mediatek: mt8186: Unify mt8186-mt6366 machine drivers 2024-04-16 20:00:04 +09:00
Makefile ASoC: mediatek: mt7986: add platform driver 2023-08-17 13:09:17 +01:00