linux/drivers/net/fjes
Jakub Kicinski 57e3c5af2b net: fjes: correct TRACE_INCLUDE_PATH
A comment in define_trace.h clearly states:

 TRACE_INCLUDE_PATH if the path is something other than core kernel
                                                           vvvvvvvvvvvvvv
 include/trace then this macro can define the path to use. Note, the path
 is relative to define_trace.h, not the file including it. Full path names
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 for out of tree modules must be used.

fjes uses path relative to itself. Which (somehow) works most of
the time. Except when the kernel tree is "nested" in another
kernel tree, and ../drivers/net/fjes actually exists. In which
case build will use the header file from the wrong directory.

I've been trying to figure out why net NIPA builder is constantly
failing for the last 5 days, with:

include/trace/../../../drivers/net/fjes/fjes_trace.h:88:17: error: ‘__assign_str’ undeclared (first use in this function)
   88 |                 __assign_str(err, err);
      |                 ^~~~~~~~~~~~

when the line in the tree clearly has only one "err". NIPA does
indeed have "nested" trees, because it uses git work-trees and
the tree on the "outside" is not very up to date.

Link: https://lore.kernel.org/r/20240529023322.3467755-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2024-05-30 18:28:31 -07:00
..
fjes_debugfs.c fjes: no need to check return value of debugfs_create functions 2019-06-22 16:43:08 -07:00
fjes_ethtool.c net: move from strlcpy with unused retval to strscpy 2022-08-31 14:11:07 -07:00
fjes_hw.c fjes: fix memleaks in fjes_hw_setup 2024-01-24 18:03:53 -08:00
fjes_hw.h net: fjes: constify and use eth_hw_addr_set() 2021-10-22 10:16:07 -07:00
fjes_main.c Networking changes for 6.10. 2024-05-14 19:42:24 -07:00
fjes_regs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 308 2019-06-05 17:37:04 +02:00
fjes_trace.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 308 2019-06-05 17:37:04 +02:00
fjes_trace.h net: fjes: correct TRACE_INCLUDE_PATH 2024-05-30 18:28:31 -07:00
fjes.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 308 2019-06-05 17:37:04 +02:00
Makefile treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 308 2019-06-05 17:37:04 +02:00