linux/tools
Kirill A. Shutemov 4cc49d4dc8 perf tools: use XSI-complaint version of strerror_r() instead of GNU-specific
Perf uses GNU-specific version of strerror_r(). The GNU-specific strerror_r()
returns a pointer to a string containing the error message.  This may be either
a pointer to a string that the function stores in buf, or a pointer to some
(immutable) static string (in which case buf is unused).

In glibc-2.16 GNU version was marked with attribute warn_unused_result.  It
triggers few warnings in perf:

util/target.c: In function ‘perf_target__strerror’:
util/target.c:114:13: error: ignoring return value of ‘strerror_r’, declared with attribute warn_unused_result [-Werror=unused-result]
ui/browsers/hists.c: In function ‘hist_browser__dump’:
ui/browsers/hists.c:981:13: error: ignoring return value of ‘strerror_r’, declared with attribute warn_unused_result [-Werror=unused-result]

They are bugs.

Let's fix strerror_r() usage.

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
Acked-by: Ulrich Drepper <drepper@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ulrich Drepper <drepper@gmail.com>
Link: http://lkml.kernel.org/r/20120723210654.GA25248@shutemov.name
[ committer note: s/assert/BUG_ON/g ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2012-07-25 11:46:04 -03:00
..
firewire tools/firewire: nosy-dump: increment program version 2010-07-27 11:04:12 +02:00
hv Tools: hv: verify origin of netlink connector message 2012-06-10 00:29:46 +09:00
include/tools tools/include: Add byteshift headers for endian access 2012-02-28 10:22:51 -08:00
lguest lguest: move the lguest tool to the tools directory 2012-01-12 15:44:47 +10:30
lib/traceevent tools lib traceevent: Cleanup realloc use 2012-07-04 13:40:31 +09:00
nfsd NFSD: Added fault injection script 2011-11-07 21:10:47 -05:00
perf perf tools: use XSI-complaint version of strerror_r() instead of GNU-specific 2012-07-25 11:46:04 -03:00
power tools/power turbostat: fix IVB support 2012-06-03 23:47:49 -04:00
scripts perf: Build libtraceevent.a 2012-04-25 13:01:40 +02:00
testing syscalls, x86: add __NR_kcmp syscall 2012-05-31 17:49:32 -07:00
usb USB: testusb: add path /dev/bus/usb to default search paths for usbfs 2012-05-15 08:41:13 -07:00
virtio virtio/tools: add delayed interupt mode 2012-05-02 18:22:14 +03:00
vm tools/vm/page-types.c: cleanups 2012-05-29 16:22:21 -07:00
Makefile tools: Connect to the kernel build system 2012-04-11 15:00:17 -03:00