Tom Zanussi 48f794731e tracing: Add action comparisons when testing matching hist triggers ... Actions also need to be considered when checking for matching triggers - triggers differing only by action should be allowed, but currently aren't because the matching check ignores the action and erroneously returns -EEXIST. Add and call an actions_match() function to address that. Here's an example using onmatch() actions. The first -EEXIST shouldn't occur because the onmatch() is different in the second wakeup_latency() param. The second -EEXIST shouldn't occur because it's a different action (in this case, it doesn't have an action, so shouldn't be seen as being the same and therefore rejected). In the after case, both are correctly accepted (and trying to add one of them again returns -EEXIST as it should). before: # echo 'wakeup_latency u64 lat; pid_t pid' >> /sys/kernel/debug/tracing/synthetic_events # echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_wakeup/trigger # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts0 if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger # echo 'hist:keys=next_pid:onmatch(sched.sched_wakeup).wakeup_latency(sched.sched_switch.$wakeup_lat,next_pid) if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger # echo 'hist:keys=next_pid:onmatch(sched.sched_wakeup).wakeup_latency(sched.sched_switch.$wakeup_lat,prev_pid) if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger -su: echo: write error: File exists # echo 'hist:keys=next_pid if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger -su: echo: write error: File exists after: # echo 'wakeup_latency u64 lat; pid_t pid' >> /sys/kernel/debug/tracing/synthetic_events # echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_wakeup/trigger # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts0 if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger # echo 'hist:keys=next_pid:onmatch(sched.sched_wakeup).wakeup_latency(sched.sched_switch.$wakeup_lat,next_pid) if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger # echo 'hist:keys=next_pid:onmatch(sched.sched_wakeup).wakeup_latency(sched.sched_switch.$wakeup_lat,prev_pid) if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger # echo 'hist:keys=next_pid if next_comm=="cyclictest"' >> /sys/kernel/debug/tracing/events/sched/sched_switch/trigger Link: http://lkml.kernel.org/r/a7fd668b87ec10736c8f016ac4279c8480d50c2b.1522256721.git.tom.zanussi@linux.intel.com Tested-by: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>		2018-04-06 08:56:49 -04:00
..
blktrace.c	blktrace: fix trace mutex deadlock	2017-11-27 12:03:58 -07:00
bpf_trace.c	bpf: fix bpf_prog_array_copy_to_user warning from perf event prog query	2018-02-14 08:59:37 -08:00
ftrace.c	ftrace: Drop a VLA in module_exists()	2018-04-06 08:56:48 -04:00
Kconfig	tracing: Add inter-event blurb to HIST_TRIGGERS config option	2018-03-10 16:06:05 -05:00
Makefile	Tracing updates for 4.15:	2017-11-17 14:58:01 -08:00
power-traces.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ring_buffer_benchmark.c	ring-buffer: Have ring_buffer_alloc_read_page() return error on offline CPU	2017-08-02 14:23:02 -04:00
ring_buffer.c	tracing: Mention trace_clock=global when warning about unstable clocks	2018-04-06 08:56:47 -04:00
rpm-traces.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_benchmark.c	trace: Eliminate cond_resched_rcu_qs() in favor of cond_resched()	2017-12-04 10:28:58 -08:00
trace_benchmark.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_branch.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_clock.c
trace_entries.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_event_perf.c	perf/ftrace: Small cleanup	2017-10-16 18:13:28 -04:00
trace_events_filter_test.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_events_filter.c	tracing: Rewrite filter logic to be simpler and faster	2018-03-14 12:35:39 -04:00
trace_events_hist.c	tracing: Add action comparisons when testing matching hist triggers	2018-04-06 08:56:49 -04:00
trace_events_trigger.c	tracing: Add variable reference handling to hist triggers	2018-03-10 16:05:58 -05:00
trace_events.c	tracing: Make sure the parsed string always terminates with '\0'	2018-01-23 15:57:28 -05:00
trace_export.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_functions_graph.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_functions.c	tracing: Update stack trace skipping for ORC unwinder	2018-01-23 15:57:00 -05:00
trace_hwlat.c
trace_irqsoff.c	tracing: Add support for preempt and irq enable/disable events	2017-10-10 18:58:43 -04:00
trace_kdb.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_kprobe.c	error-injection: Separate error-injection from kprobe	2018-01-12 17:33:38 -08:00
trace_mmiotrace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_nop.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_output.c	sched/debug: Rename task-state printing helpers	2017-10-10 11:43:29 +02:00
trace_output.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_printk.c
trace_probe.c	tracing: Make traceprobe parsing code reusable	2017-10-04 13:06:44 -04:00
trace_probe.h	tracing/kprobe: bpf: Check error injectable event is on function entry	2018-01-12 17:33:37 -08:00
trace_sched_switch.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_sched_wakeup.c	Merge branch 'linus' into sched/core, to pick up fixes	2017-11-08 10:17:15 +01:00
trace_selftest_dynamic.c	ftrace: Mark function tracer test functions noinline/noclone	2018-01-23 15:57:29 -05:00
trace_selftest.c	Tracing updates for 4.15:	2017-11-17 14:58:01 -08:00
trace_seq.c
trace_stack.c	tracing: Have stack trace not record if RCU is not watching	2017-12-14 20:48:22 -05:00
trace_stat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_stat.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_syscalls.c	Tracing updates for 4.15:	2017-11-17 14:58:01 -08:00
trace_uprobe.c	trace_uprobe: Display correct offset in uprobe_events	2018-01-23 15:57:29 -05:00
trace.c	tracing: Default to using trace_global_clock if sched_clock is unstable	2018-04-06 08:56:47 -04:00
trace.h	tracing: Rewrite filter logic to be simpler and faster	2018-03-14 12:35:39 -04:00
tracing_map.c	tracing: Add per-element variable support to tracing_map	2018-03-10 16:05:53 -05:00
tracing_map.h	tracing: Add per-element variable support to tracing_map	2018-03-10 16:05:53 -05:00