mirror of
https://github.com/torvalds/linux.git
synced 2024-11-14 16:12:02 +00:00
4b7a6ce71e
It doesn't make sense to issue prctl(PR_PAC_RESET_KEYS) on a
compat task because the 32-bit instruction set does not offer PAuth
instructions. For consistency with other 64-bit only prctls such as
{SET,GET}_TAGGED_ADDR_CTRL, reject the prctl on compat tasks.
Although this is a userspace-visible change, maybe it isn't too late
to make this change given that the hardware isn't available yet and
it's very unlikely that anyone has 32-bit software that actually
depends on this succeeding.
Signed-off-by: Peter Collingbourne <pcc@google.com>
Link: https://linux-review.googlesource.com/id/Ie885a1ff84ab498cc9f62d6451e9f2cfd4b1d06a
Link: https://lore.kernel.org/r/20201014052430.11630-1-pcc@google.com
[will: Do the same for the SVE prctl()s]
Signed-off-by: Will Deacon <will@kernel.org>
49 lines
1.3 KiB
C
49 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#include <linux/compat.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/prctl.h>
|
|
#include <linux/random.h>
|
|
#include <linux/sched.h>
|
|
#include <asm/cpufeature.h>
|
|
#include <asm/pointer_auth.h>
|
|
|
|
int ptrauth_prctl_reset_keys(struct task_struct *tsk, unsigned long arg)
|
|
{
|
|
struct ptrauth_keys_user *keys = &tsk->thread.keys_user;
|
|
unsigned long addr_key_mask = PR_PAC_APIAKEY | PR_PAC_APIBKEY |
|
|
PR_PAC_APDAKEY | PR_PAC_APDBKEY;
|
|
unsigned long key_mask = addr_key_mask | PR_PAC_APGAKEY;
|
|
|
|
if (!system_supports_address_auth() && !system_supports_generic_auth())
|
|
return -EINVAL;
|
|
|
|
if (is_compat_thread(task_thread_info(tsk)))
|
|
return -EINVAL;
|
|
|
|
if (!arg) {
|
|
ptrauth_keys_init_user(keys);
|
|
return 0;
|
|
}
|
|
|
|
if (arg & ~key_mask)
|
|
return -EINVAL;
|
|
|
|
if (((arg & addr_key_mask) && !system_supports_address_auth()) ||
|
|
((arg & PR_PAC_APGAKEY) && !system_supports_generic_auth()))
|
|
return -EINVAL;
|
|
|
|
if (arg & PR_PAC_APIAKEY)
|
|
get_random_bytes(&keys->apia, sizeof(keys->apia));
|
|
if (arg & PR_PAC_APIBKEY)
|
|
get_random_bytes(&keys->apib, sizeof(keys->apib));
|
|
if (arg & PR_PAC_APDAKEY)
|
|
get_random_bytes(&keys->apda, sizeof(keys->apda));
|
|
if (arg & PR_PAC_APDBKEY)
|
|
get_random_bytes(&keys->apdb, sizeof(keys->apdb));
|
|
if (arg & PR_PAC_APGAKEY)
|
|
get_random_bytes(&keys->apga, sizeof(keys->apga));
|
|
|
|
return 0;
|
|
}
|