mirror of
https://github.com/torvalds/linux.git
synced 2024-11-18 01:51:53 +00:00
f3e0269517
This patch fixes warning seen when BLK-MQ is enabled and hardware does not
support MQ. This will result into driver requesting MSIx vectors which are
equal or less than pre_desc via PCI IRQ Affinity infrastructure.
[ 19.746300] qla2xxx [0000:00:00.0]-0005: : QLogic Fibre Channel HBA Driver: 10.00.00.12-k.
[ 19.746599] qla2xxx [0000:02:00.0]-001d: : Found an ISP2432 irq 18 iobase 0x(____ptrval____).
[ 20.203186] ------------[ cut here ]------------
[ 20.203306] WARNING: CPU: 8 PID: 268 at drivers/pci/msi.c:1273 pci_irq_get_affinity+0xf4/0x120
[ 20.203481] Modules linked in: tg3 ptp qla2xxx(+) pps_core sg libphy scsi_transport_fc flash loop autofs4
[ 20.203700] CPU: 8 PID: 268 Comm: systemd-udevd Not tainted 5.0.0-rc5-00358-gdf3865f #113
[ 20.203830] Call Trace:
[ 20.203933] [0000000000461bb0] __warn+0xb0/0xe0
[ 20.204090] [00000000006c8f34] pci_irq_get_affinity+0xf4/0x120
[ 20.204219] [000000000068c764] blk_mq_pci_map_queues+0x24/0x120
[ 20.204396] [00000000007162f4] scsi_map_queues+0x14/0x40
[ 20.204626] [0000000000673654] blk_mq_update_queue_map+0x94/0xe0
[ 20.204698] [0000000000676ce0] blk_mq_alloc_tag_set+0x120/0x300
[ 20.204869] [000000000071077c] scsi_add_host_with_dma+0x7c/0x300
[ 20.205419] [00000000100ead54] qla2x00_probe_one+0x19d4/0x2640 [qla2xxx]
[ 20.205621] [00000000006b3c88] pci_device_probe+0xc8/0x160
[ 20.205697] [0000000000701c0c] really_probe+0x1ac/0x2e0
[ 20.205770] [0000000000701f90] driver_probe_device+0x50/0x100
[ 20.205843] [0000000000702134] __driver_attach+0xf4/0x120
[ 20.205913] [0000000000700644] bus_for_each_dev+0x44/0x80
[ 20.206081] [0000000000700c98] bus_add_driver+0x198/0x220
[ 20.206300] [0000000000702950] driver_register+0x70/0x120
[ 20.206582] [0000000010248224] qla2x00_module_init+0x224/0x284 [qla2xxx]
[ 20.206857] ---[ end trace b1de7a3f79fab2c2 ]---
The fix is to check if the hardware does not have Multi Queue capabiltiy,
use pci_alloc_irq_vectors() call instead of pci_alloc_irq_affinity().
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| qla_attr.c | ||
| qla_bsg.c | ||
| qla_bsg.h | ||
| qla_dbg.c | ||
| qla_dbg.h | ||
| qla_def.h | ||
| qla_devtbl.h | ||
| qla_dfs.c | ||
| qla_fw.h | ||
| qla_gbl.h | ||
| qla_gs.c | ||
| qla_init.c | ||
| qla_inline.h | ||
| qla_iocb.c | ||
| qla_isr.c | ||
| qla_mbx.c | ||
| qla_mid.c | ||
| qla_mr.c | ||
| qla_mr.h | ||
| qla_nvme.c | ||
| qla_nvme.h | ||
| qla_nx2.c | ||
| qla_nx2.h | ||
| qla_nx.c | ||
| qla_nx.h | ||
| qla_os.c | ||
| qla_settings.h | ||
| qla_sup.c | ||
| qla_target.c | ||
| qla_target.h | ||
| qla_tmpl.c | ||
| qla_tmpl.h | ||
| qla_version.h | ||
| tcm_qla2xxx.c | ||
| tcm_qla2xxx.h | ||