mirror of
https://github.com/torvalds/linux.git
synced 2024-11-10 22:21:40 +00:00
420c20be08
An earlier commit re-worked the setting of the bitmask and is now
assigning v with some bit flags rather than bitwise or-ing them
into v, consequently the earlier bit-settings of v are being lost.
Fix this by replacing an assignment with the bitwise or instead.
Addresses-Coverity: ("Unused value")
Fixes:
|
||
|---|---|---|
| .. | ||
| bcma_private.h | ||
| core.c | ||
| driver_chipcommon_b.c | ||
| driver_chipcommon_nflash.c | ||
| driver_chipcommon_pflash.c | ||
| driver_chipcommon_pmu.c | ||
| driver_chipcommon_sflash.c | ||
| driver_chipcommon.c | ||
| driver_gmac_cmn.c | ||
| driver_gpio.c | ||
| driver_mips.c | ||
| driver_pci_host.c | ||
| driver_pci.c | ||
| driver_pcie2.c | ||
| host_pci.c | ||
| host_soc.c | ||
| Kconfig | ||
| main.c | ||
| Makefile | ||
| README | ||
| scan.c | ||
| scan.h | ||
| sprom.c | ||
| TODO | ||
Broadcom introduced new bus as replacement for older SSB. It is based on AMBA, however from programming point of view there is nothing AMBA specific we use. Standard AMBA drivers are platform specific, have hardcoded addresses and use AMBA standard fields like CID and PID. In case of Broadcom's cards every device consists of: 1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated as standard AMBA device. Reading it's CID or PID can cause machine lockup. 2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID) and PIDs (0x103BB369), but we do not use that info for anything. One of that devices is used for managing Broadcom specific core. Addresses of AMBA devices are not hardcoded in driver and have to be read from EPROM. In this situation we decided to introduce separated bus. It can contain up to 16 devices identified by Broadcom specific fields: manufacturer, id, revision and class.