linux/fs/jfs
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
acl.c jfs: Use lowercase names of quota functions 2009-03-26 02:18:37 +01:00
endian24.h JFS: Whitespace cleanup and remove some dead code 2007-06-06 15:28:35 -05:00
file.c BKL-removal: Implement a compat_ioctl handler for JFS 2008-02-07 13:45:29 -06:00
inode.c jfs: Use lowercase names of quota functions 2009-03-26 02:18:37 +01:00
ioctl.c [PATCH] r/o bind mounts: elevate write count for ioctls() 2008-04-19 00:29:24 -04:00
jfs_acl.h [PATCH] sanitize ->permission() prototype 2008-07-26 20:53:14 -04:00
jfs_btree.h JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_debug.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
jfs_debug.h JFS: switch to seq_files 2008-05-13 08:22:10 -05:00
jfs_dinode.h BKL-removal: Implement a compat_ioctl handler for JFS 2008-02-07 13:45:29 -06:00
jfs_dmap.c jfs: le*_add_cpu conversion 2008-02-13 15:34:20 -06:00
jfs_dmap.h jfs: replace __inline with inline 2008-03-05 14:38:22 -06:00
jfs_dtree.c jfs: Use lowercase names of quota functions 2009-03-26 02:18:37 +01:00
jfs_dtree.h jfs: remove DIRENTSIZ 2008-06-10 15:12:58 -05:00
jfs_extent.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6 2009-03-30 10:02:36 -07:00
jfs_extent.h JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_filsys.h JFS: Whitespace cleanup and remove some dead code 2007-06-06 15:28:35 -05:00
jfs_imap.c jfs: clean up a dangling comment 2009-01-09 10:53:35 -06:00
jfs_imap.h JFS: Whitespace cleanup and remove some dead code 2007-06-06 15:28:35 -05:00
jfs_incore.h more low-hanging fruits - kernel, fs, lib signedness 2007-10-14 12:41:52 -07:00
jfs_inode.c jfs: Use lowercase names of quota functions 2009-03-26 02:18:37 +01:00
jfs_inode.h constify dentry_operations: JFS 2009-03-27 14:44:02 -04:00
jfs_lock.h JFS: use __set_current_state() 2007-04-26 07:30:29 -05:00
jfs_logmgr.c [PATCH] pass fmode_t to blkdev_put() 2008-10-21 07:48:58 -04:00
jfs_logmgr.h more low-hanging fruits - kernel, fs, lib signedness 2007-10-14 12:41:52 -07:00
jfs_metapage.c jfs: Fix error handling in metapage_writepage() 2009-01-30 14:09:06 -06:00
jfs_metapage.h JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_mount.c JFS: Remove defconfig ptr comparison to 0 2008-01-03 13:12:10 -06:00
jfs_superblock.h JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_txnmgr.c JFS: switch to seq_files 2008-05-13 08:22:10 -05:00
jfs_txnmgr.h JFS: Whitespace cleanup and remove some dead code 2007-06-06 15:28:35 -05:00
jfs_types.h jfs: remove xtLookupList() 2009-01-09 15:42:04 -06:00
jfs_umount.c JFS: Make sure special inode data is written after journal is flushed 2008-01-03 13:11:37 -06:00
jfs_unicode.c JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_unicode.h JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_uniupr.c JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_xattr.h JFS: White space cleanup 2006-10-02 09:55:27 -05:00
jfs_xtree.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6 2009-03-30 10:02:36 -07:00
jfs_xtree.h jfs: remove xtLookupList() 2009-01-09 15:42:04 -06:00
Kconfig jfs: needs crc32_le 2009-02-02 13:43:28 -06:00
Makefile JFS: ext2 inode attributes for jfs 2006-02-09 09:09:16 -06:00
namei.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6 2009-03-27 16:23:12 -07:00
resize.c JFS: use DIV_ROUND_UP where appropriate 2008-01-03 13:11:59 -06:00
super.c Merge branch 'master' of /home/shaggy/git/linus-clean/ 2009-02-02 13:40:55 -06:00
symlink.c [PATCH] mark struct inode_operations const 2 2007-02-12 09:48:46 -08:00
xattr.c jfs: Use lowercase names of quota functions 2009-03-26 02:18:37 +01:00