Jason A. Donenfeld 41c87425a1 netlink: do not set cb_running if dump's start() errs ... It turns out that multiple places can call netlink_dump(), which means it's still possible to dereference partially initialized values in dump() that were the result of a faulty returned start(). This fixes the issue by calling start() _before_ setting cb_running to true, so that there's no chance at all of hitting the dump() function through any indirect paths. It also moves the call to start() to be when the mutex is held. This has the nice side effect of serializing invocations to start(), which is likely desirable anyway. It also prevents any possible other races that might come out of this logic. In testing this with several different pieces of tricky code to trigger these issues, this commit fixes all avenues that I'm aware of. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Cc: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-10-09 10:27:49 -07:00
..
6lowpan
9p	net/9p: switch p9_fd_read to kernel_write	2017-09-04 19:05:16 -04:00
802	net: introduce __skb_put_[zero, data, u8]	2017-06-20 13:30:14 -04:00
8021q	net: 8021q: skip packets if the vlan is down	2017-10-04 18:16:48 -07:00
appletalk	networking: make skb_push & __skb_push return void pointers	2017-06-16 11:48:40 -04:00
atm	net: atm: make atmdev_ops const	2017-08-09 22:43:50 -07:00
ax25	net, ax25: convert ax25_cb.refcount from atomic_t to refcount_t	2017-07-04 22:35:19 +01:00
batman-adv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-09 16:28:45 -07:00
bluetooth	Revert "Bluetooth: Add option for disabling legacy ioctl interfaces"	2017-09-28 13:20:32 -07:00
bpf
bridge	bridge: switchdev: Use an helper to clear forward mark	2017-09-05 11:51:47 -07:00
caif	net: convert sock.sk_wmem_alloc from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
can	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
ceph	libceph: don't allow bidirectional swap of pg-upmap-items	2017-09-19 20:34:29 +02:00
core	net: rtnetlink: fix info leak in RTM_GETSTATS call	2017-10-03 10:18:00 -07:00
dcb	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
dccp	net: dccp: Add handling of IPV6_PKTOPTIONS to dccp_v6_do_rcv()	2017-08-31 11:43:47 -07:00
decnet	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2017-09-03 17:08:42 -07:00
dns_resolver
dsa	net: dsa: Fix network device registration order	2017-09-28 10:12:53 -07:00
ethernet	networking: make skb_push & __skb_push return void pointers	2017-06-16 11:48:40 -04:00
hsr	net/hsr: Check skb_put_padto() return value	2017-08-22 13:40:23 -07:00
ieee802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-05 20:03:35 -07:00
ife
ipv4	ipv4: Fix traffic triggered IPsec connections.	2017-10-09 09:39:50 -07:00
ipv6	ipv6: Fix traffic triggered IPsec connections.	2017-10-09 09:39:26 -07:00
ipx	net, ipx: convert ipx_route.refcnt from atomic_t to refcount_t	2017-07-04 22:35:17 +01:00
iucv	iucv: Convert sk_wmem_alloc accesses to refcount_t.	2017-07-03 02:31:22 -07:00
kcm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-15 20:23:23 -07:00
l2tp	l2tp: fix l2tp_eth module loading	2017-10-01 22:35:07 -07:00
l3mdev
lapb	net, lapb: convert lapb_cb.refcnt from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
llc	net, llc: convert llc_sap.refcnt from atomic_t to refcount_t	2017-07-04 22:35:15 +01:00
mac80211	mac80211: fix deadlock in driver-managed RX BA session start	2017-09-06 15:22:02 +02:00
mac802154
mpls	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
ncsi	net/ncsi: fix ncsi_vlan_rx_{add,kill}_vid references	2017-09-05 09:11:45 -07:00
netfilter	netfilter: ipset: ipset list may return wrong member count for set with timeout	2017-09-18 17:35:32 +02:00
netlabel
netlink	netlink: do not set cb_running if dump's start() errs	2017-10-09 10:27:49 -07:00
netrom	net, netrom: convert nr_node.refcount from atomic_t to refcount_t	2017-07-04 22:35:17 +01:00
nfc	NFC: Add sockaddr length checks before accessing sa_family in bind handlers	2017-06-23 00:38:31 +02:00
nsh	nsh: add GSO support	2017-08-29 15:16:52 -07:00
openvswitch	openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'	2017-09-12 20:37:31 -07:00
packet	packet: only test po->has_vnet_hdr once in packet_snd	2017-09-28 10:24:31 -07:00
phonet	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
psample	networking: make skb_put & friends return void pointers	2017-06-16 11:48:39 -04:00
qrtr	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
rds	rds: Fix incorrect statistics counting	2017-09-07 20:07:13 -07:00
rfkill	net: rfkill: gpio: Switch to devm_acpi_dev_add_driver_gpios()	2017-06-13 11:07:51 +02:00
rose
rxrpc	rxrpc: Make service connection lookup always check for retry	2017-09-05 14:39:17 -07:00
sched	net_sched: remove cls_flower idr on failure	2017-09-21 15:13:52 -07:00
sctp	sctp: Fix a big endian bug in sctp_diag_dump()	2017-09-26 21:16:29 -07:00
smc	net/smc: no close wait in case of process shut down	2017-09-21 15:31:03 -07:00
strparser	strparser: initialize all callbacks	2017-08-24 21:57:50 -07:00
sunrpc	IB: Correct MR length field to be 64-bit	2017-09-25 11:47:23 -04:00
switchdev	net: switchdev: Remove bridge bypass support from switchdev	2017-08-07 14:48:48 -07:00
tipc	tipc: Unclone message at secondary destination lookup	2017-10-08 21:13:23 -07:00
tls	tls: make tls_sw_free_resources static	2017-09-14 09:55:21 -07:00
unix	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-21 17:06:42 -07:00
vmw_vsock	hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)	2017-08-28 15:38:18 -07:00
wimax
wireless	nl80211: Define policy for packet pattern attributes	2017-10-04 14:39:21 +02:00
x25	X25: constify null_x25_address	2017-08-03 09:13:51 -07:00
xfrm	xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock	2017-09-28 09:39:05 +02:00
compat.c	net: compat: assert the size of cmsg copied in is as expected	2017-09-20 15:36:18 -07:00
Kconfig	net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.	2017-09-04 13:25:20 +02:00
Makefile	nsh: add GSO support	2017-08-29 15:16:52 -07:00
socket.c	net: fixes for skb_send_sock	2017-08-16 11:27:52 -07:00
sysctl_net.c