mirror of
https://github.com/torvalds/linux.git
synced 2024-11-19 02:21:47 +00:00
e08cfd4bda
Fix to find the correct (as much as possible) line information for listing probes. Without this fix, perf probe --list action will show incorrect line information as below; probe:getname_flags (on getname_flags@ksrc/linux-3/fs/namei.c) probe:getname_flags_1 (on getname:-89@x86/include/asm/current.h) probe:getname_flags_2 (on user_path_at_empty:-2054@x86/include/asm/current.h) The minus line number is obviously wrong, and current.h is not related to the probe point. Deeper investigation discovered that there were 2 issues related to this bug, and minor typos too. The 1st issue is the rack of considering about nested inlined functions, which causes the wrong (relative) line number. The 2nd issue is that the dwarf line info is not correct at those points. It points 14th line of current.h. Since it seems that the line info includes somewhat unreliable information, this fixes perf to try to find correct line information from both of debuginfo and line info as below. 1) Probe address is the entry of a function instance In this case, the line is set as the function declared line. 2) Probe address is the entry of an expanded inline function block In this case, the line is set as the function call-site line. This means that the line number is relative from the entry line of caller function (which can be an inlined function if nested) 3) Probe address is inside a function instance or an expanded inline function block In this case, perf probe queries the line number from lineinfo and verify the function declared file is same as the file name queried from lineinfo. If the file name is different, it is a failure case. The probe address is shown as symbol+offset. 4) Probe address is not in the any function instance This is a failure case, the probe address is shown as symbol+offset. With this fix, perf probe -l shows correct probe lines as below; probe:getname_flags (on getname_flags@ksrc/linux-3/fs/namei.c) probe:getname_flags_1 (on getname:2@ksrc/linux-3/fs/namei.c) probe:getname_flags_2 (on user_path_at_empty:4@ksrc/linux-3/fs/namei.c) Changes at v2: - Fix typos in the function comments. (Thanks to Namhyung Kim) - Use die_find_top_inlinefunc instead of die_find_inlinefunc_next. Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20130930092144.1693.11058.stgit@udc4-manage.rcp.hitachi.co.jp Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
119 lines
4.3 KiB
C
119 lines
4.3 KiB
C
#ifndef _DWARF_AUX_H
|
|
#define _DWARF_AUX_H
|
|
/*
|
|
* dwarf-aux.h : libdw auxiliary interfaces
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
|
|
*
|
|
*/
|
|
|
|
#include <dwarf.h>
|
|
#include <elfutils/libdw.h>
|
|
#include <elfutils/libdwfl.h>
|
|
#include <elfutils/version.h>
|
|
|
|
/* Find the realpath of the target file */
|
|
extern const char *cu_find_realpath(Dwarf_Die *cu_die, const char *fname);
|
|
|
|
/* Get DW_AT_comp_dir (should be NULL with older gcc) */
|
|
extern const char *cu_get_comp_dir(Dwarf_Die *cu_die);
|
|
|
|
/* Get a line number and file name for given address */
|
|
extern int cu_find_lineinfo(Dwarf_Die *cudie, unsigned long addr,
|
|
const char **fname, int *lineno);
|
|
|
|
/* Walk on funcitons at given address */
|
|
extern int cu_walk_functions_at(Dwarf_Die *cu_die, Dwarf_Addr addr,
|
|
int (*callback)(Dwarf_Die *, void *), void *data);
|
|
|
|
/* Ensure that this DIE is a subprogram and definition (not declaration) */
|
|
extern bool die_is_func_def(Dwarf_Die *dw_die);
|
|
|
|
/* Compare diename and tname */
|
|
extern bool die_compare_name(Dwarf_Die *dw_die, const char *tname);
|
|
|
|
/* Get callsite line number of inline-function instance */
|
|
extern int die_get_call_lineno(Dwarf_Die *in_die);
|
|
|
|
/* Get callsite file name of inlined function instance */
|
|
extern const char *die_get_call_file(Dwarf_Die *in_die);
|
|
|
|
/* Get type die */
|
|
extern Dwarf_Die *die_get_type(Dwarf_Die *vr_die, Dwarf_Die *die_mem);
|
|
|
|
/* Get a type die, but skip qualifiers and typedef */
|
|
extern Dwarf_Die *die_get_real_type(Dwarf_Die *vr_die, Dwarf_Die *die_mem);
|
|
|
|
/* Check whether the DIE is signed or not */
|
|
extern bool die_is_signed_type(Dwarf_Die *tp_die);
|
|
|
|
/* Get data_member_location offset */
|
|
extern int die_get_data_member_location(Dwarf_Die *mb_die, Dwarf_Word *offs);
|
|
|
|
/* Return values for die_find_child() callbacks */
|
|
enum {
|
|
DIE_FIND_CB_END = 0, /* End of Search */
|
|
DIE_FIND_CB_CHILD = 1, /* Search only children */
|
|
DIE_FIND_CB_SIBLING = 2, /* Search only siblings */
|
|
DIE_FIND_CB_CONTINUE = 3, /* Search children and siblings */
|
|
};
|
|
|
|
/* Search child DIEs */
|
|
extern Dwarf_Die *die_find_child(Dwarf_Die *rt_die,
|
|
int (*callback)(Dwarf_Die *, void *),
|
|
void *data, Dwarf_Die *die_mem);
|
|
|
|
/* Search a non-inlined function including given address */
|
|
extern Dwarf_Die *die_find_realfunc(Dwarf_Die *cu_die, Dwarf_Addr addr,
|
|
Dwarf_Die *die_mem);
|
|
|
|
/* Search the top inlined function including given address */
|
|
extern Dwarf_Die *die_find_top_inlinefunc(Dwarf_Die *sp_die, Dwarf_Addr addr,
|
|
Dwarf_Die *die_mem);
|
|
|
|
/* Search the deepest inlined function including given address */
|
|
extern Dwarf_Die *die_find_inlinefunc(Dwarf_Die *sp_die, Dwarf_Addr addr,
|
|
Dwarf_Die *die_mem);
|
|
|
|
/* Walk on the instances of given DIE */
|
|
extern int die_walk_instances(Dwarf_Die *in_die,
|
|
int (*callback)(Dwarf_Die *, void *), void *data);
|
|
|
|
/* Walker on lines (Note: line number will not be sorted) */
|
|
typedef int (* line_walk_callback_t) (const char *fname, int lineno,
|
|
Dwarf_Addr addr, void *data);
|
|
|
|
/*
|
|
* Walk on lines inside given DIE. If the DIE is a subprogram, walk only on
|
|
* the lines inside the subprogram, otherwise the DIE must be a CU DIE.
|
|
*/
|
|
extern int die_walk_lines(Dwarf_Die *rt_die, line_walk_callback_t callback,
|
|
void *data);
|
|
|
|
/* Find a variable called 'name' at given address */
|
|
extern Dwarf_Die *die_find_variable_at(Dwarf_Die *sp_die, const char *name,
|
|
Dwarf_Addr addr, Dwarf_Die *die_mem);
|
|
|
|
/* Find a member called 'name' */
|
|
extern Dwarf_Die *die_find_member(Dwarf_Die *st_die, const char *name,
|
|
Dwarf_Die *die_mem);
|
|
|
|
/* Get the name of given variable DIE */
|
|
extern int die_get_typename(Dwarf_Die *vr_die, char *buf, int len);
|
|
|
|
/* Get the name and type of given variable DIE, stored as "type\tname" */
|
|
extern int die_get_varname(Dwarf_Die *vr_die, char *buf, int len);
|
|
#endif
|