mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 13:22:23 +00:00
852f71942c
John Stultz reported that commitf9288fcc5c
("i2c: designware: Move ACPI parts into common module") caused a regression on the HiKey board where adv7511 HDMI bridge driver wasn't probing anymore due the I2C bus failed to start. It seems the change caused the bus speed being zero when CONFIG_ACPI not set and neither speed based on "clock-frequency" device property or default fast mode is set. Fix this by splitting i2c_dw_acpi_adjust_bus_speed() to i2c_dw_acpi_round_bus_speed() and i2c_dw_adjust_bus_speed(), where the latter one has the code that runs independently of ACPI. Fixes:f9288fcc5c
("i2c: designware: Move ACPI parts into common module") Reported-by: John Stultz <john.stultz@linaro.org> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Tested-by: John Stultz <john.stultz@linaro.org> Signed-off-by: Wolfram Sang <wsa@kernel.org>
359 lines
8.3 KiB
C
359 lines
8.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Synopsys DesignWare I2C adapter driver (master only).
|
|
*
|
|
* Based on the TI DAVINCI I2C adapter driver.
|
|
*
|
|
* Copyright (C) 2006 Texas Instruments.
|
|
* Copyright (C) 2007 MontaVista Software Inc.
|
|
* Copyright (C) 2009 Provigent Ltd.
|
|
* Copyright (C) 2011, 2015, 2016 Intel Corporation.
|
|
*/
|
|
#include <linux/acpi.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/err.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/io.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "i2c-designware-core.h"
|
|
|
|
#define DRIVER_NAME "i2c-designware-pci"
|
|
|
|
enum dw_pci_ctl_id_t {
|
|
medfield,
|
|
merrifield,
|
|
baytrail,
|
|
cherrytrail,
|
|
haswell,
|
|
elkhartlake,
|
|
};
|
|
|
|
struct dw_scl_sda_cfg {
|
|
u32 ss_hcnt;
|
|
u32 fs_hcnt;
|
|
u32 ss_lcnt;
|
|
u32 fs_lcnt;
|
|
u32 sda_hold;
|
|
};
|
|
|
|
struct dw_pci_controller {
|
|
u32 bus_num;
|
|
u32 flags;
|
|
struct dw_scl_sda_cfg *scl_sda_cfg;
|
|
int (*setup)(struct pci_dev *pdev, struct dw_pci_controller *c);
|
|
u32 (*get_clk_rate_khz)(struct dw_i2c_dev *dev);
|
|
};
|
|
|
|
/* Merrifield HCNT/LCNT/SDA hold time */
|
|
static struct dw_scl_sda_cfg mrfld_config = {
|
|
.ss_hcnt = 0x2f8,
|
|
.fs_hcnt = 0x87,
|
|
.ss_lcnt = 0x37b,
|
|
.fs_lcnt = 0x10a,
|
|
};
|
|
|
|
/* BayTrail HCNT/LCNT/SDA hold time */
|
|
static struct dw_scl_sda_cfg byt_config = {
|
|
.ss_hcnt = 0x200,
|
|
.fs_hcnt = 0x55,
|
|
.ss_lcnt = 0x200,
|
|
.fs_lcnt = 0x99,
|
|
.sda_hold = 0x6,
|
|
};
|
|
|
|
/* Haswell HCNT/LCNT/SDA hold time */
|
|
static struct dw_scl_sda_cfg hsw_config = {
|
|
.ss_hcnt = 0x01b0,
|
|
.fs_hcnt = 0x48,
|
|
.ss_lcnt = 0x01fb,
|
|
.fs_lcnt = 0xa0,
|
|
.sda_hold = 0x9,
|
|
};
|
|
|
|
static u32 mfld_get_clk_rate_khz(struct dw_i2c_dev *dev)
|
|
{
|
|
return 25000;
|
|
}
|
|
|
|
static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
|
|
{
|
|
struct dw_i2c_dev *dev = dev_get_drvdata(&pdev->dev);
|
|
|
|
switch (pdev->device) {
|
|
case 0x0817:
|
|
dev->timings.bus_freq_hz = I2C_MAX_STANDARD_MODE_FREQ;
|
|
/* fall through */
|
|
case 0x0818:
|
|
case 0x0819:
|
|
c->bus_num = pdev->device - 0x817 + 3;
|
|
return 0;
|
|
case 0x082C:
|
|
case 0x082D:
|
|
case 0x082E:
|
|
c->bus_num = pdev->device - 0x82C + 0;
|
|
return 0;
|
|
}
|
|
return -ENODEV;
|
|
}
|
|
|
|
static int mrfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
|
|
{
|
|
/*
|
|
* On Intel Merrifield the user visible i2c buses are enumerated
|
|
* [1..7]. So, we add 1 to shift the default range. Besides that the
|
|
* first PCI slot provides 4 functions, that's why we have to add 0 to
|
|
* the first slot and 4 to the next one.
|
|
*/
|
|
switch (PCI_SLOT(pdev->devfn)) {
|
|
case 8:
|
|
c->bus_num = PCI_FUNC(pdev->devfn) + 0 + 1;
|
|
return 0;
|
|
case 9:
|
|
c->bus_num = PCI_FUNC(pdev->devfn) + 4 + 1;
|
|
return 0;
|
|
}
|
|
return -ENODEV;
|
|
}
|
|
|
|
static u32 ehl_get_clk_rate_khz(struct dw_i2c_dev *dev)
|
|
{
|
|
return 100000;
|
|
}
|
|
|
|
static struct dw_pci_controller dw_pci_controllers[] = {
|
|
[medfield] = {
|
|
.bus_num = -1,
|
|
.setup = mfld_setup,
|
|
.get_clk_rate_khz = mfld_get_clk_rate_khz,
|
|
},
|
|
[merrifield] = {
|
|
.bus_num = -1,
|
|
.scl_sda_cfg = &mrfld_config,
|
|
.setup = mrfld_setup,
|
|
},
|
|
[baytrail] = {
|
|
.bus_num = -1,
|
|
.scl_sda_cfg = &byt_config,
|
|
},
|
|
[haswell] = {
|
|
.bus_num = -1,
|
|
.scl_sda_cfg = &hsw_config,
|
|
},
|
|
[cherrytrail] = {
|
|
.bus_num = -1,
|
|
.scl_sda_cfg = &byt_config,
|
|
},
|
|
[elkhartlake] = {
|
|
.bus_num = -1,
|
|
.get_clk_rate_khz = ehl_get_clk_rate_khz,
|
|
},
|
|
};
|
|
|
|
#ifdef CONFIG_PM
|
|
static int i2c_dw_pci_suspend(struct device *dev)
|
|
{
|
|
struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
|
|
|
|
i_dev->suspended = true;
|
|
i_dev->disable(i_dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int i2c_dw_pci_resume(struct device *dev)
|
|
{
|
|
struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
|
|
int ret;
|
|
|
|
ret = i_dev->init(i_dev);
|
|
i_dev->suspended = false;
|
|
|
|
return ret;
|
|
}
|
|
#endif
|
|
|
|
static UNIVERSAL_DEV_PM_OPS(i2c_dw_pm_ops, i2c_dw_pci_suspend,
|
|
i2c_dw_pci_resume, NULL);
|
|
|
|
static int i2c_dw_pci_probe(struct pci_dev *pdev,
|
|
const struct pci_device_id *id)
|
|
{
|
|
struct dw_i2c_dev *dev;
|
|
struct i2c_adapter *adap;
|
|
int r;
|
|
struct dw_pci_controller *controller;
|
|
struct dw_scl_sda_cfg *cfg;
|
|
|
|
if (id->driver_data >= ARRAY_SIZE(dw_pci_controllers)) {
|
|
dev_err(&pdev->dev, "%s: invalid driver data %ld\n", __func__,
|
|
id->driver_data);
|
|
return -EINVAL;
|
|
}
|
|
|
|
controller = &dw_pci_controllers[id->driver_data];
|
|
|
|
r = pcim_enable_device(pdev);
|
|
if (r) {
|
|
dev_err(&pdev->dev, "Failed to enable I2C PCI device (%d)\n",
|
|
r);
|
|
return r;
|
|
}
|
|
|
|
pci_set_master(pdev);
|
|
|
|
r = pcim_iomap_regions(pdev, 1 << 0, pci_name(pdev));
|
|
if (r) {
|
|
dev_err(&pdev->dev, "I/O memory remapping failed\n");
|
|
return r;
|
|
}
|
|
|
|
dev = devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev), GFP_KERNEL);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
|
|
r = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
dev->get_clk_rate_khz = controller->get_clk_rate_khz;
|
|
dev->timings.bus_freq_hz = I2C_MAX_FAST_MODE_FREQ;
|
|
dev->base = pcim_iomap_table(pdev)[0];
|
|
dev->dev = &pdev->dev;
|
|
dev->irq = pci_irq_vector(pdev, 0);
|
|
dev->flags |= controller->flags;
|
|
|
|
pci_set_drvdata(pdev, dev);
|
|
|
|
if (controller->setup) {
|
|
r = controller->setup(pdev, controller);
|
|
if (r) {
|
|
pci_free_irq_vectors(pdev);
|
|
return r;
|
|
}
|
|
}
|
|
|
|
i2c_dw_adjust_bus_speed(dev);
|
|
|
|
if (has_acpi_companion(&pdev->dev))
|
|
i2c_dw_acpi_configure(&pdev->dev);
|
|
|
|
r = i2c_dw_validate_speed(dev);
|
|
if (r) {
|
|
pci_free_irq_vectors(pdev);
|
|
return r;
|
|
}
|
|
|
|
i2c_dw_configure(dev);
|
|
|
|
if (controller->scl_sda_cfg) {
|
|
cfg = controller->scl_sda_cfg;
|
|
dev->ss_hcnt = cfg->ss_hcnt;
|
|
dev->fs_hcnt = cfg->fs_hcnt;
|
|
dev->ss_lcnt = cfg->ss_lcnt;
|
|
dev->fs_lcnt = cfg->fs_lcnt;
|
|
dev->sda_hold_time = cfg->sda_hold;
|
|
}
|
|
|
|
adap = &dev->adapter;
|
|
adap->owner = THIS_MODULE;
|
|
adap->class = 0;
|
|
ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
|
|
adap->nr = controller->bus_num;
|
|
|
|
r = i2c_dw_probe(dev);
|
|
if (r) {
|
|
pci_free_irq_vectors(pdev);
|
|
return r;
|
|
}
|
|
|
|
pm_runtime_set_autosuspend_delay(&pdev->dev, 1000);
|
|
pm_runtime_use_autosuspend(&pdev->dev);
|
|
pm_runtime_put_autosuspend(&pdev->dev);
|
|
pm_runtime_allow(&pdev->dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void i2c_dw_pci_remove(struct pci_dev *pdev)
|
|
{
|
|
struct dw_i2c_dev *dev = pci_get_drvdata(pdev);
|
|
|
|
dev->disable(dev);
|
|
pm_runtime_forbid(&pdev->dev);
|
|
pm_runtime_get_noresume(&pdev->dev);
|
|
|
|
i2c_del_adapter(&dev->adapter);
|
|
devm_free_irq(&pdev->dev, dev->irq, dev);
|
|
pci_free_irq_vectors(pdev);
|
|
}
|
|
|
|
/* work with hotplug and coldplug */
|
|
MODULE_ALIAS("i2c_designware-pci");
|
|
|
|
static const struct pci_device_id i2_designware_pci_ids[] = {
|
|
/* Medfield */
|
|
{ PCI_VDEVICE(INTEL, 0x0817), medfield },
|
|
{ PCI_VDEVICE(INTEL, 0x0818), medfield },
|
|
{ PCI_VDEVICE(INTEL, 0x0819), medfield },
|
|
{ PCI_VDEVICE(INTEL, 0x082C), medfield },
|
|
{ PCI_VDEVICE(INTEL, 0x082D), medfield },
|
|
{ PCI_VDEVICE(INTEL, 0x082E), medfield },
|
|
/* Merrifield */
|
|
{ PCI_VDEVICE(INTEL, 0x1195), merrifield },
|
|
{ PCI_VDEVICE(INTEL, 0x1196), merrifield },
|
|
/* Baytrail */
|
|
{ PCI_VDEVICE(INTEL, 0x0F41), baytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x0F42), baytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x0F43), baytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x0F44), baytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x0F45), baytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x0F46), baytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x0F47), baytrail },
|
|
/* Haswell */
|
|
{ PCI_VDEVICE(INTEL, 0x9c61), haswell },
|
|
{ PCI_VDEVICE(INTEL, 0x9c62), haswell },
|
|
/* Braswell / Cherrytrail */
|
|
{ PCI_VDEVICE(INTEL, 0x22C1), cherrytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x22C2), cherrytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x22C3), cherrytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x22C4), cherrytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x22C5), cherrytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x22C6), cherrytrail },
|
|
{ PCI_VDEVICE(INTEL, 0x22C7), cherrytrail },
|
|
/* Elkhart Lake (PSE I2C) */
|
|
{ PCI_VDEVICE(INTEL, 0x4bb9), elkhartlake },
|
|
{ PCI_VDEVICE(INTEL, 0x4bba), elkhartlake },
|
|
{ PCI_VDEVICE(INTEL, 0x4bbb), elkhartlake },
|
|
{ PCI_VDEVICE(INTEL, 0x4bbc), elkhartlake },
|
|
{ PCI_VDEVICE(INTEL, 0x4bbd), elkhartlake },
|
|
{ PCI_VDEVICE(INTEL, 0x4bbe), elkhartlake },
|
|
{ PCI_VDEVICE(INTEL, 0x4bbf), elkhartlake },
|
|
{ PCI_VDEVICE(INTEL, 0x4bc0), elkhartlake },
|
|
{ 0,}
|
|
};
|
|
MODULE_DEVICE_TABLE(pci, i2_designware_pci_ids);
|
|
|
|
static struct pci_driver dw_i2c_driver = {
|
|
.name = DRIVER_NAME,
|
|
.id_table = i2_designware_pci_ids,
|
|
.probe = i2c_dw_pci_probe,
|
|
.remove = i2c_dw_pci_remove,
|
|
.driver = {
|
|
.pm = &i2c_dw_pm_ops,
|
|
},
|
|
};
|
|
|
|
module_pci_driver(dw_i2c_driver);
|
|
|
|
MODULE_AUTHOR("Baruch Siach <baruch@tkos.co.il>");
|
|
MODULE_DESCRIPTION("Synopsys DesignWare PCI I2C bus adapter");
|
|
MODULE_LICENSE("GPL");
|