linux/sound/firewire
Andrey Shumilin 72cafe63b3 ALSA: firewire-lib: Avoid division by zero in apply_constraint_to_size()
The step variable is initialized to zero. It is changed in the loop,
but if it's not changed it will remain zero. Add a variable check
before the division.

The observed behavior was introduced by commit 826b5de90c
("ALSA: firewire-lib: fix insufficient PCM rule for period/buffer size"),
and it is difficult to show that any of the interval parameters will
satisfy the snd_interval_test() condition with data from the
amdtp_rate_table[] table.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 826b5de90c ("ALSA: firewire-lib: fix insufficient PCM rule for period/buffer size")
Signed-off-by: Andrey Shumilin <shum.sdl@nppct.ru>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://patch.msgid.link/20241018060018.1189537-1-shum.sdl@nppct.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2024-10-21 09:09:21 +02:00
..
bebob ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
dice ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
digi00x ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
fireface ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
fireworks ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
motu ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
oxfw ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
tascam ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
amdtp-am824.c ALSA: firewire-lib: obsolete return value from context payload processing layer 2023-01-12 12:14:50 +01:00
amdtp-am824.h ALSA: firewire-lib/motu: use int type for the value of bitwise OR with enumerator-constant 2021-05-18 12:21:52 +02:00
amdtp-stream-trace.h ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI 2023-01-10 09:34:47 +01:00
amdtp-stream.c ALSA: firewire-lib: Avoid division by zero in apply_constraint_to_size() 2024-10-21 09:09:21 +02:00
amdtp-stream.h Revert "ALSA: firewire-lib: obsolete workqueue for period update" 2024-07-31 11:28:13 +02:00
cmp.c ALSA: firewire: fix kernel-doc 2020-07-07 12:09:32 +02:00
cmp.h ALSA: firewire-lib: split allocation of isochronous resources from establishment of connection 2019-06-17 08:18:36 +02:00
fcp.c ALSA: firewire-lib: fix uninitialized flag for AV/C deferred transaction 2022-03-04 17:23:21 +01:00
fcp.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
isight.c ALSA: firewire: use nonatomic PCM operation 2024-09-04 21:51:54 +09:00
iso-resources.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
iso-resources.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
Kconfig ALSA: firewire-motu: add support for MOTU 896 mk3 FireWire and Hybrid 2024-01-29 09:04:30 +01:00
lib.c ALSA: firewire: use 'GPL' string for module license contributed by Clemens Ladisch 2023-06-12 14:39:00 +02:00
lib.h ALSA: firewire-lib: delete unused kernel API 2021-06-07 17:14:54 +02:00
Makefile ALSA: firewire: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:03 +02:00
packets-buffer.c ALSA: firewire: fix a memory leak bug 2019-08-08 11:12:26 +02:00
packets-buffer.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00