mirror of
https://github.com/torvalds/linux.git
synced 2024-11-11 06:31:49 +00:00
c4c34d5ded
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Link: https://lore.kernel.org/r/20230303172041.2103336-15-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
43 lines
1008 B
C
43 lines
1008 B
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright 2016 Broadcom
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/of.h>
|
|
#include "spi-bcm-qspi.h"
|
|
|
|
static const struct of_device_id brcmstb_qspi_of_match[] = {
|
|
{ .compatible = "brcm,spi-brcmstb-qspi" },
|
|
{ .compatible = "brcm,spi-brcmstb-mspi" },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, brcmstb_qspi_of_match);
|
|
|
|
static int brcmstb_qspi_probe(struct platform_device *pdev)
|
|
{
|
|
return bcm_qspi_probe(pdev, NULL);
|
|
}
|
|
|
|
static void brcmstb_qspi_remove(struct platform_device *pdev)
|
|
{
|
|
bcm_qspi_remove(pdev);
|
|
}
|
|
|
|
static struct platform_driver brcmstb_qspi_driver = {
|
|
.probe = brcmstb_qspi_probe,
|
|
.remove_new = brcmstb_qspi_remove,
|
|
.driver = {
|
|
.name = "brcmstb_qspi",
|
|
.pm = &bcm_qspi_pm_ops,
|
|
.of_match_table = brcmstb_qspi_of_match,
|
|
}
|
|
};
|
|
module_platform_driver(brcmstb_qspi_driver);
|
|
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_AUTHOR("Kamal Dasu");
|
|
MODULE_DESCRIPTION("Broadcom SPI driver for settop SoC");
|