mirror of
https://github.com/torvalds/linux.git
synced 2024-11-11 06:31:49 +00:00
9b174527e7
In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules that get called are loadable and the core is built-in. In that case we get drivers/built-in.o: In function `set_type': drivers/media/v4l2-core/tuner-core.c:301: undefined reference to `tea5767_attach' drivers/media/v4l2-core/tuner-core.c:307: undefined reference to `tea5761_attach' drivers/media/v4l2-core/tuner-core.c:349: undefined reference to `tda9887_attach' drivers/media/v4l2-core/tuner-core.c:405: undefined reference to `xc4000_attach' This was working previously, until the IS_ENABLED() macro was used to replace the construct like #if defined(CONFIG_DVB_CX24110) || (defined(CONFIG_DVB_CX24110_MODULE) && defined(MODULE)) with the difference that the new code no longer checks whether it is being built as a loadable module itself. To fix this, this new patch adds an 'IS_REACHABLE' macro, which evaluates true in exactly the condition that was used previously. The downside of this is that this trades an obvious link error for a more subtle runtime failure, but it is clear that the change that introduced the link error was unintentional and it seems better to revert it for now. Also, a similar change was originally created by Trent Piepho and then reverted by teh change to the IS_ENABLED macro. Ideally Kconfig would be used to avoid the case of a broken dependency, or the code restructured in a way to turn around the dependency, but either way would require much larger changes here. Fixes:7b34be71db("[media] use IS_ENABLED() macro") See-also:c5dec9fb24("V4L/DVB (4751): Fix DBV_FE_CUSTOMISE for card drivers compiled into kernel") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
132 lines
4.3 KiB
C
132 lines
4.3 KiB
C
#ifndef DIB9000_H
|
|
#define DIB9000_H
|
|
|
|
#include "dibx000_common.h"
|
|
|
|
struct dib9000_config {
|
|
u8 dvbt_mode;
|
|
u8 output_mpeg2_in_188_bytes;
|
|
u8 hostbus_diversity;
|
|
struct dibx000_bandwidth_config *bw;
|
|
|
|
u16 if_drives;
|
|
|
|
u32 timing_frequency;
|
|
u32 xtal_clock_khz;
|
|
u32 vcxo_timer;
|
|
u32 demod_clock_khz;
|
|
|
|
const u8 *microcode_B_fe_buffer;
|
|
u32 microcode_B_fe_size;
|
|
|
|
struct dibGPIOFunction gpio_function[2];
|
|
struct dibSubbandSelection subband;
|
|
|
|
u8 output_mode;
|
|
};
|
|
|
|
#define DEFAULT_DIB9000_I2C_ADDRESS 18
|
|
|
|
#if IS_REACHABLE(CONFIG_DVB_DIB9000)
|
|
extern struct dvb_frontend *dib9000_attach(struct i2c_adapter *i2c_adap, u8 i2c_addr, const struct dib9000_config *cfg);
|
|
extern int dib9000_i2c_enumeration(struct i2c_adapter *host, int no_of_demods, u8 default_addr, u8 first_addr);
|
|
extern struct i2c_adapter *dib9000_get_tuner_interface(struct dvb_frontend *fe);
|
|
extern struct i2c_adapter *dib9000_get_i2c_master(struct dvb_frontend *fe, enum dibx000_i2c_interface intf, int gating);
|
|
extern int dib9000_set_gpio(struct dvb_frontend *fe, u8 num, u8 dir, u8 val);
|
|
extern int dib9000_fw_pid_filter_ctrl(struct dvb_frontend *fe, u8 onoff);
|
|
extern int dib9000_fw_pid_filter(struct dvb_frontend *fe, u8 id, u16 pid, u8 onoff);
|
|
extern int dib9000_firmware_post_pll_init(struct dvb_frontend *fe);
|
|
extern int dib9000_set_slave_frontend(struct dvb_frontend *fe, struct dvb_frontend *fe_slave);
|
|
extern int dib9000_remove_slave_frontend(struct dvb_frontend *fe);
|
|
extern struct dvb_frontend *dib9000_get_slave_frontend(struct dvb_frontend *fe, int slave_index);
|
|
extern struct i2c_adapter *dib9000_get_component_bus_interface(struct dvb_frontend *fe);
|
|
extern int dib9000_set_i2c_adapter(struct dvb_frontend *fe, struct i2c_adapter *i2c);
|
|
extern int dib9000_fw_set_component_bus_speed(struct dvb_frontend *fe, u16 speed);
|
|
#else
|
|
static inline struct dvb_frontend *dib9000_attach(struct i2c_adapter *i2c_adap, u8 i2c_addr, struct dib9000_config *cfg)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
|
|
static inline struct i2c_adapter *dib9000_get_i2c_master(struct dvb_frontend *fe, enum dibx000_i2c_interface intf, int gating)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
|
|
static inline int dib9000_i2c_enumeration(struct i2c_adapter *host, int no_of_demods, u8 default_addr, u8 first_addr)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline struct i2c_adapter *dib9000_get_tuner_interface(struct dvb_frontend *fe)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
|
|
static inline int dib9000_set_gpio(struct dvb_frontend *fe, u8 num, u8 dir, u8 val)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int dib9000_fw_pid_filter_ctrl(struct dvb_frontend *fe, u8 onoff)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int dib9000_fw_pid_filter(struct dvb_frontend *fe, u8 id, u16 pid, u8 onoff)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int dib9000_firmware_post_pll_init(struct dvb_frontend *fe)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int dib9000_set_slave_frontend(struct dvb_frontend *fe, struct dvb_frontend *fe_slave)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int dib9000_remove_slave_frontend(struct dvb_frontend *fe)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline struct dvb_frontend *dib9000_get_slave_frontend(struct dvb_frontend *fe, int slave_index)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
|
|
static inline struct i2c_adapter *dib9000_get_component_bus_interface(struct dvb_frontend *fe)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
|
|
static inline int dib9000_set_i2c_adapter(struct dvb_frontend *fe, struct i2c_adapter *i2c)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int dib9000_fw_set_component_bus_speed(struct dvb_frontend *fe, u16 speed)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
|
|
#endif
|