mirror of
https://github.com/torvalds/linux.git
synced 2024-11-14 16:12:02 +00:00
9d957a959b
During suspend/resume, mtk_eint_mask may be called while
wake_mask is active. For example, this happens if a wake-source
with an active interrupt handler wakes the system:
irq/pm.c:irq_pm_check_wakeup would disable the interrupt, so
that it can be handled later on in the resume flow.
However, this may happen before mtk_eint_do_resume is called:
in this case, wake_mask is loaded, and cur_mask is restored
from an older copy, re-enabling the interrupt, and causing
an interrupt storm (especially for level interrupts).
Step by step, for a line that has both wake and interrupt enabled:
1. cur_mask[irq] = 1; wake_mask[irq] = 1; EINT_EN[irq] = 1 (interrupt
enabled at hardware level)
2. System suspends, resumes due to that line (at this stage EINT_EN
== wake_mask)
3. irq_pm_check_wakeup is called, and disables the interrupt =>
EINT_EN[irq] = 0, but we still have cur_mask[irq] = 1
4. mtk_eint_do_resume is called, and restores EINT_EN = cur_mask, so
it reenables EINT_EN[irq] = 1 => interrupt storm as the driver
is not yet ready to handle the interrupt.
This patch fixes the issue in step 3, by recording all mask/unmask
changes in cur_mask. This also avoids the need to read the current
mask in eint_do_suspend, and we can remove mtk_eint_chip_read_mask
function.
The interrupt will be re-enabled properly later on, sometimes after
mtk_eint_do_resume, when the driver is ready to handle it.
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| mtk-eint.c | ||
| mtk-eint.h | ||
| pinctrl-moore.c | ||
| pinctrl-moore.h | ||
| pinctrl-mt2701.c | ||
| pinctrl-mt2712.c | ||
| pinctrl-mt6397.c | ||
| pinctrl-mt6765.c | ||
| pinctrl-mt6797.c | ||
| pinctrl-mt7622.c | ||
| pinctrl-mt7623.c | ||
| pinctrl-mt7629.c | ||
| pinctrl-mt8127.c | ||
| pinctrl-mt8135.c | ||
| pinctrl-mt8173.c | ||
| pinctrl-mt8183.c | ||
| pinctrl-mt8516.c | ||
| pinctrl-mtk-common-v2.c | ||
| pinctrl-mtk-common-v2.h | ||
| pinctrl-mtk-common.c | ||
| pinctrl-mtk-common.h | ||
| pinctrl-mtk-mt2701.h | ||
| pinctrl-mtk-mt2712.h | ||
| pinctrl-mtk-mt6397.h | ||
| pinctrl-mtk-mt6765.h | ||
| pinctrl-mtk-mt6797.h | ||
| pinctrl-mtk-mt8127.h | ||
| pinctrl-mtk-mt8135.h | ||
| pinctrl-mtk-mt8173.h | ||
| pinctrl-mtk-mt8183.h | ||
| pinctrl-mtk-mt8516.h | ||
| pinctrl-paris.c | ||
| pinctrl-paris.h | ||