mirror of
https://github.com/torvalds/linux.git
synced 2024-11-15 08:31:55 +00:00
25c8a78b1e
The recent merge of fpu.S broken the handling of fpscr for ARCH=powerpc and CONFIG_PPC64=y. FP registers could be corrupted, leading to strange random application crashes. The confusion arises, because the thread_struct has (and requires) a 64-bit area to save the fpscr, because we use load/store double instructions to get it in to/out of the FPU. However, only the low 32-bits are actually used, so we want to treat it as a 32-bit quantity when manipulating its bits to avoid extra load/stores on 32-bit. This patch replaces the current definition with a structure of two 32-bit quantities (pad and val), to clarify things as much as is possible. The 'val' field is used when manipulating bits, the structure itself is used when obtaining the address for loading/unloading the value from the FPU. While we're at it, consolidate the 4 (!) almost identical versions of cvt_fd() and cvt_df() (arch/ppc/kernel/misc.S, arch/ppc64/kernel/misc.S, arch/powerpc/kernel/misc_32.S, arch/powerpc/kernel/misc_64.S) into a single version in fpu.S. The new version takes a pointer to thread_struct and applies the correct offset itself, rather than a pointer to the fpscr field itself, again to avoid confusion as to which is the correct field to use. Finally, this patch makes ARCH=ppc64 also use the consolidated fpu.S code, which it previously did not. Built for G5 (ARCH=ppc64 and ARCH=powerpc), 32-bit powermac (ARCH=ppc and ARCH=powerpc) and Walnut (ARCH=ppc, CONFIG_MATH_EMULATION=y). Booted on G5 (ARCH=powerpc) and things which previously fell over no longer do. Signed-off-by: David Gibson <dwg@au1.ibm.com> Signed-off-by: Paul Mackerras <paulus@samba.org> |
||
|---|---|---|
| .. | ||
| double.h | ||
| fabs.c | ||
| fadd.c | ||
| fadds.c | ||
| fcmpo.c | ||
| fcmpu.c | ||
| fctiw.c | ||
| fctiwz.c | ||
| fdiv.c | ||
| fdivs.c | ||
| fmadd.c | ||
| fmadds.c | ||
| fmr.c | ||
| fmsub.c | ||
| fmsubs.c | ||
| fmul.c | ||
| fmuls.c | ||
| fnabs.c | ||
| fneg.c | ||
| fnmadd.c | ||
| fnmadds.c | ||
| fnmsub.c | ||
| fnmsubs.c | ||
| fres.c | ||
| frsp.c | ||
| frsqrte.c | ||
| fsel.c | ||
| fsqrt.c | ||
| fsqrts.c | ||
| fsub.c | ||
| fsubs.c | ||
| lfd.c | ||
| lfs.c | ||
| Makefile | ||
| math.c | ||
| mcrfs.c | ||
| mffs.c | ||
| mtfsb0.c | ||
| mtfsb1.c | ||
| mtfsf.c | ||
| mtfsfi.c | ||
| op-1.h | ||
| op-2.h | ||
| op-4.h | ||
| op-common.h | ||
| sfp-machine.h | ||
| single.h | ||
| soft-fp.h | ||
| stfd.c | ||
| stfiwx.c | ||
| stfs.c | ||
| types.c | ||
| udivmodti4.c | ||