linux/drivers/message/i2o
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
bus-osm.c [PATCH] kernel-doc: fix fusion and i2o docs 2006-12-07 08:39:40 -08:00
config-osm.c [PATCH] I2O: Optimizing 2006-01-06 08:33:54 -08:00
core.h [PATCH] i2o_exec_exit and i2o_driver_exit should not be __exit. 2006-12-13 09:05:47 -08:00
debug.c i2o debug output cleanup 2007-07-17 10:23:06 -07:00
device.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6 2009-01-06 17:02:07 -08:00
driver.c i2o: remove extraneous kernel-doc 2009-01-06 15:59:21 -08:00
exec-osm.c i2o: Update my address 2009-01-05 18:28:04 -08:00
i2o_block.c Fix incorrect use of loose in i2o_block.c 2008-12-05 13:40:52 -08:00
i2o_block.h [PATCH] slab: remove kmem_cache_t 2006-12-07 08:39:25 -08:00
i2o_config.c i2o: Update my address 2009-01-05 18:28:04 -08:00
i2o_proc.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
i2o_scsi.c trivial: fix then -> than typos in comments and documentation 2009-01-06 11:28:06 +01:00
iop.c i2o: struct device - replace bus_id with dev_name(), dev_set_name() 2009-01-06 10:44:40 -08:00
Kconfig Introduce CONFIG_VIRT_TO_BUS 2007-07-16 09:05:42 -07:00
Makefile i2o: Fix 32/64bit DMA locking 2008-10-16 11:21:38 -07:00
memory.c i2o: Fix 32/64bit DMA locking 2008-10-16 11:21:38 -07:00
pci.c i2o: Update my address 2009-01-05 18:28:04 -08:00
README Convert files to UTF-8 and some cleanups 2007-10-19 23:21:04 +02:00
README.ioctl spelling: s/retreive/retrieve/ 2006-01-10 00:10:13 +01:00

	Linux I2O Support	(c) Copyright 1999 Red Hat Software
					and others.

	This program is free software; you can redistribute it and/or
	modify it under the terms of the GNU General Public License
	as published by the Free Software Foundation; either version
	2 of the License, or (at your option) any later version.

AUTHORS (so far)

Alan Cox, Building Number Three Ltd.
	Core code, SCSI and Block OSMs

Steve Ralston, LSI Logic Corp.
	Debugging SCSI and Block OSM

Deepak Saxena, Intel Corp.
	Various core/block extensions
	/proc interface, bug fixes
	Ioctl interfaces for control
	Debugging LAN OSM

Philip Rumpf
	Fixed assorted dumb SMP locking bugs

Juha Sievanen, University of Helsinki Finland
	LAN OSM code
	/proc interface to LAN class
	Bug fixes
	Core code extensions

Auvo Häkkinen, University of Helsinki Finland
	LAN OSM code
	/Proc interface to LAN class
	Bug fixes
	Core code extensions

Taneli Vähäkangas, University of Helsinki Finland
	Fixes to i2o_config

CREDITS

	This work was made possible by 

Red Hat Software
	Funding for the Building #3 part of the project

Symbios Logic (Now LSI)
	Host adapters, hints, known to work platforms when I hit
	compatibility problems

BoxHill Corporation
	Loan of initial FibreChannel disk array used for development work.

European Comission
	Funding the work done by the University of Helsinki

SysKonnect
        Loan of FDDI and Gigabit Ethernet cards

ASUSTeK
        Loan of I2O motherboard 

STATUS:

o	The core setup works within limits.
o	The scsi layer seems to almost work. 
           I'm still chasing down the hang bug.
o	The block OSM is mostly functional
o	LAN OSM works with FDDI and Ethernet cards.

TO DO:

General:
o	Provide hidden address space if asked
o	Long term message flow control
o	PCI IOP's without interrupts are not supported yet
o	Push FAIL handling into the core
o	DDM control interfaces for module load etc
o       Add I2O 2.0 support (Deffered to 2.5 kernel)

Block:
o	Multiple major numbers
o	Read ahead and cache handling stuff. Talk to Ingo and people
o	Power management
o	Finish Media changers

SCSI:
o	Find the right way to associate drives/luns/busses

Lan:	
o	Performance tuning
o	Test Fibre Channel code

Tape:
o	Anyone seen anything implementing this ?
           (D.S: Will attempt to do so if spare cycles permit)