linux/arch
Thomas Gleixner c08b8a4910 [PATCH] sys_alarm() unsigned signed conversion fixup
alarm() calls the kernel with an unsigend int timeout in seconds.  The
value is stored in the tv_sec field of a struct timeval to setup the
itimer.  The tv_sec field of struct timeval is of type long, which causes
the tv_sec value to be negative on 32 bit machines if seconds > INT_MAX.

Before the hrtimer merge (pre 2.6.16) such a negative value was converted
to the maximum jiffies timeout by the timeval_to_jiffies conversion.  It's
not clear whether this was intended or just happened to be done by the
timeval_to_jiffies code.

hrtimers expect a timeval in canonical form and treat a negative timeout as
already expired.  This breaks the legitimate usage of alarm() with a
timeout value > INT_MAX seconds.

For 32 bit machines it is therefor necessary to limit the internal seconds
value to avoid API breakage.  Instead of doing this in all implementations
of sys_alarm the duplicated sys_alarm code is moved into a common function
in itimer.c

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-03-25 08:22:48 -08:00
..
alpha [PATCH] remove set_page_count() outside mm/ 2006-03-22 07:54:02 -08:00
arm [PATCH] s/;;/;/g 2006-03-24 07:33:24 -08:00
arm26 [PATCH] remove set_page_count() outside mm/ 2006-03-22 07:54:02 -08:00
cris [PATCH] set_page_dirty() return value fixes 2006-03-24 07:33:26 -08:00
frv [PATCH] s/;;/;/g 2006-03-24 07:33:24 -08:00
h8300 [PATCH] kill include/linux/platform.h, default_idle() cleanup 2006-03-24 07:33:21 -08:00
i386 [PATCH] fix DMI onboard device discovery 2006-03-25 08:22:48 -08:00
ia64 [PATCH] sys_alarm() unsigned signed conversion fixup 2006-03-25 08:22:48 -08:00
m32r [PATCH] more for_each_cpu() conversions 2006-03-23 07:38:17 -08:00
m68k [PATCH] kill include/linux/platform.h, default_idle() cleanup 2006-03-24 07:33:21 -08:00
m68knommu [PATCH] kill include/linux/platform.h, default_idle() cleanup 2006-03-24 07:33:21 -08:00
mips [PATCH] sys_alarm() unsigned signed conversion fixup 2006-03-25 08:22:48 -08:00
parisc [PATCH] kill include/linux/platform.h, default_idle() cleanup 2006-03-24 07:33:21 -08:00
powerpc [PATCH] more for_each_cpu() conversions 2006-03-23 07:38:17 -08:00
ppc [PATCH] s/;;/;/g 2006-03-24 07:33:24 -08:00
s390 [PATCH] kill include/linux/platform.h, default_idle() cleanup 2006-03-24 07:33:21 -08:00
sh [PATCH] kill include/linux/platform.h, default_idle() cleanup 2006-03-24 07:33:21 -08:00
sh64 [PATCH] more for_each_cpu() conversions 2006-03-23 07:38:17 -08:00
sparc [PATCH] more for_each_cpu() conversions 2006-03-23 07:38:17 -08:00
sparc64 [PATCH] s/;;/;/g 2006-03-24 07:33:24 -08:00
um [PATCH] x86: SMP alternatives 2006-03-23 07:38:04 -08:00
v850 [PATCH] kill include/linux/platform.h, default_idle() cleanup 2006-03-24 07:33:21 -08:00
x86_64 [PATCH] sys_alarm() unsigned signed conversion fixup 2006-03-25 08:22:48 -08:00
xtensa [PATCH] more for_each_cpu() conversions 2006-03-23 07:38:17 -08:00