mirror of
https://github.com/torvalds/linux.git
synced 2024-11-15 16:41:58 +00:00
1be9131453
This patch fixes following (similar) warning reported by kbuild test robot:
In function ‘memcpy’,
inlined from ‘smsc75xx_init_mac_address’ at drivers/net/usb/smsc75xx.c:778:3,
inlined from ‘smsc75xx_bind’ at drivers/net/usb/smsc75xx.c:1501:2:
./include/linux/string.h:355:9: warning: argument 2 null where non-null expected [-Wnonnull]
return __builtin_memcpy(p, q, size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/usb/smsc75xx.c: In function ‘smsc75xx_bind’:
./include/linux/string.h:355:9: note: in a call to built-in function ‘__builtin_memcpy’
I've replaced the offending memcpy with ether_addr_copy, because I'm
100% sure, that of_get_mac_address can't return NULL as it returns valid
pointer or ERR_PTR encoded value, nothing else.
I'm hesitant to just change IS_ERR into IS_ERR_OR_NULL check, as this
would make the warning disappear also, but it would be confusing to
check for impossible return value just to make a compiler happy.
I'm now changing all occurencies of memcpy to ether_addr_copy after the
of_get_mac_address call, as it's very likely, that we're going to get
similar reports from kbuild test robot in the future.
Fixes: ea168cdf12
("powerpc: tsi108: support of_get_mac_address new ERR_PTR error")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
161 lines
3.8 KiB
C
161 lines
3.8 KiB
C
/*
|
|
* tsi108/109 device setup code
|
|
*
|
|
* Maintained by Roy Zang < tie-fei.zang@freescale.com >
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*/
|
|
|
|
#include <linux/stddef.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/major.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/export.h>
|
|
#include <linux/device.h>
|
|
#include <linux/etherdevice.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/of_net.h>
|
|
#include <asm/tsi108.h>
|
|
|
|
#include <linux/atomic.h>
|
|
#include <asm/io.h>
|
|
#include <asm/irq.h>
|
|
#include <asm/prom.h>
|
|
#include <mm/mmu_decl.h>
|
|
|
|
#undef DEBUG
|
|
|
|
#ifdef DEBUG
|
|
#define DBG(fmt...) do { printk(fmt); } while(0)
|
|
#else
|
|
#define DBG(fmt...) do { } while(0)
|
|
#endif
|
|
|
|
static phys_addr_t tsi108_csr_base = -1;
|
|
|
|
phys_addr_t get_csrbase(void)
|
|
{
|
|
struct device_node *tsi;
|
|
|
|
if (tsi108_csr_base != -1)
|
|
return tsi108_csr_base;
|
|
|
|
tsi = of_find_node_by_type(NULL, "tsi-bridge");
|
|
if (tsi) {
|
|
unsigned int size;
|
|
const void *prop = of_get_property(tsi, "reg", &size);
|
|
tsi108_csr_base = of_translate_address(tsi, prop);
|
|
of_node_put(tsi);
|
|
}
|
|
return tsi108_csr_base;
|
|
}
|
|
|
|
u32 get_vir_csrbase(void)
|
|
{
|
|
return (u32) (ioremap(get_csrbase(), 0x10000));
|
|
}
|
|
|
|
EXPORT_SYMBOL(get_csrbase);
|
|
EXPORT_SYMBOL(get_vir_csrbase);
|
|
|
|
static int __init tsi108_eth_of_init(void)
|
|
{
|
|
struct device_node *np;
|
|
unsigned int i = 0;
|
|
struct platform_device *tsi_eth_dev;
|
|
struct resource res;
|
|
int ret;
|
|
|
|
for_each_compatible_node(np, "network", "tsi108-ethernet") {
|
|
struct resource r[2];
|
|
struct device_node *phy, *mdio;
|
|
hw_info tsi_eth_data;
|
|
const unsigned int *phy_id;
|
|
const void *mac_addr;
|
|
const phandle *ph;
|
|
|
|
memset(r, 0, sizeof(r));
|
|
memset(&tsi_eth_data, 0, sizeof(tsi_eth_data));
|
|
|
|
ret = of_address_to_resource(np, 0, &r[0]);
|
|
DBG("%s: name:start->end = %s:%pR\n",
|
|
__func__, r[0].name, &r[0]);
|
|
if (ret)
|
|
goto err;
|
|
|
|
r[1].name = "tx";
|
|
r[1].start = irq_of_parse_and_map(np, 0);
|
|
r[1].end = irq_of_parse_and_map(np, 0);
|
|
r[1].flags = IORESOURCE_IRQ;
|
|
DBG("%s: name:start->end = %s:%pR\n",
|
|
__func__, r[1].name, &r[1]);
|
|
|
|
tsi_eth_dev =
|
|
platform_device_register_simple("tsi-ethernet", i++, &r[0],
|
|
1);
|
|
|
|
if (IS_ERR(tsi_eth_dev)) {
|
|
ret = PTR_ERR(tsi_eth_dev);
|
|
goto err;
|
|
}
|
|
|
|
mac_addr = of_get_mac_address(np);
|
|
if (!IS_ERR(mac_addr))
|
|
ether_addr_copy(tsi_eth_data.mac_addr, mac_addr);
|
|
|
|
ph = of_get_property(np, "mdio-handle", NULL);
|
|
mdio = of_find_node_by_phandle(*ph);
|
|
ret = of_address_to_resource(mdio, 0, &res);
|
|
of_node_put(mdio);
|
|
if (ret)
|
|
goto unreg;
|
|
|
|
ph = of_get_property(np, "phy-handle", NULL);
|
|
phy = of_find_node_by_phandle(*ph);
|
|
|
|
if (phy == NULL) {
|
|
ret = -ENODEV;
|
|
goto unreg;
|
|
}
|
|
|
|
phy_id = of_get_property(phy, "reg", NULL);
|
|
|
|
tsi_eth_data.regs = r[0].start;
|
|
tsi_eth_data.phyregs = res.start;
|
|
tsi_eth_data.phy = *phy_id;
|
|
tsi_eth_data.irq_num = irq_of_parse_and_map(np, 0);
|
|
|
|
/* Some boards with the TSI108 bridge (e.g. Holly)
|
|
* have a miswiring of the ethernet PHYs which
|
|
* requires a workaround. The special
|
|
* "txc-rxc-delay-disable" property enables this
|
|
* workaround. FIXME: Need to port the tsi108_eth
|
|
* driver itself to phylib and use a non-misleading
|
|
* name for the workaround flag - it's not actually to
|
|
* do with the model of PHY in use */
|
|
if (of_get_property(phy, "txc-rxc-delay-disable", NULL))
|
|
tsi_eth_data.phy_type = TSI108_PHY_BCM54XX;
|
|
of_node_put(phy);
|
|
|
|
ret =
|
|
platform_device_add_data(tsi_eth_dev, &tsi_eth_data,
|
|
sizeof(hw_info));
|
|
if (ret)
|
|
goto unreg;
|
|
}
|
|
return 0;
|
|
unreg:
|
|
platform_device_unregister(tsi_eth_dev);
|
|
err:
|
|
of_node_put(np);
|
|
return ret;
|
|
}
|
|
|
|
arch_initcall(tsi108_eth_of_init);
|