Craig Gallek 1b5f962e71 soreuseport: fix initialization race ... Syzkaller stumbled upon a way to trigger WARNING: CPU: 1 PID: 13881 at net/core/sock_reuseport.c:41 reuseport_alloc+0x306/0x3b0 net/core/sock_reuseport.c:39 There are two initialization paths for the sock_reuseport structure in a socket: Through the udp/tcp bind paths of SO_REUSEPORT sockets or through SO_ATTACH_REUSEPORT_[CE]BPF before bind. The existing implementation assumedthat the socket lock protected both of these paths when it actually only protects the SO_ATTACH_REUSEPORT path. Syzkaller triggered this double allocation by running these paths concurrently. This patch moves the check for double allocation into the reuseport_alloc function which is protected by a global spin lock. Fixes: e32ea7e747 ("soreuseport: fast reuseport UDP socket selection") Fixes: c125e80b88 ("soreuseport: fast reuseport TCP socket selection") Signed-off-by: Craig Gallek <kraig@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-10-22 02:03:51 +01:00
..
datagram.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
dev_addr_lists.c
dev_ioctl.c	dev_ioctl: add missing NETDEV_CHANGE_TX_QUEUE_LEN event notification	2017-10-16 21:23:10 +01:00
dev.c	tun: call dev_get_valid_name() before register_netdevice()	2017-10-16 21:02:54 +01:00
devlink.c	devlink: Add IPv6 header for dpipe	2017-08-31 14:42:19 -07:00
drop_monitor.c	drop_monitor: use setup_timer	2017-03-12 23:47:16 -07:00
dst_cache.c	net: dst_cache_per_cpu_dst_set() can be static	2016-03-18 17:45:08 -04:00
dst.c	net: check type when freeing metadata dst	2017-08-21 10:57:38 -07:00
ethtool.c	net: ethtool: Add back transceiver type	2017-09-21 15:20:40 -07:00
fib_notifier.c	net: Add module reference to FIB notifiers	2017-09-01 20:33:42 -07:00
fib_rules.c	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
filter.c	bpf: remove mark access for SK_SKB program types	2017-10-20 13:01:29 +01:00
flow_dissector.c	flow_dissector: Add limit for number of headers to dissect	2017-09-05 11:40:08 -07:00
gen_estimator.c	net_sched: gen_estimator: fix scaling error in bytes/packets samples	2017-09-13 13:30:53 -07:00
gen_stats.c	net_sched: gen_estimator: complete rewrite of rate estimators	2016-12-05 15:21:59 -05:00
gro_cells.c	net: Generic XDP	2017-04-25 13:33:49 -04:00
hwbm.c	net: hwbm: Fix unbalanced spinlock in error case	2016-05-25 12:35:09 -07:00
link_watch.c
lwt_bpf.c	net: add extack arg to lwtunnel build state	2017-05-30 11:55:32 -04:00
lwtunnel.c	ipv6: sr: define core operations for seg6local lightweight tunnel	2017-08-07 14:16:22 -07:00
Makefile	net: core: Make the FIB notification chain generic	2017-08-03 15:35:59 -07:00
neighbour.c	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
net_namespace.c	net: call newid/getid without rtnl mutex held	2017-08-09 16:57:38 -07:00
net-procfs.c	net-procfs: Use vsnprintf extension %phN	2017-06-04 19:52:58 -04:00
net-sysfs.c	net: style cleanups	2017-08-18 22:38:47 -07:00
net-sysfs.h
net-traces.c	bridge: add tracepoint in br_fdb_update	2017-08-31 11:42:41 -07:00
netclassid_cgroup.c	cgroup: add @flags to css_task_iter_start() and implement CSS_TASK_ITER_PROCS	2017-07-21 11:14:51 -04:00
netevent.c
netpoll.c	netpoll: Fix device name check in netpoll_setup()	2017-07-26 17:01:43 -07:00
netprio_cgroup.c	net: break include loop netdevice.h, dsa.h, devlink.h	2017-03-28 22:46:04 -07:00
pktgen.c	net: convert sk_buff.users from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
ptp_classifier.c	ptp: Change ptp_class to a proper bitmask	2015-11-03 11:08:22 -05:00
request_sock.c	ipv4: Namespaceify tcp_max_syn_backlog knob	2016-12-29 11:38:31 -05:00
rtnetlink.c	net: enable interface alias removal via rtnl	2017-10-16 20:52:43 +01:00
scm.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/user.h>	2017-03-02 08:42:29 +01:00
secure_seq.c	tcp: Namespaceify sysctl_tcp_timestamps	2017-06-08 10:53:29 -04:00
skbuff.c	sock: correct sk_wmem_queued accounting on efault in tcp zerocopy	2017-10-22 01:45:52 +01:00
sock_diag.c	netlink: extended ACK reporting	2017-04-13 13:58:20 -04:00
sock_reuseport.c	soreuseport: fix initialization race	2017-10-22 02:03:51 +01:00
sock.c	net: call cgroup_sk_alloc() earlier in sk_clone_lock()	2017-10-10 20:24:29 -07:00
stream.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/signal.h>	2017-03-02 08:42:29 +01:00
sysctl_net_core.c	net: move somaxconn init from sysctl code	2017-05-25 13:12:17 -04:00
timestamping.c	net: skb_defer_rx_timestamp should check for phydev before setting up classify	2015-07-09 14:17:15 -07:00
tso.c	net: tso: add support for IPv6	2015-10-26 22:24:22 -07:00
utils.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-05-02 16:40:27 -07:00