mirror of
https://github.com/torvalds/linux.git
synced 2024-11-17 09:31:50 +00:00
bbd5a762b4
This fixes a particular nasty racing problem found when using
Xen hypervisor with the console (hvc) output being routed to the
serial port and the serial port receiving data when
probe_irq_off(probe_irq_on) is running.
Specifically the bug manifests itself with:
[ 4.470693] BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
[ 4.470693] IP: [<ffffffff810a8c65>] handle_IRQ_event+0xe/0xc9
..snip..
[ 4.470693] Call Trace:
[ 4.470693] <IRQ>
[ 4.470693] [<ffffffff810aa645>] handle_percpu_irq+0x3c/0x69
[ 4.470693] [<ffffffff8123cda7>] __xen_evtchn_do_upcall+0xfd/0x195
[ 4.470693] [<ffffffff810308cf>] ? xen_restore_fl_direct_end+0x0/0x1
[ 4.470693] [<ffffffff8123d873>] xen_evtchn_do_upcall+0x32/0x47
[ 4.470693] [<ffffffff81034dfe>] xen_do_hypervisor_callback+0x1e/0x30
[ 4.470693] <EOI>
[ 4.470693] [<ffffffff8100922a>] ? hypercall_page+0x22a/0x1000
[ 4.470693] [<ffffffff8100922a>] ? hypercall_page+0x22a/0x1000
[ 4.470693] [<ffffffff810301c5>] ? xen_force_evtchn_callback+0xd/0xf
[ 4.470693] [<ffffffff810308e2>] ? check_events+0x12/0x20
[ 4.470693] [<ffffffff81030889>] ? xen_irq_enable_direct_end+0x0/0x7
[ 4.470693] [<ffffffff810ab0a0>] ? probe_irq_on+0x8f/0x1d7
[ 4.470693] [<ffffffff812b105e>] ? serial8250_config_port+0x7b7/0x9e6
[ 4.470693] [<ffffffff812ad66c>] ? uart_add_one_port+0x11b/0x305
The bug is trigged by three actors working together:
A). serial_8250_config_port calling
probe_irq_off(probe_irq_on())
wherein all of the IRQ handlers are being started and shut off.
The functions utilize the sleep functions so the minimum time
they are run is 120 msec.
B). Xen hypervisor receiving on the serial line any character and
setting the bits in the event channel - during this 120 msec timeframe.
C). The hvc API makes a call to 'request_irq' (and hence setting desc->action
to a valid value), much much later - when user space opens
/dev/console (hvc_open). To make the console usable during bootup,
the Xen HVC implementation sets the IRQ chip (and correspondingly
the event channel) much earlier. The IRQ chip handler that is used
is the handle_percpu_irq (aaca49642b
)
Back to the issue. When A) is being called it ends up calling the
xen_percpu_chip's chip->startup twice and chip->shutdown once. Those
are set to the default_startup and mask_irq (events.c) respectivly.
If (and this seems to depend on what serial concentrator you use), B)
gets data from the serial port it sets in the event channel a pending bit.
When A) calls chip->startup(), the masking of the pending bit, and
unmasking of the event channel mask, and also setting of the upcall_pending
flag is done (since there is data present on the event channel).
If before the 120 msec has elapsed, any IRQ handler (Xen IRQ has one
IRQ handler, which checks the event channels bitmap to figure which one
to call) is called we end up calling the handle_percpu_irq. The
handle_percpu_irq calls desc->action (which is NULL) and we blow up.
Caveats: I could only reproduce this on 2.6.32 pvops. I am not sure
why this is not showing up on 2.6.38 kernel.
The probe_irq_on/off has code to disable poking specific IRQ lines. This is
done by using the set_irq_noprobe() and then we do not have to
worry about the handle_percpu_irq being called before the IRQ action
handler has been installed.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
274 lines
6.2 KiB
C
274 lines
6.2 KiB
C
/*
|
|
* xen console driver interface to hvc_console.c
|
|
*
|
|
* (c) 2007 Gerd Hoffmann <kraxel@suse.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <linux/console.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/err.h>
|
|
#include <linux/init.h>
|
|
#include <linux/types.h>
|
|
|
|
#include <asm/xen/hypervisor.h>
|
|
|
|
#include <xen/xen.h>
|
|
#include <xen/page.h>
|
|
#include <xen/events.h>
|
|
#include <xen/interface/io/console.h>
|
|
#include <xen/hvc-console.h>
|
|
|
|
#include "hvc_console.h"
|
|
|
|
#define HVC_COOKIE 0x58656e /* "Xen" in hex */
|
|
|
|
static struct hvc_struct *hvc;
|
|
static int xencons_irq;
|
|
|
|
/* ------------------------------------------------------------------ */
|
|
|
|
static unsigned long console_pfn = ~0ul;
|
|
|
|
static inline struct xencons_interface *xencons_interface(void)
|
|
{
|
|
if (console_pfn == ~0ul)
|
|
return mfn_to_virt(xen_start_info->console.domU.mfn);
|
|
else
|
|
return __va(console_pfn << PAGE_SHIFT);
|
|
}
|
|
|
|
static inline void notify_daemon(void)
|
|
{
|
|
/* Use evtchn: this is called early, before irq is set up. */
|
|
notify_remote_via_evtchn(xen_start_info->console.domU.evtchn);
|
|
}
|
|
|
|
static int __write_console(const char *data, int len)
|
|
{
|
|
struct xencons_interface *intf = xencons_interface();
|
|
XENCONS_RING_IDX cons, prod;
|
|
int sent = 0;
|
|
|
|
cons = intf->out_cons;
|
|
prod = intf->out_prod;
|
|
mb(); /* update queue values before going on */
|
|
BUG_ON((prod - cons) > sizeof(intf->out));
|
|
|
|
while ((sent < len) && ((prod - cons) < sizeof(intf->out)))
|
|
intf->out[MASK_XENCONS_IDX(prod++, intf->out)] = data[sent++];
|
|
|
|
wmb(); /* write ring before updating pointer */
|
|
intf->out_prod = prod;
|
|
|
|
if (sent)
|
|
notify_daemon();
|
|
return sent;
|
|
}
|
|
|
|
static int domU_write_console(uint32_t vtermno, const char *data, int len)
|
|
{
|
|
int ret = len;
|
|
|
|
/*
|
|
* Make sure the whole buffer is emitted, polling if
|
|
* necessary. We don't ever want to rely on the hvc daemon
|
|
* because the most interesting console output is when the
|
|
* kernel is crippled.
|
|
*/
|
|
while (len) {
|
|
int sent = __write_console(data, len);
|
|
|
|
data += sent;
|
|
len -= sent;
|
|
|
|
if (unlikely(len))
|
|
HYPERVISOR_sched_op(SCHEDOP_yield, NULL);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int domU_read_console(uint32_t vtermno, char *buf, int len)
|
|
{
|
|
struct xencons_interface *intf = xencons_interface();
|
|
XENCONS_RING_IDX cons, prod;
|
|
int recv = 0;
|
|
|
|
cons = intf->in_cons;
|
|
prod = intf->in_prod;
|
|
mb(); /* get pointers before reading ring */
|
|
BUG_ON((prod - cons) > sizeof(intf->in));
|
|
|
|
while (cons != prod && recv < len)
|
|
buf[recv++] = intf->in[MASK_XENCONS_IDX(cons++, intf->in)];
|
|
|
|
mb(); /* read ring before consuming */
|
|
intf->in_cons = cons;
|
|
|
|
notify_daemon();
|
|
return recv;
|
|
}
|
|
|
|
static struct hv_ops domU_hvc_ops = {
|
|
.get_chars = domU_read_console,
|
|
.put_chars = domU_write_console,
|
|
.notifier_add = notifier_add_irq,
|
|
.notifier_del = notifier_del_irq,
|
|
.notifier_hangup = notifier_hangup_irq,
|
|
};
|
|
|
|
static int dom0_read_console(uint32_t vtermno, char *buf, int len)
|
|
{
|
|
return HYPERVISOR_console_io(CONSOLEIO_read, len, buf);
|
|
}
|
|
|
|
/*
|
|
* Either for a dom0 to write to the system console, or a domU with a
|
|
* debug version of Xen
|
|
*/
|
|
static int dom0_write_console(uint32_t vtermno, const char *str, int len)
|
|
{
|
|
int rc = HYPERVISOR_console_io(CONSOLEIO_write, len, (char *)str);
|
|
if (rc < 0)
|
|
return 0;
|
|
|
|
return len;
|
|
}
|
|
|
|
static struct hv_ops dom0_hvc_ops = {
|
|
.get_chars = dom0_read_console,
|
|
.put_chars = dom0_write_console,
|
|
.notifier_add = notifier_add_irq,
|
|
.notifier_del = notifier_del_irq,
|
|
.notifier_hangup = notifier_hangup_irq,
|
|
};
|
|
|
|
static int __init xen_hvc_init(void)
|
|
{
|
|
struct hvc_struct *hp;
|
|
struct hv_ops *ops;
|
|
|
|
if (!xen_pv_domain())
|
|
return -ENODEV;
|
|
|
|
if (xen_initial_domain()) {
|
|
ops = &dom0_hvc_ops;
|
|
xencons_irq = bind_virq_to_irq(VIRQ_CONSOLE, 0);
|
|
} else {
|
|
if (!xen_start_info->console.domU.evtchn)
|
|
return -ENODEV;
|
|
|
|
ops = &domU_hvc_ops;
|
|
xencons_irq = bind_evtchn_to_irq(xen_start_info->console.domU.evtchn);
|
|
}
|
|
if (xencons_irq < 0)
|
|
xencons_irq = 0; /* NO_IRQ */
|
|
else
|
|
set_irq_noprobe(xencons_irq);
|
|
|
|
hp = hvc_alloc(HVC_COOKIE, xencons_irq, ops, 256);
|
|
if (IS_ERR(hp))
|
|
return PTR_ERR(hp);
|
|
|
|
hvc = hp;
|
|
|
|
console_pfn = mfn_to_pfn(xen_start_info->console.domU.mfn);
|
|
|
|
return 0;
|
|
}
|
|
|
|
void xen_console_resume(void)
|
|
{
|
|
if (xencons_irq)
|
|
rebind_evtchn_irq(xen_start_info->console.domU.evtchn, xencons_irq);
|
|
}
|
|
|
|
static void __exit xen_hvc_fini(void)
|
|
{
|
|
if (hvc)
|
|
hvc_remove(hvc);
|
|
}
|
|
|
|
static int xen_cons_init(void)
|
|
{
|
|
struct hv_ops *ops;
|
|
|
|
if (!xen_pv_domain())
|
|
return 0;
|
|
|
|
if (xen_initial_domain())
|
|
ops = &dom0_hvc_ops;
|
|
else
|
|
ops = &domU_hvc_ops;
|
|
|
|
hvc_instantiate(HVC_COOKIE, 0, ops);
|
|
return 0;
|
|
}
|
|
|
|
module_init(xen_hvc_init);
|
|
module_exit(xen_hvc_fini);
|
|
console_initcall(xen_cons_init);
|
|
|
|
#ifdef CONFIG_EARLY_PRINTK
|
|
static void xenboot_write_console(struct console *console, const char *string,
|
|
unsigned len)
|
|
{
|
|
unsigned int linelen, off = 0;
|
|
const char *pos;
|
|
|
|
dom0_write_console(0, string, len);
|
|
|
|
if (xen_initial_domain())
|
|
return;
|
|
|
|
domU_write_console(0, "(early) ", 8);
|
|
while (off < len && NULL != (pos = strchr(string+off, '\n'))) {
|
|
linelen = pos-string+off;
|
|
if (off + linelen > len)
|
|
break;
|
|
domU_write_console(0, string+off, linelen);
|
|
domU_write_console(0, "\r\n", 2);
|
|
off += linelen + 1;
|
|
}
|
|
if (off < len)
|
|
domU_write_console(0, string+off, len-off);
|
|
}
|
|
|
|
struct console xenboot_console = {
|
|
.name = "xenboot",
|
|
.write = xenboot_write_console,
|
|
.flags = CON_PRINTBUFFER | CON_BOOT | CON_ANYTIME,
|
|
};
|
|
#endif /* CONFIG_EARLY_PRINTK */
|
|
|
|
void xen_raw_console_write(const char *str)
|
|
{
|
|
dom0_write_console(0, str, strlen(str));
|
|
}
|
|
|
|
void xen_raw_printk(const char *fmt, ...)
|
|
{
|
|
static char buf[512];
|
|
va_list ap;
|
|
|
|
va_start(ap, fmt);
|
|
vsnprintf(buf, sizeof(buf), fmt, ap);
|
|
va_end(ap);
|
|
|
|
xen_raw_console_write(buf);
|
|
}
|