Corey Minyard 0745dde628 ipmi: Fix I2C client removal in the SSIF driver ... The SSIF driver was removing any client that came in through the platform interface, but it should only remove clients that it added. On a failure in the probe function, this could result in the following oops when the driver is removed and the client gets unregistered twice: CPU: 107 PID: 30266 Comm: rmmod Not tainted 4.18.0+ #80 Hardware name: Cavium Inc. Saber/Saber, BIOS Cavium reference firmware version 7.0 08/04/2018 pstate: 60400009 (nZCv daif +PAN -UAO) pc : kernfs_find_ns+0x28/0x120 lr : kernfs_find_and_get_ns+0x40/0x60 sp : ffff00002310fb50 x29: ffff00002310fb50 x28: ffff800a8240f800 x27: 0000000000000000 x26: 0000000000000000 x25: 0000000056000000 x24: ffff000009073000 x23: ffff000008998b38 x22: 0000000000000000 x21: ffff800ed86de820 x20: 0000000000000000 x19: ffff00000913a1d8 x18: 0000000000000000 x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 x14: 5300737265766972 x13: 643d4d4554535953 x12: 0000000000000030 x11: 0000000000000030 x10: 0101010101010101 x9 : ffff800ea06cc3f9 x8 : 0000000000000000 x7 : 0000000000000141 x6 : ffff000009073000 x5 : ffff800adb706b00 x4 : 0000000000000000 x3 : 00000000ffffffff x2 : 0000000000000000 x1 : ffff000008998b38 x0 : ffff000008356760 Process rmmod (pid: 30266, stack limit = 0x00000000e218418d) Call trace: kernfs_find_ns+0x28/0x120 kernfs_find_and_get_ns+0x40/0x60 sysfs_unmerge_group+0x2c/0x6c dpm_sysfs_remove+0x34/0x70 device_del+0x58/0x30c device_unregister+0x30/0x7c i2c_unregister_device+0x84/0x90 [i2c_core] ssif_platform_remove+0x38/0x98 [ipmi_ssif] platform_drv_remove+0x2c/0x6c device_release_driver_internal+0x168/0x1f8 driver_detach+0x50/0xbc bus_remove_driver+0x74/0xe8 driver_unregister+0x34/0x5c platform_driver_unregister+0x20/0x2c cleanup_ipmi_ssif+0x50/0xd82c [ipmi_ssif] __arm64_sys_delete_module+0x1b4/0x220 el0_svc_handler+0x104/0x160 el0_svc+0x8/0xc Code: aa1e03e0 aa0203f6 aa0103f7 d503201f (7940e280) ---[ end trace 09f0e34cce8e2d8c ]--- Kernel panic - not syncing: Fatal exception SMP: stopping secondary CPUs Kernel Offset: disabled CPU features: 0x23800c38 So track the clients that the SSIF driver adds and only remove those. Reported-by: George Cherian <george.cherian@cavium.com> Signed-off-by: Corey Minyard <cminyard@mvista.com> Tested-by: George Cherian <george.cherian@cavium.com> Cc: <stable@vger.kernel.org> # 4.14.x		2018-08-31 08:43:12 -05:00
..
bt-bmc.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_bt_sm.c	ipmi: Move BT capabilities detection to the detect call	2018-08-31 08:42:59 -05:00
ipmi_devintf.c	ipmi_devintf: Add an error return on invalid ioctls	2018-04-18 10:23:04 -05:00
ipmi_dmi.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_dmi.h	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_kcs_sm.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_msghandler.c	ipmi: Rework SMI registration failure	2018-08-31 08:42:29 -05:00
ipmi_powernv.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_poweroff.c	ipmi: Rename ipmi_user_t to struct ipmi_user *	2018-04-18 10:22:55 -05:00
ipmi_si_hardcode.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_si_hotmod.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_si_intf.c	ipmi: Rework SMI registration failure	2018-08-31 08:42:29 -05:00
ipmi_si_mem_io.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_si_parisc.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_si_pci.c	ipmi:pci: Blacklist a Realtek "IPMI" device	2018-03-13 06:58:47 -05:00
ipmi_si_platform.c	ipmi: Remove ACPI SPMI probing from the system interface driver	2018-03-12 07:03:06 -05:00
ipmi_si_port_io.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_si_sm.h	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_si.h	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_smic_sm.c	ipmi: Add or fix SPDX-License-Identifier in all files	2018-02-27 07:42:51 -06:00
ipmi_ssif.c	ipmi: Fix I2C client removal in the SSIF driver	2018-08-31 08:43:12 -05:00
ipmi_watchdog.c	ipmi: Rename ipmi_user_t to struct ipmi_user *	2018-04-18 10:22:55 -05:00
Kconfig	ipmi: Remove the proc interface	2018-05-09 12:21:46 -05:00
kcs_bmc_aspeed.c	ipmi: kcs_bmc: coding-style fixes and use new poll type	2018-02-26 09:49:21 -06:00
kcs_bmc_npcm7xx.c	ipmi: NPCM7xx KCS BMC: enable interrupt to the host	2018-05-23 08:29:23 -05:00
kcs_bmc.c	ipmi: kcs_bmc: don't change device name	2018-08-30 14:55:18 -05:00
kcs_bmc.h	ipmi: kcs_bmc: coding-style fixes and use new poll type	2018-02-26 09:49:21 -06:00
Makefile	ipmi: add an NPCM7xx KCS BMC driver	2018-04-18 10:23:12 -05:00