Jim Harris 0718588c7a cxl/region: Do not try to cleanup after cxl_region_setup_targets() fails ... Commit 5e42bcbc3f ("cxl/region: decrement ->nr_targets on error in cxl_region_attach()") tried to avoid 'eiw' initialization errors when ->nr_targets exceeded 16, by just decrementing ->nr_targets when cxl_region_setup_targets() failed. Commit 86987c7662 ("cxl/region: Cleanup target list on attach error") extended that cleanup to also clear cxled->pos and p->targets[pos]. The initialization error was incidentally fixed separately by: Commit 8d42854257 ("cxl/region: Fix port setup uninitialized variable warnings") which was merged a few days after 5e42bcbc3f. But now the original cleanup when cxl_region_setup_targets() fails prevents endpoint and switch decoder resources from being reused: 1) the cleanup does not set the decoder's region to NULL, which results in future dpa_size_store() calls returning -EBUSY 2) the decoder is not properly freed, which results in future commit errors associated with the upstream switch Now that the initialization errors were fixed separately, the proper cleanup for this case is to just return immediately. Then the resources associated with this target get cleanup up as normal when the failed region is deleted. The ->nr_targets decrement in the error case also helped prevent a p->targets[] array overflow, so add a new check to prevent against that overflow. Tested by trying to create an invalid region for a 2 switch * 2 endpoint topology, and then following up with creating a valid region. Fixes: 5e42bcbc3f ("cxl/region: decrement ->nr_targets on error in cxl_region_attach()") Cc: <stable@vger.kernel.org> Signed-off-by: Jim Harris <jim.harris@samsung.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/169703589120.1202031.14696100866518083806.stgit@bgt-140510-bm03.eng.stellus.in Signed-off-by: Dan Williams <dan.j.williams@intel.com>		2023-10-24 14:43:37 -07:00
..
core	cxl/region: Do not try to cleanup after cxl_region_setup_targets() fails	2023-10-24 14:43:37 -07:00
acpi.c	cxl/acpi: Annotate struct cxl_cxims_data with __counted_by	2023-09-22 14:31:04 -07:00
cxl.h	Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl	2023-06-25 18:56:13 -07:00
cxlmem.h	cxl/memdev: Fix sanitize vs decoder setup locking	2023-10-06 00:12:45 -07:00
cxlpci.h	cxl/pci: Find and register CXL PMU devices	2023-05-30 11:20:35 -07:00
Kconfig	cxl: fix CONFIG_FW_LOADER dependency	2023-07-14 14:32:22 -06:00
Makefile	cxl/pmem: Introduce nvdimm_security_ops with ->get_flags() operation	2022-11-30 16:30:47 -08:00
mem.c	Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl	2023-06-25 18:56:13 -07:00
pci.c	cxl/memdev: Fix sanitize vs decoder setup locking	2023-10-06 00:12:45 -07:00
pmem.c	cxl/mbox: Move mailbox related driver state to its own data structure	2023-06-25 14:31:08 -07:00
pmu.h	cxl/pci: Find and register CXL PMU devices	2023-05-30 11:20:35 -07:00
port.c	Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl	2023-06-25 18:56:13 -07:00
security.c	Merge branch 'for-6.5/cxl-type-2' into for-6.5/cxl	2023-06-25 17:16:51 -07:00