linux/drivers/video
Bhushan Shah 06168a64b1 backlight: lm3630a: Bump REG_MAX value to 0x50 instead of 0x1F
In the lm3630a_chip_init we try to write to 0x50 register, which is
higher value then the max_register value, this resulted in regmap_write
return -EIO.

Fix this by bumping REG_MAX value to 0x50.

This code was introduced with the chip revision in commit 28e64a68a2,
however setting filter strength was failing silently because it used
unsigned int for storing and comparing the return values. Bug related to
signedness was fixed in 2a0c316bf3, which made it error out correctly
instead of failing silently.

I found this issue by using this driver on LGE Nexus 5 (hammerhead).
After this commit lm3630a_chip_init succeeds instead of failing with
-EIO.

Fixes: 28e64a68a2 ("backlight: lm3630: apply chip revision")
Fixes: 2a0c316bf3 ("drivers/video/backlight/lm3630a_bl.c: fix
signedness bug in lm3630a_chip_init()")

Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Bhushan Shah <bshah@kde.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
2017-07-17 13:27:06 +01:00
..
backlight backlight: lm3630a: Bump REG_MAX value to 0x50 instead of 0x1F 2017-07-17 13:27:06 +01:00
console mdacon: replace MDA_ADDR macro by inline function 2017-06-14 17:40:56 +02:00
fbdev Merge branch 'akpm' (patches from Andrew) 2017-07-13 12:38:49 -07:00
logo video/logo: tidyup fb_logo_late_init initcall timing 2017-03-20 18:31:00 +01:00
display_timing.c
hdmi.c video: Add new aspect ratios for HDMI 2.0 2016-10-17 14:23:46 +02:00
Kconfig fbdev: sh_mipi_dsi: remove driver 2016-05-10 11:53:38 +03:00
Makefile fbdev: sti: don't select CONFIG_VT 2017-05-05 17:25:12 +02:00
of_display_timing.c Merge branch 'drm/next/du' of git://linuxtv.org/pinchartl/media into drm-next 2016-11-16 09:39:21 +10:00
of_videomode.c video: Fix possible leak in of_get_videomode() 2015-08-10 15:11:12 +03:00
vgastate.c fbdev: vgastate: remove trailing whitespaces 2015-01-13 12:53:25 +02:00
videomode.c