mirror of
https://github.com/torvalds/linux.git
synced 2024-11-19 02:21:47 +00:00
47cf84e17e
The commit1abe729
(ASoC: fsl: Add missing pm to current machine drivers) enables pm support for a few IMX machine drivers. But it does not update dev drvdata to be the pointer to 'card'. This causes the kernel dump below in system suspend, because snd_soc_suspend() expects that the dev drvdata points to 'card', while it still points to the private data of machine driver. This patch fixes imx-sgtl5000 and imx-wm8962 by attaching 'card' to dev drvdata and private data to card drvdata. For imx-mc13783, I simply revert the pm change because it must be broken for the same reason and I don't have hardware to test pm enabling code. $ echo mem > /sys/power/state PM: Syncing filesystems ... done. PM: Preparing system for mem sleep mmc1: card e624 removed Freezing user space processes ... (elapsed 0.002 seconds) done. Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done. PM: Entering mem sleep INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 1861 Comm: bash Not tainted 3.14.0-rc1+ #1648 Backtrace: [<80012144>] (dump_backtrace) from [<800122e4>] (show_stack+0x18/0x1c) r6:8079c77c r5:00000c5a r4:00000000 r3:00000000 [<800122cc>] (show_stack) from [<80637ac0>] (dump_stack+0x78/0x94) [<80637a48>] (dump_stack) from [<80028918>] (warn_slowpath_common+0x6c/0x8c) r4:bdb21c38 r3:be62df00 [<800288ac>] (warn_slowpath_common) from [<800289dc>] (warn_slowpath_fmt+0x38/0x40) r8:be62e3a8 r7:bf122960 r6:00000005 r5:00000000 r4:00000000 [<800289a8>] (warn_slowpath_fmt) from [<8006518c>] (__lock_acquire+0x1ae0/0x1ce0) r3:8079d598 r2:80799e70 [<800636ac>] (__lock_acquire) from [<80065894>] (lock_acquire+0x68/0x7c) r10:bdb20000 r9:be62df00 r8:00000000 r7:00000000 r6:60000013 r5:bdb20000 r4:00000000 [<8006582c>] (lock_acquire) from [<8063c938>] (mutex_lock_nested+0x5c/0x3b8) r7:00000000 r6:80dfc78c r5:804be444 r4:bf122928 [<8063c8dc>] (mutex_lock_nested) from [<804be444>] (snd_soc_suspend+0x34/0x42c) r10:00000000 r9:00000000 r8:00000000 r7:bf1c4444 r6:bf1c4410 r5:be978150 r4:be978010 [<804be410>] (snd_soc_suspend) from [<8034392c>] (platform_pm_suspend+0x34/0x64) r10:00000000 r8:00000000 r7:bf1c4444 r6:bf1c4410 r5:803438f8 r4:bf1c4410 [<803438f8>] (platform_pm_suspend) from [<80348e18>] (dpm_run_callback.isra.7+0x34/0x6c) [<80348de4>] (dpm_run_callback.isra.7) from [<80349354>] (__device_suspend+0x10c/0x220) r9:808dd974 r8:808c4a5c r6:00000002 r5:80e5001c r4:bf1c4410 [<80349248>] (__device_suspend) from [<8034a338>] (dpm_suspend+0x60/0x220) r7:bf1c4410 r6:808dd90c r5:80e5001c r4:bf1c44c0 [<8034a2d8>] (dpm_suspend) from [<8034a790>] (dpm_suspend_start+0x60/0x68) r10:8079a818 r9:00000000 r8:00000004 r7:80dfbe90 r6:80641eec r5:00000000 r4:00000002 [<8034a730>] (dpm_suspend_start) from [<8006a788>] (suspend_devices_and_enter+0x74/0x318) r4:00000003 r3:80dfbe98 [<8006a714>] (suspend_devices_and_enter) from [<8006abd8>] (pm_suspend+0x1ac/0x244) r10:8079a818 r8:00000004 r7:00000003 r6:80641eec r5:00000000 r4:00000003 [<8006aa2c>] (pm_suspend) from [<80069a4c>] (state_store+0x70/0xc0) r5:00000003 r4:bd85ea40 [<800699dc>] (state_store) from [<80294034>] (kobj_attr_store+0x1c/0x28) r10:beb9fe08 r8:00000000 r7:bdb21f78 r6:bd85ea40 r5:00000004 r4:beb9fe00 [<80294018>] (kobj_attr_store) from [<80140f90>] (sysfs_kf_write+0x54/0x58) [<80140f3c>] (sysfs_kf_write) from [<8014474c>] (kernfs_fop_write+0xc4/0x160) r6:bd85ea40 r5:beb9fe00 r4:00000004 r3:80140f3c [<80144688>] (kernfs_fop_write) from [<800dfa14>] (vfs_write+0xbc/0x184) r10:00000000 r9:00000000 r8:00000000 r7:bdb21f78 r6:00500c08 r5:00000004 r4:be782600 [<800df958>] (vfs_write) from [<800dfe00>] (SyS_write+0x48/0x70) r10:00000000 r8:00000000 r7:00000004 r6:00500c08 r5:00000000 r4:be782600 [<800dfdb8>] (SyS_write) from [<8000e800>] (ret_fast_syscall+0x0/0x48) r9:bdb20000 r8:8000e9c4 r7:00000004 r6:00500c08 r5:00000004 r4:76eb65e0 Fixes:1abe729
(ASoC: fsl: Add missing pm to current machine drivers) Cc: stable@vger.kernel.org Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org>
325 lines
8.2 KiB
C
325 lines
8.2 KiB
C
/*
|
|
* Copyright 2013 Freescale Semiconductor, Inc.
|
|
*
|
|
* Based on imx-sgtl5000.c
|
|
* Copyright 2012 Freescale Semiconductor, Inc.
|
|
* Copyright 2012 Linaro Ltd.
|
|
*
|
|
* The code contained herein is licensed under the GNU General Public
|
|
* License. You may obtain a copy of the GNU General Public License
|
|
* Version 2 or later at the following locations:
|
|
*
|
|
* http://www.opensource.org/licenses/gpl-license.html
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/clk.h>
|
|
#include <sound/soc.h>
|
|
#include <sound/pcm_params.h>
|
|
#include <sound/soc-dapm.h>
|
|
#include <linux/pinctrl/consumer.h>
|
|
|
|
#include "../codecs/wm8962.h"
|
|
#include "imx-audmux.h"
|
|
|
|
#define DAI_NAME_SIZE 32
|
|
|
|
struct imx_wm8962_data {
|
|
struct snd_soc_dai_link dai;
|
|
struct snd_soc_card card;
|
|
char codec_dai_name[DAI_NAME_SIZE];
|
|
char platform_name[DAI_NAME_SIZE];
|
|
struct clk *codec_clk;
|
|
unsigned int clk_frequency;
|
|
};
|
|
|
|
struct imx_priv {
|
|
struct platform_device *pdev;
|
|
};
|
|
static struct imx_priv card_priv;
|
|
|
|
static const struct snd_soc_dapm_widget imx_wm8962_dapm_widgets[] = {
|
|
SND_SOC_DAPM_HP("Headphone Jack", NULL),
|
|
SND_SOC_DAPM_SPK("Ext Spk", NULL),
|
|
SND_SOC_DAPM_MIC("AMIC", NULL),
|
|
SND_SOC_DAPM_MIC("DMIC", NULL),
|
|
};
|
|
|
|
static int sample_rate = 44100;
|
|
static snd_pcm_format_t sample_format = SNDRV_PCM_FORMAT_S16_LE;
|
|
|
|
static int imx_hifi_hw_params(struct snd_pcm_substream *substream,
|
|
struct snd_pcm_hw_params *params)
|
|
{
|
|
sample_rate = params_rate(params);
|
|
sample_format = params_format(params);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct snd_soc_ops imx_hifi_ops = {
|
|
.hw_params = imx_hifi_hw_params,
|
|
};
|
|
|
|
static int imx_wm8962_set_bias_level(struct snd_soc_card *card,
|
|
struct snd_soc_dapm_context *dapm,
|
|
enum snd_soc_bias_level level)
|
|
{
|
|
struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
|
|
struct imx_priv *priv = &card_priv;
|
|
struct imx_wm8962_data *data = snd_soc_card_get_drvdata(card);
|
|
struct device *dev = &priv->pdev->dev;
|
|
unsigned int pll_out;
|
|
int ret;
|
|
|
|
if (dapm->dev != codec_dai->dev)
|
|
return 0;
|
|
|
|
switch (level) {
|
|
case SND_SOC_BIAS_PREPARE:
|
|
if (dapm->bias_level == SND_SOC_BIAS_STANDBY) {
|
|
if (sample_format == SNDRV_PCM_FORMAT_S24_LE)
|
|
pll_out = sample_rate * 384;
|
|
else
|
|
pll_out = sample_rate * 256;
|
|
|
|
ret = snd_soc_dai_set_pll(codec_dai, WM8962_FLL,
|
|
WM8962_FLL_MCLK, data->clk_frequency,
|
|
pll_out);
|
|
if (ret < 0) {
|
|
dev_err(dev, "failed to start FLL: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = snd_soc_dai_set_sysclk(codec_dai,
|
|
WM8962_SYSCLK_FLL, pll_out,
|
|
SND_SOC_CLOCK_IN);
|
|
if (ret < 0) {
|
|
dev_err(dev, "failed to set SYSCLK: %d\n", ret);
|
|
return ret;
|
|
}
|
|
}
|
|
break;
|
|
|
|
case SND_SOC_BIAS_STANDBY:
|
|
if (dapm->bias_level == SND_SOC_BIAS_PREPARE) {
|
|
ret = snd_soc_dai_set_sysclk(codec_dai,
|
|
WM8962_SYSCLK_MCLK, data->clk_frequency,
|
|
SND_SOC_CLOCK_IN);
|
|
if (ret < 0) {
|
|
dev_err(dev,
|
|
"failed to switch away from FLL: %d\n",
|
|
ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = snd_soc_dai_set_pll(codec_dai, WM8962_FLL,
|
|
0, 0, 0);
|
|
if (ret < 0) {
|
|
dev_err(dev, "failed to stop FLL: %d\n", ret);
|
|
return ret;
|
|
}
|
|
}
|
|
break;
|
|
|
|
default:
|
|
break;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int imx_wm8962_late_probe(struct snd_soc_card *card)
|
|
{
|
|
struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
|
|
struct imx_priv *priv = &card_priv;
|
|
struct imx_wm8962_data *data = snd_soc_card_get_drvdata(card);
|
|
struct device *dev = &priv->pdev->dev;
|
|
int ret;
|
|
|
|
ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_MCLK,
|
|
data->clk_frequency, SND_SOC_CLOCK_IN);
|
|
if (ret < 0)
|
|
dev_err(dev, "failed to set sysclk in %s\n", __func__);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int imx_wm8962_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node;
|
|
struct device_node *ssi_np, *codec_np;
|
|
struct platform_device *ssi_pdev;
|
|
struct imx_priv *priv = &card_priv;
|
|
struct i2c_client *codec_dev;
|
|
struct imx_wm8962_data *data;
|
|
int int_port, ext_port;
|
|
int ret;
|
|
|
|
priv->pdev = pdev;
|
|
|
|
ret = of_property_read_u32(np, "mux-int-port", &int_port);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "mux-int-port missing or invalid\n");
|
|
return ret;
|
|
}
|
|
ret = of_property_read_u32(np, "mux-ext-port", &ext_port);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "mux-ext-port missing or invalid\n");
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* The port numbering in the hardware manual starts at 1, while
|
|
* the audmux API expects it starts at 0.
|
|
*/
|
|
int_port--;
|
|
ext_port--;
|
|
ret = imx_audmux_v2_configure_port(int_port,
|
|
IMX_AUDMUX_V2_PTCR_SYN |
|
|
IMX_AUDMUX_V2_PTCR_TFSEL(ext_port) |
|
|
IMX_AUDMUX_V2_PTCR_TCSEL(ext_port) |
|
|
IMX_AUDMUX_V2_PTCR_TFSDIR |
|
|
IMX_AUDMUX_V2_PTCR_TCLKDIR,
|
|
IMX_AUDMUX_V2_PDCR_RXDSEL(ext_port));
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "audmux internal port setup failed\n");
|
|
return ret;
|
|
}
|
|
imx_audmux_v2_configure_port(ext_port,
|
|
IMX_AUDMUX_V2_PTCR_SYN,
|
|
IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "audmux external port setup failed\n");
|
|
return ret;
|
|
}
|
|
|
|
ssi_np = of_parse_phandle(pdev->dev.of_node, "ssi-controller", 0);
|
|
codec_np = of_parse_phandle(pdev->dev.of_node, "audio-codec", 0);
|
|
if (!ssi_np || !codec_np) {
|
|
dev_err(&pdev->dev, "phandle missing or invalid\n");
|
|
ret = -EINVAL;
|
|
goto fail;
|
|
}
|
|
|
|
ssi_pdev = of_find_device_by_node(ssi_np);
|
|
if (!ssi_pdev) {
|
|
dev_err(&pdev->dev, "failed to find SSI platform device\n");
|
|
ret = -EINVAL;
|
|
goto fail;
|
|
}
|
|
codec_dev = of_find_i2c_device_by_node(codec_np);
|
|
if (!codec_dev || !codec_dev->dev.driver) {
|
|
dev_err(&pdev->dev, "failed to find codec platform device\n");
|
|
ret = -EINVAL;
|
|
goto fail;
|
|
}
|
|
|
|
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
|
|
if (!data) {
|
|
ret = -ENOMEM;
|
|
goto fail;
|
|
}
|
|
|
|
data->codec_clk = devm_clk_get(&codec_dev->dev, NULL);
|
|
if (IS_ERR(data->codec_clk)) {
|
|
ret = PTR_ERR(data->codec_clk);
|
|
dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret);
|
|
goto fail;
|
|
}
|
|
|
|
data->clk_frequency = clk_get_rate(data->codec_clk);
|
|
ret = clk_prepare_enable(data->codec_clk);
|
|
if (ret) {
|
|
dev_err(&codec_dev->dev, "failed to enable codec clk: %d\n", ret);
|
|
goto fail;
|
|
}
|
|
|
|
data->dai.name = "HiFi";
|
|
data->dai.stream_name = "HiFi";
|
|
data->dai.codec_dai_name = "wm8962";
|
|
data->dai.codec_of_node = codec_np;
|
|
data->dai.cpu_dai_name = dev_name(&ssi_pdev->dev);
|
|
data->dai.platform_of_node = ssi_np;
|
|
data->dai.ops = &imx_hifi_ops;
|
|
data->dai.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
|
|
SND_SOC_DAIFMT_CBM_CFM;
|
|
|
|
data->card.dev = &pdev->dev;
|
|
ret = snd_soc_of_parse_card_name(&data->card, "model");
|
|
if (ret)
|
|
goto clk_fail;
|
|
ret = snd_soc_of_parse_audio_routing(&data->card, "audio-routing");
|
|
if (ret)
|
|
goto clk_fail;
|
|
data->card.num_links = 1;
|
|
data->card.dai_link = &data->dai;
|
|
data->card.dapm_widgets = imx_wm8962_dapm_widgets;
|
|
data->card.num_dapm_widgets = ARRAY_SIZE(imx_wm8962_dapm_widgets);
|
|
|
|
data->card.late_probe = imx_wm8962_late_probe;
|
|
data->card.set_bias_level = imx_wm8962_set_bias_level;
|
|
|
|
platform_set_drvdata(pdev, &data->card);
|
|
snd_soc_card_set_drvdata(&data->card, data);
|
|
|
|
ret = devm_snd_soc_register_card(&pdev->dev, &data->card);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret);
|
|
goto clk_fail;
|
|
}
|
|
|
|
of_node_put(ssi_np);
|
|
of_node_put(codec_np);
|
|
|
|
return 0;
|
|
|
|
clk_fail:
|
|
clk_disable_unprepare(data->codec_clk);
|
|
fail:
|
|
if (ssi_np)
|
|
of_node_put(ssi_np);
|
|
if (codec_np)
|
|
of_node_put(codec_np);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int imx_wm8962_remove(struct platform_device *pdev)
|
|
{
|
|
struct snd_soc_card *card = platform_get_drvdata(pdev);
|
|
struct imx_wm8962_data *data = snd_soc_card_get_drvdata(card);
|
|
|
|
if (!IS_ERR(data->codec_clk))
|
|
clk_disable_unprepare(data->codec_clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id imx_wm8962_dt_ids[] = {
|
|
{ .compatible = "fsl,imx-audio-wm8962", },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, imx_wm8962_dt_ids);
|
|
|
|
static struct platform_driver imx_wm8962_driver = {
|
|
.driver = {
|
|
.name = "imx-wm8962",
|
|
.owner = THIS_MODULE,
|
|
.pm = &snd_soc_pm_ops,
|
|
.of_match_table = imx_wm8962_dt_ids,
|
|
},
|
|
.probe = imx_wm8962_probe,
|
|
.remove = imx_wm8962_remove,
|
|
};
|
|
module_platform_driver(imx_wm8962_driver);
|
|
|
|
MODULE_AUTHOR("Freescale Semiconductor, Inc.");
|
|
MODULE_DESCRIPTION("Freescale i.MX WM8962 ASoC machine driver");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:imx-wm8962");
|