mirror of
https://github.com/torvalds/linux.git
synced 2024-09-20 15:03:04 +00:00
7beaf1da07
When resctrl is built on architectures without __cpuid_count()
support, build fails. resctrl uses __cpuid_count() defined in
kselftest.h.
Even though the problem is seen while building resctrl on aarch64,
this error can be seen on any platform that doesn't support CPUID.
CPUID is a x86/x86-64 feature and code paths with CPUID asm commands
will fail to build on all other architectures.
All others tests call __cpuid_count() do so from x86/x86_64 code paths
when _i386__ or __x86_64__ are defined. resctrl is an exception.
Fix the problem by defining __cpuid_count() only when __i386__ or
__x86_64__ are defined in kselftest.h and changing resctrl to call
__cpuid_count() only when __i386__ or __x86_64__ are defined.
In file included from resctrl.h:24,
from cat_test.c:11:
In function ‘arch_supports_noncont_cat’,
inlined from ‘noncont_cat_run_test’ at cat_test.c:326:6:
../kselftest.h:74:9: error: impossible constraint in ‘asm’
74 | __asm__ __volatile__ ("cpuid\n\t" \
| ^~~~~~~
cat_test.c:304:17: note: in expansion of macro ‘__cpuid_count’
304 | __cpuid_count(0x10, 1, eax, ebx, ecx, edx);
| ^~~~~~~~~~~~~
../kselftest.h:74:9: error: impossible constraint in ‘asm’
74 | __asm__ __volatile__ ("cpuid\n\t" \
| ^~~~~~~
cat_test.c:306:17: note: in expansion of macro ‘__cpuid_count’
306 | __cpuid_count(0x10, 2, eax, ebx, ecx, edx);
Fixes:
|
||
---|---|---|
.. | ||
.gitignore | ||
cache.c | ||
cat_test.c | ||
cmt_test.c | ||
config | ||
fill_buf.c | ||
Makefile | ||
mba_test.c | ||
mbm_test.c | ||
README | ||
resctrl_tests.c | ||
resctrl_val.c | ||
resctrl.h | ||
resctrlfs.c | ||
settings |
resctrl_tests - resctrl file system test suit Authors: Fenghua Yu <fenghua.yu@intel.com> Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>, resctrl_tests tests various resctrl functionalities and interfaces including both software and hardware. Currently it supports Memory Bandwidth Monitoring test and Memory Bandwidth Allocation test on Intel RDT hardware. More tests will be added in the future. And the test suit can be extended to cover AMD QoS and ARM MPAM hardware as well. resctrl_tests can be run with or without kselftest framework. WITH KSELFTEST FRAMEWORK ======================= BUILD ----- Build executable file "resctrl_tests" from top level directory of the kernel source: $ make -C tools/testing/selftests TARGETS=resctrl RUN --- Run resctrl_tests as sudo or root since the test needs to mount resctrl file system and change contents in the file system. Using kselftest framework will run all supported tests within resctrl_tests: $ sudo make -C tools/testing/selftests TARGETS=resctrl run_tests More details about kselftest framework can be found in Documentation/dev-tools/kselftest.rst. WITHOUT KSELFTEST FRAMEWORK =========================== BUILD ----- Build executable file "resctrl_tests" from this directory(tools/testing/selftests/resctrl/): $ make RUN --- Run resctrl_tests as sudo or root since the test needs to mount resctrl file system and change contents in the file system. Executing the test without any parameter will run all supported tests: $ sudo ./resctrl_tests OVERVIEW OF EXECUTION ===================== A test case has four stages: - setup: mount resctrl file system, create group, setup schemata, move test process pids to tasks, start benchmark. - execute: let benchmark run - verify: get resctrl data and verify the data with another source, e.g. perf event. - teardown: umount resctrl and clear temporary files. ARGUMENTS ========= Parameter '-h' shows usage information. usage: resctrl_tests [-h] [-b "benchmark_cmd [options]"] [-t test list] [-n no_of_bits] -b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT default benchmark is builtin fill_buf -t test list: run tests specified in the test list, e.g. -t mbm,mba,cmt,cat -n no_of_bits: run cache tests using specified no of bits in cache bit mask -p cpu_no: specify CPU number to run the test. 1 is default -h: help