mirror of
https://github.com/torvalds/linux.git
synced 2024-09-20 15:03:04 +00:00
222f58ac68
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230703172159.3668349-2-azeemshaikh38@gmail.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
96 lines
2.3 KiB
C
96 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM kyber
|
|
|
|
#if !defined(_TRACE_KYBER_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_KYBER_H
|
|
|
|
#include <linux/blkdev.h>
|
|
#include <linux/tracepoint.h>
|
|
|
|
#define DOMAIN_LEN 16
|
|
#define LATENCY_TYPE_LEN 8
|
|
|
|
TRACE_EVENT(kyber_latency,
|
|
|
|
TP_PROTO(dev_t dev, const char *domain, const char *type,
|
|
unsigned int percentile, unsigned int numerator,
|
|
unsigned int denominator, unsigned int samples),
|
|
|
|
TP_ARGS(dev, domain, type, percentile, numerator, denominator, samples),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__array( char, domain, DOMAIN_LEN )
|
|
__array( char, type, LATENCY_TYPE_LEN )
|
|
__field( u8, percentile )
|
|
__field( u8, numerator )
|
|
__field( u8, denominator )
|
|
__field( unsigned int, samples )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = dev;
|
|
strscpy(__entry->domain, domain, sizeof(__entry->domain));
|
|
strscpy(__entry->type, type, sizeof(__entry->type));
|
|
__entry->percentile = percentile;
|
|
__entry->numerator = numerator;
|
|
__entry->denominator = denominator;
|
|
__entry->samples = samples;
|
|
),
|
|
|
|
TP_printk("%d,%d %s %s p%u %u/%u samples=%u",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev), __entry->domain,
|
|
__entry->type, __entry->percentile, __entry->numerator,
|
|
__entry->denominator, __entry->samples)
|
|
);
|
|
|
|
TRACE_EVENT(kyber_adjust,
|
|
|
|
TP_PROTO(dev_t dev, const char *domain, unsigned int depth),
|
|
|
|
TP_ARGS(dev, domain, depth),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__array( char, domain, DOMAIN_LEN )
|
|
__field( unsigned int, depth )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = dev;
|
|
strscpy(__entry->domain, domain, sizeof(__entry->domain));
|
|
__entry->depth = depth;
|
|
),
|
|
|
|
TP_printk("%d,%d %s %u",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev), __entry->domain,
|
|
__entry->depth)
|
|
);
|
|
|
|
TRACE_EVENT(kyber_throttled,
|
|
|
|
TP_PROTO(dev_t dev, const char *domain),
|
|
|
|
TP_ARGS(dev, domain),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__array( char, domain, DOMAIN_LEN )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = dev;
|
|
strscpy(__entry->domain, domain, sizeof(__entry->domain));
|
|
),
|
|
|
|
TP_printk("%d,%d %s", MAJOR(__entry->dev), MINOR(__entry->dev),
|
|
__entry->domain)
|
|
);
|
|
|
|
#define _TRACE_KYBER_H
|
|
#endif /* _TRACE_KYBER_H */
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|