linux/drivers/net/mctp
Matt Johnston f962e8361a net: mctp-serial: Fix missing escapes on transmit
0x7d and 0x7e bytes are meant to be escaped in the data portion of
frames, but this didn't occur since next_chunk_len() had an off-by-one
error. That also resulted in the final byte of a payload being written
as a separate tty write op.

The chunk prior to an escaped byte would be one byte short, and the
next call would never test the txpos+1 case, which is where the escaped
byte was located. That meant it never hit the escaping case in
mctp_serial_tx_work().

Example Input: 01 00 08 c8 7e 80 02

Previous incorrect chunks from next_chunk_len():

01 00 08
c8 7e 80
02

With this fix:

01 00 08 c8
7e
80 02

Cc: stable@vger.kernel.org
Fixes: a0c2ccd9b5 ("mctp: Add MCTP-over-serial transport binding")
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
2024-09-01 18:14:01 +01:00
..
Kconfig net: mctp-serial: Add kunit test for next_chunk_len() 2024-09-01 18:14:01 +01:00
Makefile mctp i3c: MCTP I3C driver 2023-10-17 12:45:03 +02:00
mctp-i2c.c net: mctp-i2c: invalidate flows immediately on TX errors 2024-07-12 13:37:31 +01:00
mctp-i3c.c mctp i3c: MCTP I3C driver 2023-10-17 12:45:03 +02:00
mctp-serial.c net: mctp-serial: Fix missing escapes on transmit 2024-09-01 18:14:01 +01:00