mirror of
https://github.com/torvalds/linux.git
synced 2024-09-20 06:53:04 +00:00
f04ed6b174
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Xu Yilun <yilun.xu@intel.com> Link: https://lore.kernel.org/r/be0728ae8e047c6b443492dc563cf92f397b269d.1703006638.git.u.kleine-koenig@pengutronix.de Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
108 lines
2.5 KiB
C
108 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* FPGA Bridge Driver for FPGA Management Engine (FME)
|
|
*
|
|
* Copyright (C) 2017-2018 Intel Corporation, Inc.
|
|
*
|
|
* Authors:
|
|
* Wu Hao <hao.wu@intel.com>
|
|
* Joseph Grecco <joe.grecco@intel.com>
|
|
* Enno Luebbers <enno.luebbers@intel.com>
|
|
* Tim Whisonant <tim.whisonant@intel.com>
|
|
* Ananda Ravuri <ananda.ravuri@intel.com>
|
|
* Henry Mitchel <henry.mitchel@intel.com>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/fpga/fpga-bridge.h>
|
|
|
|
#include "dfl.h"
|
|
#include "dfl-fme-pr.h"
|
|
|
|
struct fme_br_priv {
|
|
struct dfl_fme_br_pdata *pdata;
|
|
struct dfl_fpga_port_ops *port_ops;
|
|
struct platform_device *port_pdev;
|
|
};
|
|
|
|
static int fme_bridge_enable_set(struct fpga_bridge *bridge, bool enable)
|
|
{
|
|
struct fme_br_priv *priv = bridge->priv;
|
|
struct platform_device *port_pdev;
|
|
struct dfl_fpga_port_ops *ops;
|
|
|
|
if (!priv->port_pdev) {
|
|
port_pdev = dfl_fpga_cdev_find_port(priv->pdata->cdev,
|
|
&priv->pdata->port_id,
|
|
dfl_fpga_check_port_id);
|
|
if (!port_pdev)
|
|
return -ENODEV;
|
|
|
|
priv->port_pdev = port_pdev;
|
|
}
|
|
|
|
if (priv->port_pdev && !priv->port_ops) {
|
|
ops = dfl_fpga_port_ops_get(priv->port_pdev);
|
|
if (!ops || !ops->enable_set)
|
|
return -ENOENT;
|
|
|
|
priv->port_ops = ops;
|
|
}
|
|
|
|
return priv->port_ops->enable_set(priv->port_pdev, enable);
|
|
}
|
|
|
|
static const struct fpga_bridge_ops fme_bridge_ops = {
|
|
.enable_set = fme_bridge_enable_set,
|
|
};
|
|
|
|
static int fme_br_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct fme_br_priv *priv;
|
|
struct fpga_bridge *br;
|
|
|
|
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
priv->pdata = dev_get_platdata(dev);
|
|
|
|
br = fpga_bridge_register(dev, "DFL FPGA FME Bridge",
|
|
&fme_bridge_ops, priv);
|
|
if (IS_ERR(br))
|
|
return PTR_ERR(br);
|
|
|
|
platform_set_drvdata(pdev, br);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void fme_br_remove(struct platform_device *pdev)
|
|
{
|
|
struct fpga_bridge *br = platform_get_drvdata(pdev);
|
|
struct fme_br_priv *priv = br->priv;
|
|
|
|
fpga_bridge_unregister(br);
|
|
|
|
if (priv->port_pdev)
|
|
put_device(&priv->port_pdev->dev);
|
|
if (priv->port_ops)
|
|
dfl_fpga_port_ops_put(priv->port_ops);
|
|
}
|
|
|
|
static struct platform_driver fme_br_driver = {
|
|
.driver = {
|
|
.name = DFL_FPGA_FME_BRIDGE,
|
|
},
|
|
.probe = fme_br_probe,
|
|
.remove_new = fme_br_remove,
|
|
};
|
|
|
|
module_platform_driver(fme_br_driver);
|
|
|
|
MODULE_DESCRIPTION("FPGA Bridge for DFL FPGA Management Engine");
|
|
MODULE_AUTHOR("Intel Corporation");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:dfl-fme-bridge");
|