Commit Graph

21 Commits

Author SHA1 Message Date
Greg Kroah-Hartman
8532b09fde Staging: aten2011: fix checkpatch errors and warnings
After this, only warnings are line length ones.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
9d7005450b Staging: aten2011: s/__FUNCTION__/__func__
replace __FUNCTION__ with __func__

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
9e3697a5cc Staging: aten2011: remove DPRINTK macro
Convert to use the dbg() macro we already have in the usb-serial layer.
This also turns off the default for the driver to spit out all of the
debug messages, now it is controlled by the module parameter.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
87ed9bd225 Staging: aten2011: fix up c++ comments
Convert all C++ comments to /* */

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
c3e06f2fc9 Staging: aten2011: remove wrappers around serial get and put data functions
Don't wrap things that do not need to be wrapped...

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
4649dd3a8f Staging: aten2011: delete the Dump_serial_port function
It's useless, drop it.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
12cbe0b338 Staging: aten2011: fix up the get_uart_reg function
Name it something sane, and fix up the code to be cleaner.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
e514adb0f2 Staging: aten2011: fix up the set_uart_reg function
Name it something sane, and fix up the code to be cleaner.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:38 -07:00
Greg Kroah-Hartman
e9abe30d6a Staging: aten2011: fix up the get_reg_sync function
Name it something sane, and fix up the code to be cleaner.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
8433b6a693 Staging: aten2011: fix up the set_reg_sync function
Name it something sane, and fix up the code to be cleaner.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
f3415eeb22 Staging: aten2011: remove paranoia check functions
They are useless so lets remove them.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
085c0904af Staging: aten2011: clean up init and exit functions
This makes them smaller, and fixes the name of the serial driver
structure.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
c725e43a54 Staging: aten2011: remove unused fields from structures.
As the driver was copied from another one, there are lots of fields that
are unused due to the hardware being different.  Remove a bunch of them,
more will be removed later.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
907aff4ab0 Staging: aten2011: fix up sparse warnings
This resolves all of the sparse warnings.


Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
a7fefd101e Staging: aten2011: remove function prototypes.
Reorginize functions to get rid of forward prototypes so they are no
longer needed.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
a6364092ee Staging: aten2011: remove unneeded defines
Lots of unused and unneeded #defines in this code, so lets remove them.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
c3858cbb95 Staging: aten2011: fix up comments by removing most of them.
This driver was copied from the io_edgeport.c driver, so we need to put
the proper copyright information back on it.

Also, almost all of the function comments are directly from the original
io_edgeport driver, and most of them are either totally wrong now due to
changes, or redundant.  So delete them all so no one gets confused by
anything.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
8b4efbe395 Staging: aten2011: remove kernel version dependencies
As we are wanting to be in the main kernel tree, remove the #ifdef
stuff for different kernel versions.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
e5ce610fd1 Staging: aten2011: move .h files into the driver
No need for external .h files for a simple usb-serial driver, move them
into the .c file to make things easier to cleanup.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:37 -07:00
Greg Kroah-Hartman
d93f87c840 Staging: aten2011: run lindent
Run scripts/Lindent on the driver

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:36 -07:00
Greg Kroah-Hartman
e6d69d91d5 Staging: add aten2011 usb to serial converter driver.
Many thanks to Russell Lang <gsview@ghostgum.com.au> for his
help in getting this working on newer kernel versions and
for pointing out this driver in the first place.

Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:36 -07:00