Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm: increase DRM_OBJECT_MAX_PROPERTY to 24

Browse Source 
Before Kernel 3.5, no one was checking for the return value of
drm_connector_attach_property, so we never noticed that we were unable
to create some properties. Commit "drm: WARN() when
drm_connector_attach_property fails" added a WARN when we fail to
create a property, and the transition from "connector properties" to
"object properties" changed the warning message a little bit.

On i915 machines with many TV connectors we hit the maximum number of
properties (since each TV connector uses a lot of properties), so we
get a few backtraces in our logs. This commit increases the maximum
number of properties to 24 hoping we'll have enough room for
everybody.

Chris suggested that we convert this code to "lists", but I believe
this conversion can come after we make sure people's dmesgs are not
spammed by our driver.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reported-by: Dave Jones <davej@redhat.com>
Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Paulo Zanoni 2012-06-12 11:27:01 -03:00 committed by Dave Airlie
parent d26098759c
commit fe45616805
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/drm/drm_crtc.h
View File

@ -54,7 +54,7 @@ struct drm_mode_object {
struct drm_object_properties *properties; struct drm_object_properties *properties;
}; };
#define DRM_OBJECT_MAX_PROPERTY 16 #define DRM_OBJECT_MAX_PROPERTY 24
struct drm_object_properties { struct drm_object_properties {
int count; int count;
uint32_t ids[DRM_OBJECT_MAX_PROPERTY]; uint32_t ids[DRM_OBJECT_MAX_PROPERTY];