Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-12 07:01:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

xfs: don't allow negative error tags

Browse Source 
Errors go from zero which means no error to XFS_ERRTAG_MAX (22).  My
static checker complains that xfs_errortag_add() puts an upper bound on
this but not a lower bound.  Let's fix it by making it unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Dan Carpenter 2016-07-20 10:37:13 +10:00 committed by Dave Chinner
parent 7f1b62457b
commit fbc21f33cd
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/xfs_error.c
View File

@ -55,7 +55,7 @@ xfs_error_test(int error_tag, int *fsidp, char *expression,
} }
int int
xfs_errortag_add(int error_tag, xfs_mount_t *mp) xfs_errortag_add(unsigned int error_tag, xfs_mount_t *mp)
{ {
int i; int i;
int len; int len;

2
fs/xfs/xfs_error.h
View File

@ -128,7 +128,7 @@ extern int xfs_error_test(int, int *, char *, int, char *, unsigned long);
xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \ xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \
(rf)))) (rf))))
extern int xfs_errortag_add(int error_tag, struct xfs_mount *mp); extern int xfs_errortag_add(unsigned int error_tag, struct xfs_mount *mp);
extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud); extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud);
#else #else
#define XFS_TEST_ERROR(expr, mp, tag, rf) (expr) #define XFS_TEST_ERROR(expr, mp, tag, rf) (expr)