Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-15 16:41:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

s390: fix gmap_ipte_notifier vs. software dirty pages

Browse Source 
On heavy paging load some guest cpus started to loop in gmap_ipte_notify.
This was visible as stalled cpus inside the guest. The gmap_ipte_notifier
tries to map a user page and then made sure that the pte is valid and
writable. Turns out that with the software change bit tracking the pte
can become read-only (and only software writable) if the page is clean.
Since we loop in this code, the page would stay clean and, therefore,
be never writable again.
Let us just use fixup_user_fault, that guarantees to call handle_mm_fault.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
This commit is contained in:
Christian Borntraeger 2013-05-17 14:41:38 +02:00 committed by Gleb Natapov
parent 7c470539c9
commit f8b5ff2cff
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/s390/mm/pgtable.c
View File

@ -677,8 +677,7 @@ int gmap_ipte_notify(struct gmap *gmap, unsigned long start, unsigned long len)
break; break;
} }
/* Get the page mapped */ /* Get the page mapped */
if (get_user_pages(current, gmap->mm, addr, 1, 1, 0, if (fixup_user_fault(current, gmap->mm, addr, FAULT_FLAG_WRITE)) {
NULL, NULL) != 1) {
rc = -EFAULT; rc = -EFAULT;
break; break;
} }