Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-28 13:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: vmw_vmci: replace usage of found with dedicated list iterator variable

Browse Source 
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220324073151.66305-1-jakobkoschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jakob Koschel 2022-03-24 08:31:51 +01:00 committed by Greg Kroah-Hartman
parent fd7e92d5b8
commit f61c5c830f
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/misc/vmw_vmci/vmci_context.c
View File

@ -665,9 +665,8 @@ int vmci_ctx_add_notification(u32 context_id, u32 remote_cid)
int vmci_ctx_remove_notification(u32 context_id, u32 remote_cid)
{
struct vmci_ctx *context;
struct vmci_handle_list *notifier, *tmp;
struct vmci_handle_list *notifier = NULL, *iter, *tmp;
struct vmci_handle handle;
bool found = false;
context = vmci_ctx_get(context_id);
if (!context)
@ -676,23 +675,23 @@ int vmci_ctx_remove_notification(u32 context_id, u32 remote_cid)
handle = vmci_make_handle(remote_cid, VMCI_EVENT_HANDLER);
spin_lock(&context->lock);
list_for_each_entry_safe(notifier, tmp,
list_for_each_entry_safe(iter, tmp,
&context->notifier_list, node) {
if (vmci_handle_is_equal(notifier->handle, handle)) {
list_del_rcu(&notifier->node);
if (vmci_handle_is_equal(iter->handle, handle)) {
list_del_rcu(&iter->node);
context->n_notifiers--;
found = true;
notifier = iter;
break;
}
}
spin_unlock(&context->lock);
if (found)
if (notifier)
kvfree_rcu(notifier);
vmci_ctx_put(context);
return found ? VMCI_SUCCESS : VMCI_ERROR_NOT_FOUND;
return notifier ? VMCI_SUCCESS : VMCI_ERROR_NOT_FOUND;
}
static int vmci_ctx_get_chkpt_notifiers(struct vmci_ctx *context,