mirror of
https://github.com/torvalds/linux.git
synced 2024-09-20 06:53:04 +00:00
rtc: sh: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231002080529.2535610-13-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
parent
e288cfe8f2
commit
f4d571b31b
|
@ -620,7 +620,7 @@ err_unmap:
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int __exit sh_rtc_remove(struct platform_device *pdev)
|
||||
static void __exit sh_rtc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct sh_rtc *rtc = platform_get_drvdata(pdev);
|
||||
|
||||
|
@ -628,8 +628,6 @@ static int __exit sh_rtc_remove(struct platform_device *pdev)
|
|||
sh_rtc_setcie(&pdev->dev, 0);
|
||||
|
||||
clk_disable(rtc->clk);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void sh_rtc_set_irq_wake(struct device *dev, int enabled)
|
||||
|
@ -680,7 +678,7 @@ static struct platform_driver sh_rtc_platform_driver __refdata = {
|
|||
.pm = &sh_rtc_pm_ops,
|
||||
.of_match_table = sh_rtc_of_match,
|
||||
},
|
||||
.remove = __exit_p(sh_rtc_remove),
|
||||
.remove_new = __exit_p(sh_rtc_remove),
|
||||
};
|
||||
|
||||
module_platform_driver_probe(sh_rtc_platform_driver, sh_rtc_probe);
|
||||
|
|
Loading…
Reference in New Issue
Block a user