Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 05:11:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PATCH] device-mapper dm-emc: Fix a memset

Browse Source 
The dm emc hardware handler code memset the hardware handler structure to zero
AFTER it had initialized the structure's spinlock field.

Signed-Off-By: Alasdair G Kergon <agk@redhat.com>
From: Dave Olien <dmo@osdl.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Alasdair G Kergon 2005-05-05 16:16:08 -07:00 committed by Linus Torvalds
parent c557308e1f
commit f1daa40b63
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/md/dm-emc.c
View File

@ -223,8 +223,10 @@ static struct emc_handler *alloc_emc_handler(void)
{ {
struct emc_handler *h = kmalloc(sizeof(*h), GFP_KERNEL); struct emc_handler *h = kmalloc(sizeof(*h), GFP_KERNEL);
if (h) if (h) {
memset(h, 0, sizeof(*h));
spin_lock_init(&h->lock); spin_lock_init(&h->lock);
}
return h; return h;
} }
@ -259,8 +261,6 @@ static int emc_create(struct hw_handler *hwh, unsigned argc, char **argv)
if (!h) if (!h)
return -ENOMEM; return -ENOMEM;
memset(h, 0, sizeof(*h));
hwh->context = h; hwh->context = h;
if ((h->short_trespass = short_trespass)) if ((h->short_trespass = short_trespass))